From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2DDEC433F5 for ; Tue, 17 May 2022 09:16:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33EFB6B0073; Tue, 17 May 2022 05:16:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 320826B0074; Tue, 17 May 2022 05:16:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DD406B0075; Tue, 17 May 2022 05:16:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0FF9C6B0073 for ; Tue, 17 May 2022 05:16:27 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C87BF20652 for ; Tue, 17 May 2022 09:16:26 +0000 (UTC) X-FDA: 79474679172.19.7D1AE62 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf25.hostedemail.com (Postfix) with ESMTP id EBDABA00C0 for ; Tue, 17 May 2022 09:16:02 +0000 (UTC) Received: by mail-pf1-f182.google.com with SMTP id x23so16349601pff.9 for ; Tue, 17 May 2022 02:16:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VbT9MivaGcVQLFLyZe58CMZOydl8bMnPHecbxMnGlAA=; b=K926XyreguR/4XEGI2/XdLSg8xqkk79XZxpz2krQ3cDJULT8zIyem67TELbGWBtmTg b05B8JjUy+SFZn96XQv2wbJdy6P1+68y3XmUl2REMzKOsiCerWpY4gxfkPaXYimAbdMw aPDfZjT5rKLnZhvekRWx46Led/eHS37TdbpQ+k2rA3u5jcJAA1qE4EjEdY61h/y1aGDJ HwKKYCRVUMiHvXIhC9uLV+1DSufpqUQKWO7jZmK8YgLeFAdxBOwUCCjPXoideDBIZwgv +DFJROmmKg7yUnB015J5PHMAo6BmnjJV06lEU25NzkLOxPGGWKOdzM+q3EK1WrqC3yTM NXyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VbT9MivaGcVQLFLyZe58CMZOydl8bMnPHecbxMnGlAA=; b=CD9u1Pty07adBXhhhNO1kvr4JKucn4yPaPYX8jpapFaOiboX16AJW2yZlRYpykihL+ YMh7mLwhY+uWwLQThVLqjXUDWBVt6e9Zluv3yyQwJgAihLrwgGQQDBmgJslwTz5o4mRj 3nD4LUMY/eOamv8JZ7lRHWSkei6MPDcD3sqbZoeKoPgJJcIC0czyEsWCNuvmqElerXOz bz5bYOVH231oOCKmbxf4+H6OPO2iMBJcXW6L1xWgF0goi8ahcVHOaSCFKEWUCzGy4DVw iqWZSuNuptP9jwJK6TaOoo8N8kdYS+M+PRiEKUe8r8qFRt1nbNaZF7YYpunRsIl5g18X 5NrQ== X-Gm-Message-State: AOAM5333nLwWrb0vzWRc/KSVwrnuNn22NiE2q7JCbgRK/tHtw9LnFy3Q ROC2FCDJ/cf/kBXssZiI9+KRzhgRvDCEe420On4= X-Google-Smtp-Source: ABdhPJwb7TUPydJ5uJgGFBM3zIUz6PP1+ayvhR0HdyDTVVnTuilVTQ3Ohszxg4ss5MiddupCWgYYK0W77rGbKie7r8Q= X-Received: by 2002:a63:4d4:0:b0:3c1:f13f:a9a1 with SMTP id 203-20020a6304d4000000b003c1f13fa9a1mr18365793pge.398.1652778984401; Tue, 17 May 2022 02:16:24 -0700 (PDT) MIME-Version: 1.0 References: <20220517082650.2005840-1-hsinyi@chromium.org> <20220517082650.2005840-2-hsinyi@chromium.org> In-Reply-To: <20220517082650.2005840-2-hsinyi@chromium.org> From: Xiongwei Song Date: Tue, 17 May 2022 17:15:58 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] Revert "squashfs: provide backing_dev_info in order to disable read-ahead" To: Hsin-Yi Wang Cc: Phillip Lougher , Matthew Wilcox , Xiongwei Song , Zheng Liang , Zhang Yi , Hou Tao , Miao Xie , Andrew Morton , "linux-mm @ kvack . org" , "squashfs-devel @ lists . sourceforge . net" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EBDABA00C0 X-Stat-Signature: n5rg84aayyuybarotro8ca4hidth6w3e X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=K926Xyre; spf=pass (imf25.hostedemail.com: domain of sxwjean@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=sxwjean@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1652778962-586024 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 17, 2022 at 4:27 PM Hsin-Yi Wang wrote: > > This reverts commit 9eec1d897139e5de287af5d559a02b811b844d82. > > Revert closing the readahead to squashfs since the readahead callback > for squashfs is implemented. > > Suggested-by: Xiongwei Song I'd like to use "xiongwei.song@windriver.com" in my tag. > Signed-off-by: Hsin-Yi Wang > --- > fs/squashfs/super.c | 33 --------------------------------- > 1 file changed, 33 deletions(-) > > diff --git a/fs/squashfs/super.c b/fs/squashfs/super.c > index 6d594ba2ed28..32565dafa7f3 100644 > --- a/fs/squashfs/super.c > +++ b/fs/squashfs/super.c > @@ -29,7 +29,6 @@ > #include > #include > #include > -#include > > #include "squashfs_fs.h" > #include "squashfs_fs_sb.h" > @@ -113,24 +112,6 @@ static const struct squashfs_decompressor *supported_squashfs_filesystem( > return decompressor; > } > > -static int squashfs_bdi_init(struct super_block *sb) > -{ > - int err; > - unsigned int major = MAJOR(sb->s_dev); > - unsigned int minor = MINOR(sb->s_dev); > - > - bdi_put(sb->s_bdi); > - sb->s_bdi = &noop_backing_dev_info; > - > - err = super_setup_bdi_name(sb, "squashfs_%u_%u", major, minor); > - if (err) > - return err; > - > - sb->s_bdi->ra_pages = 0; > - sb->s_bdi->io_pages = 0; > - > - return 0; > -} > > static int squashfs_fill_super(struct super_block *sb, struct fs_context *fc) > { > @@ -146,20 +127,6 @@ static int squashfs_fill_super(struct super_block *sb, struct fs_context *fc) > > TRACE("Entered squashfs_fill_superblock\n"); > > - /* > - * squashfs provides 'backing_dev_info' in order to disable read-ahead. For > - * squashfs, I/O is not deferred, it is done immediately in read_folio, > - * which means the user would always have to wait their own I/O. So the effect > - * of readahead is very weak for squashfs. squashfs_bdi_init will set > - * sb->s_bdi->ra_pages and sb->s_bdi->io_pages to 0 and close readahead for > - * squashfs. > - */ > - err = squashfs_bdi_init(sb); > - if (err) { > - errorf(fc, "squashfs init bdi failed"); > - return err; > - } > - > sb->s_fs_info = kzalloc(sizeof(*msblk), GFP_KERNEL); > if (sb->s_fs_info == NULL) { > ERROR("Failed to allocate squashfs_sb_info\n"); > -- > 2.36.0.550.gb090851708-goog > >