From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3693DC001DB for ; Tue, 8 Aug 2023 12:09:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EBC56B0075; Tue, 8 Aug 2023 08:09:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 99C578D0002; Tue, 8 Aug 2023 08:09:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 864C08D0001; Tue, 8 Aug 2023 08:09:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 78CFA6B0075 for ; Tue, 8 Aug 2023 08:09:23 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 39BE8C0C95 for ; Tue, 8 Aug 2023 12:09:23 +0000 (UTC) X-FDA: 81100817406.19.E54FEE1 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by imf09.hostedemail.com (Postfix) with ESMTP id 1BC87140029 for ; Tue, 8 Aug 2023 12:09:20 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=JnIApSCR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of sxwjean@gmail.com designates 209.85.160.41 as permitted sender) smtp.mailfrom=sxwjean@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691496561; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n17U5qh0OrK3kvBv9V9L+D0ClJ7otAlPJK+8puyUKR0=; b=8QY2qcGwjFajaWmxkpRMXtpBfK1dx4hRiP9PwmCyQ8v6CE/YzhrekWsrdmqr5gy88G7x/r 3bNczrS4Iuy3cuQB/aBglbc9NP4QvjBVXPXmiVibBTt+c+Yla65Gd+vbC8Spo/VI77Zb3i RKRbh+qIDgK4uhtIiTBi4oYn4NNgMEc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=JnIApSCR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of sxwjean@gmail.com designates 209.85.160.41 as permitted sender) smtp.mailfrom=sxwjean@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691496561; a=rsa-sha256; cv=none; b=ewMX8aEHYLzGJ/GTBe17NYx6C4I6hKxzSQ2rYkbiLd42rmF6UalPX+F36USVdqZvkgPuov RtTKcQvb5e0lV1gj70YURNmRyd05I152QriYjCEnB0H41AuDPsErcJWefWMrl+VYDsCXuk OwZEqd1uMoXO6h1B5Z4xK9BAySid85Y= Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-1bfc2b68090so2297525fac.3 for ; Tue, 08 Aug 2023 05:09:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691496560; x=1692101360; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=n17U5qh0OrK3kvBv9V9L+D0ClJ7otAlPJK+8puyUKR0=; b=JnIApSCR7/QDfhaMIdveZcLVztjt/V7r3cgj881go2kkk8peTXR6gQ5PHGr4+hGknB 99bzKm10jJeRFmPmCeKbhcD0su478pzTMjWVY5vZPoutAaIKHPPYNI/AbS/CUmzv8CdM whKpAh9qyv8/S26i6TvfvAMOX3Nll6is2juph1/WASRNHBWOEX8J4BjsdEIgwpK4kD8i NUZ8BSalXnAlvPu52/+qCAZQrFDbevWR2yJbzZSOAlcSbR/hNZixvZGjX/JJL5jr+KnK bCdnxGUNQZ1M8Zx3SJN1dH6ClX8DcX+Xag+60MtEVr0WF4iVlC1xjjK70N+O5xUioYC+ 4IKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691496560; x=1692101360; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n17U5qh0OrK3kvBv9V9L+D0ClJ7otAlPJK+8puyUKR0=; b=V6hVLjFt13i7rO+G0J76nQSnihLV4XUVZgQCJIdpio4ZYwcWtC41bYWzhWINPGcU3m udCpV3dGapZmq4S/2JNVjMeK3knC45i6jAgOPyQfcIfUCBs4pnCLLOf+IYSnlAFgf34L nTKftm2/v4T2L5qD9jGg8oFXgwJj4L67lG8s0lDrDG8UTc4qfaEhPCXZH4+KskBTGtB/ xnVHeN0qTGZ/T9WR68o8sHC6FpL4p3lTLo8nkzLVC+l5DpsbBLpOJGRwMJsQV1Evhmq6 TMJ5ykolXX4Qw5VKm0jt2WR6QpRH3NPF2U9UkoDyHe7dxTV+sbvKSl7EqPunimDMIgQ2 KLPw== X-Gm-Message-State: AOJu0YzJtTsU8GHKUxClNSl3CYauEVyUU7FQhQBZTrxAqlFbAThS2YXN 44wG2AWluM1xb9CBh2FwCHYi7SVGqTQYz5sc/oA= X-Google-Smtp-Source: AGHT+IG30KmbMbbDaYtdMmOkxgv/uetQA+YC5M2Co9rM0xOLArq1znaHye1BkMKO/WBSoz7ZRimYeFGXyPEKt5HXhuA= X-Received: by 2002:a05:6870:c1cc:b0:1bb:89b1:77b7 with SMTP id i12-20020a056870c1cc00b001bb89b177b7mr15189629oad.16.1691496560111; Tue, 08 Aug 2023 05:09:20 -0700 (PDT) MIME-Version: 1.0 References: <20230808022229.1560559-1-xiongwei.song@windriver.com> In-Reply-To: From: Xiongwei Song Date: Tue, 8 Aug 2023 20:08:57 +0800 Message-ID: Subject: Re: [PATCH] mm/memcontrol: add tips for kmem.slabinfo To: Roman Gushchin Cc: xiongwei.song@windriver.com, hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1BC87140029 X-Stat-Signature: mpg8ga58jptmwjrqeym9qipjhk9tfwmz X-Rspam-User: X-HE-Tag: 1691496560-825889 X-HE-Meta: U2FsdGVkX1+cCLcThbEKSo/CRFGuzS0uIkPlB08B7GI4LfbjxlkSpjCBG6eYoPuDlQ0tCeD1Sp3caP0XUGRvf9iqcclDgXTFSGb6sZe1xDA6j9lOoWLeSrkbf1y7YW75zFu43wBM+Sf9unG76K4pAwTAA3Sh8kxfQcuPVqI2kD/xcIx3x025x5Tdcr5trb8T9i7xCn6490RiFQJstrw5E6XOTiw3AEdKm1v8bTu0N2gzH+J46FWGpPChVbez74sZFFu5+OXcJ/mBh/We48/q20WqBjkoGXJlPIOTIUuZNWr/fPbUHpf/eNW3IWFbgIpmL7dLU8N+6sq5qeu7d10OeqQRVWrjKciAnBQtfAId1XiiWk4kStX5mObPFOPr3AWBjN6o9eRy0kcjdQxkmvyKU+lV+6RHoPbc+vCG/1XsA+behvnrLbFLs8xwVEpopbNLVah2vXjJMGDuXuPhVEZz9lS3ymicrXFuOU6UhcY0LCU5p04R2atJN/b9pgUN6LrMKSJylKkhjJ8WsEhaR4Y0I5cXSCQOM4c5DVuhxPqen9gFeQ/wfx6gz4pf5XNumR5xU8EAgjtj4fjvqVGXgTRYfjrqUNV8qj+KFdy9KckzP0d/xmQNqH6I0WwrEWVa9vuR4+Mut3rsH70wawt2KNc2kKyZN17+IZIuqQwy5WSVtk0gTKmgP1/eaFoeAKXDyvLIS57gaa/CcPaMoe22KQDLLWe9hmE5DSNKbFxFwRAMe9tt6g7k+wcxsBgptyy3gk8KlxUlHyA6fSf2Tce+Cn7IHcXUaBDyqV2yGMf3fmF+Qy2dthfWYq1CGC8rFmfUjswzgPm0ZMX463ICMZaJ4mKkDEQAuClyGj1F8rfwKf3XIdSIwOCDlF91EYRCVral1JrOaU7XVznarvg5XSblJhwE63doOGqjkfaIwsz4OH+EPo5C2UwqgJRF9g/sexWTeu7orM8b4Rbr1bx2LYJlRv9 QJSyIIRo luzphT1sUsLEEfLYs19CyZylxq3JPjv9f85G2rBpu52GC19ZODeL9B39gtfR+nxRKgc//swTn/HBHflowjr4U9OIJdyVasi4FGFqLtDeDbS+pLy2dSezZqpgGigMzTbCSEfLqsCmW0LThXbVlnmzh6bpOCjcoQVt5Fq5VHopydS8r0V7orki+F06AenxlWj6BDSxHJWC4eBeVz0ST5qfwnkeJUvI0UAklFlJcEMwB/iIpmv08p3Ey/3D4eaLK752DIIlOA8D9kJ+MdIPSjGZiSiUea4SV8fVziRC0tk6qDVdK08e+Ay0EQIKrq1rVSjzY9qtEHObgt8Pb47ZwUdOSXAYXzOgVVL8NhQjA1dgkc2rcuMhGZniU1hXI4ZoqcD14w7vjRz8WD6FgNvJUKpAwmnwf1CUCL0aDjhl9noQVuJR04IekrHPn0QvJ5eXOwJUDk25i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 8, 2023 at 12:00=E2=80=AFPM Roman Gushchin wrote: > > On Tue, Aug 08, 2023 at 10:22:29AM +0800, xiongwei.song@windriver.com wro= te: > > From: Xiongwei Song > > > > No any output from kmem.slabinfo, which is not friendly. Adding > > tips for it. > > > > Signed-off-by: Xiongwei Song > > --- > > mm/memcontrol.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index e8ca4bdcb03c..58d3bd93890b 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -5002,10 +5002,8 @@ static ssize_t memcg_write_event_control(struct = kernfs_open_file *of, > > #if defined(CONFIG_MEMCG_KMEM) && (defined(CONFIG_SLAB) || defined(CON= FIG_SLUB_DEBUG)) > > static int mem_cgroup_slab_show(struct seq_file *m, void *p) > > { > > - /* > > - * Deprecated. > > - * Please, take a look at tools/cgroup/memcg_slabinfo.py . > > - */ > > + seq_puts(m, "This file is deprecated.\n" > > + "Please use tools/cgroup/memcg_slabinfo.py, which is in k= ernel source.\n"); > > It'll break the ABI. > The only possible option here is to use WARN_ON_ONCE(), which will print = once to dmesg. > But honestly I'm not sure we need it. Ok, thanks for the comments. > > Thanks! >