From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48504C433EF for ; Thu, 10 Mar 2022 01:18:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C68A28D0002; Wed, 9 Mar 2022 20:18:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C16EC8D0001; Wed, 9 Mar 2022 20:18:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADEE18D0002; Wed, 9 Mar 2022 20:18:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 9E86B8D0001 for ; Wed, 9 Mar 2022 20:18:22 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 677146079A for ; Thu, 10 Mar 2022 01:18:22 +0000 (UTC) X-FDA: 79226716044.12.57C1C14 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf30.hostedemail.com (Postfix) with ESMTP id 0C7368000A for ; Thu, 10 Mar 2022 01:18:21 +0000 (UTC) Received: by mail-pl1-f170.google.com with SMTP id e2so3478652pls.10 for ; Wed, 09 Mar 2022 17:18:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J4hEHK6Zf1OckbrcPAbGgRaFqGZN8ERpSZRldjSg7T8=; b=TyPdmdqiekZ/n9d4Ed7fThBKKvMOiRXpDBhk6CRTb1CCdBbZsdfWVidPWd8lkBIlQt Bi9+tIghX0iKpdES4tS2LA7m4erzVJERrwWD6sSCN5IWzYALAa4XtoXTRpIn8cCoVHTn anQ8wi6VRV9z2fMzamLvqbFJZzmhj4hNl9Ne/Sqxdk3cAVLWqGdjeH9b2/NthE0ZezPL GzCixCaNGxZ185gA/obGKTBeM6YkTPF1pKDOOEIDD7SKc6Oh6lQfaMJ1zAtm1AMZXv5Z eXXktCwVVJEvXH1+tpO/TlGMZvHQusQu2JgfeT8mnB6KSfzdHKQGoJTZWuhN1O2YUthN Huzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J4hEHK6Zf1OckbrcPAbGgRaFqGZN8ERpSZRldjSg7T8=; b=ev8Vm8agcg3JgXDovEriVLOAS89XlYiQyVGptTsXJxyi+wzXdvvC57bVFFyCZLaXNF uuSzWvlLN4KzSpUbDFf2vMHfWUfkEP51Mg9Kmcfl/25R1eb+EVQFwRHmSbTW2Evn74h2 lFxWdaXTWIrPdTKQ7aWIGGqGQH/OQTQiPYCFaXd4AqKRZbfO50WPpcizQHRZo2CUCRpT 4zQOoo3MyTT0zrqnx0o0hlpW7cfRo2FgXKXOXRjLdjtkxyB0IHzPWvu8AIyL+TvALkFy 0FEZCfXUQs/YwFKhNyaK8c34iYD9vB6vdr8ZWUb/CYhmroyPbfpBTii07p7HEeQjG9xA IGjA== X-Gm-Message-State: AOAM533CpInfQpeMBxFKOcMMTEZZIA6Lv6fqhiu5bUdIGBXce+hXgm+d DfbLz023niGsSbnRKrz51/HKk2Y6XppILxiW2wU= X-Google-Smtp-Source: ABdhPJz9Ii4BygLhegpERqY0L1cI7YoixvVkAriv4MwFiwa2tw1+EVbTxcqMEPb5H+euWYwDgkEH8Zb8elfW4q2D2WU= X-Received: by 2002:a17:90b:a41:b0:1bf:72b5:ae95 with SMTP id gw1-20020a17090b0a4100b001bf72b5ae95mr13350672pjb.110.1646875101000; Wed, 09 Mar 2022 17:18:21 -0800 (PST) MIME-Version: 1.0 References: <20220309145052.219138-1-sxwjean@me.com> <20220309145052.219138-3-sxwjean@me.com> In-Reply-To: From: Xiongwei Song Date: Thu, 10 Mar 2022 09:17:54 +0800 Message-ID: Subject: Re: [PATCH 2/2] mm: slub: Delete useless parameter of alloc_slab_page() To: Matthew Wilcox Cc: Xiongwei Song , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , longman@redhat.com, guro@fb.com, linux-mm@kvack.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0C7368000A X-Stat-Signature: b4nfq8xp3he4w63ojrxzqn7megj96mmq Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TyPdmdqi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of sxwjean@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=sxwjean@gmail.com X-HE-Tag: 1646875101-789536 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 9, 2022 at 11:29 PM Matthew Wilcox wrote: > > On Wed, Mar 09, 2022 at 10:50:52PM +0800, sxwjean@me.com wrote: > > From: Xiongwei Song > > > > The parameter @s is useless for alloc_slab_page(), let's delete it. > > Perhaps we could add a little more information here. > > It was added in 2014 by 5dfb41750992 ("sl[au]b: charge slabs to kmemcg > explicitly"). The need for it was removed in 2020 by 1f3147b49d75 > ("mm: slub: call account_slab_page() after slab page initialization"). Ok. Will update. > > Reviewed-by: Matthew Wilcox (Oracle) Thank you. Regards, Xiongwei