From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EABDC433F5 for ; Thu, 10 Mar 2022 01:18:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D78118D0005; Wed, 9 Mar 2022 20:18:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D27798D0001; Wed, 9 Mar 2022 20:18:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEFAC8D0005; Wed, 9 Mar 2022 20:18:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id B27228D0001 for ; Wed, 9 Mar 2022 20:18:49 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 544D8A0A2C for ; Thu, 10 Mar 2022 01:18:49 +0000 (UTC) X-FDA: 79226717178.19.0B7F89C Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf08.hostedemail.com (Postfix) with ESMTP id D6F7D160018 for ; Thu, 10 Mar 2022 01:18:48 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id kx6-20020a17090b228600b001bf859159bfso6891993pjb.1 for ; Wed, 09 Mar 2022 17:18:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f3b2mjjq1mHcjmOgIT8uYofnDUrYP6rBEFBC8nbAEVo=; b=e/w5dQf3sCiBt2/uT4NupMc7nhScIOA1t7tI7nc+VMK+agjcXmz2nb62a8/EvbhIFh RWavHFDvn8WwY33us47MxG5HLusoAJHKGDhLJEKQKzrKSdF7aCPVhnd4xI5fn4acZNAH YA0O9CL5ytnYfCzTLFg11EqTQS1GG9HnIfBaeYIECcGYzFNw5Qg/dr7jwoTQIc8HqYcU 31es6Fog5L2tr7jl9ohuvHs9GyDXke3XNqu0/M0ypMT0zy5KiMWTVuVcA5lgREyI2Z61 JQHwZ2IJwoiv+ZTwnFZQLTzWzNGRnAbxhS/s30rn8ERv8ppSPYS16KX5C0RVJNnwoDea CsXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f3b2mjjq1mHcjmOgIT8uYofnDUrYP6rBEFBC8nbAEVo=; b=L70J42V0lLW4NqlIEqRPoy1OMOorr+q2JobnuSyQxjp/SQWQGzGpsVsrDWfBTY/QsB 30gjVNv2kHHCu/czAwptesTJ51ay3MqCMzGEyj1wWbCxZENTBAfJQ7OV2vfHytn526bh kLoc3kNr6Km5xSn9NlipBWQvMBBHeU/swI4bv38FUxlVTuC4bI8ebj8uoslbKBKBKIza 3DJe02Dnri7KR24fNCF2l/iBWMVMmbDtyXGzwo0l36VrS5fpIkzbfScsQGqP5dJj8Cni LsnBF6rY8AG/UvL4UzC924AVCx4l7M8hg6ZlJBQcb0nMpg2+wVOIXTsJXWsvkkf2TMAu x0aQ== X-Gm-Message-State: AOAM533XGZsLLxRwO9kxu66n6pRjbujQideRhiSVzHqn6g9Qi1LqlKiz UqOMVoWtN8o8B8+VHbvd87eED9xCHsaCuVpMc2I= X-Google-Smtp-Source: ABdhPJz4iTGal0kDNh/jp1SKXcjW6M3pQjsU6lksmYnVKrpJfbMk6adEP9gHkfkQm55robBYlwj+Hz/O4lxDQXWulho= X-Received: by 2002:a17:903:1d1:b0:151:9e73:61b1 with SMTP id e17-20020a17090301d100b001519e7361b1mr2378719plh.84.1646875127921; Wed, 09 Mar 2022 17:18:47 -0800 (PST) MIME-Version: 1.0 References: <20220309145052.219138-1-sxwjean@me.com> <20220309145052.219138-3-sxwjean@me.com> <7c116655-a4ce-5f61-2d98-e85c31e11184@google.com> In-Reply-To: <7c116655-a4ce-5f61-2d98-e85c31e11184@google.com> From: Xiongwei Song Date: Thu, 10 Mar 2022 09:18:21 +0800 Message-ID: Subject: Re: [PATCH 2/2] mm: slub: Delete useless parameter of alloc_slab_page() To: David Rientjes Cc: Matthew Wilcox , Xiongwei Song , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Vlastimil Babka , longman@redhat.com, guro@fb.com, linux-mm@kvack.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: dx4fji4o7yuxctc8kyuc9hseh9ekgocp Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="e/w5dQf3"; spf=pass (imf08.hostedemail.com: domain of sxwjean@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=sxwjean@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Queue-Id: D6F7D160018 X-HE-Tag: 1646875128-756286 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 10, 2022 at 1:15 AM David Rientjes wrote: > > On Wed, 9 Mar 2022, Matthew Wilcox wrote: > > > On Wed, Mar 09, 2022 at 10:50:52PM +0800, sxwjean@me.com wrote: > > > From: Xiongwei Song > > > > > > The parameter @s is useless for alloc_slab_page(), let's delete it. > > > > Perhaps we could add a little more information here. > > > > It was added in 2014 by 5dfb41750992 ("sl[au]b: charge slabs to kmemcg > > explicitly"). The need for it was removed in 2020 by 1f3147b49d75 > > ("mm: slub: call account_slab_page() after slab page initialization"). > > > > Reviewed-by: Matthew Wilcox (Oracle) > > > > Acked-by: David Rientjes Thank you!