From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C20C83F07 for ; Mon, 7 Jul 2025 12:06:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC66E6B00B4; Mon, 7 Jul 2025 08:06:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C02378D0002; Mon, 7 Jul 2025 08:06:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7BE68D0003; Mon, 7 Jul 2025 08:06:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 86EC08D0002 for ; Mon, 7 Jul 2025 08:06:02 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1FB0310ACB5 for ; Mon, 7 Jul 2025 12:06:02 +0000 (UTC) X-FDA: 83637340164.13.143D993 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf08.hostedemail.com (Postfix) with ESMTP id 24BE8160009 for ; Mon, 7 Jul 2025 12:05:59 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=readmodwrite-com.20230601.gappssmtp.com header.s=20230601 header.b="o/XE86cj" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751889960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AbRTOhGVmvoLFbv7787UbxqrHjCa5AmcSlfrkYU6bVo=; b=EkWH1O0BNkSbQJOFAK0JGoiYSA7mjYoy5pexUqGemIFg8yrYBNLp2cesgudZTqezFMgDFS Y1XZfX+w1CXs/IhxxstwyvmJ4Gu+EaUSEamTknVG6+4fGseVsydgRWY8aA7gjrmRsggrhc XTBe56gknC+s02+4YIzH9hJd9SL2gQw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=readmodwrite-com.20230601.gappssmtp.com header.s=20230601 header.b="o/XE86cj"; spf=none (imf08.hostedemail.com: domain of matt@readmodwrite.com has no SPF policy when checking 209.85.216.44) smtp.mailfrom=matt@readmodwrite.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751889960; a=rsa-sha256; cv=none; b=ExBSuhHeh4zBesLsvLJdcEAD8fV+TlQOPiFt73fqTqhjcftVtRY3JDzs9v7rt0rr7qcRj1 BwDskrqN4YCRLDXBCSqAE7vdaa5uLdt2v0VCb8lauoN3mL4awalUdISiTcmF+5VIFp1tg8 QD8tprmqWzftmO/m0e0gqPx6WPvO5r0= Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-31223a4cddeso2138477a91.1 for ; Mon, 07 Jul 2025 05:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=readmodwrite-com.20230601.gappssmtp.com; s=20230601; t=1751889959; x=1752494759; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AbRTOhGVmvoLFbv7787UbxqrHjCa5AmcSlfrkYU6bVo=; b=o/XE86cjMceUpiZwzKUYUV8Y8nC8nXksU4kgNAegCaWvuHxzrZhOMXJVgpN+/ZLTR7 OdJ41gj8A/NcUhdXIZPUK9rilUzauNgvBUlRduyEM36ZY4gmXFNZ7ldO48v/gNBe512M E2l2HV5BDsNuN8WIDgi8rYXO/yjJSlmgck38i8W3OqMQb5pGoDtkR8YCljGtwkYCmZDx F8EtI2JCK8wd9vUfqzFmu8n+1T7/IjZ8JwXapEHD6krfxLqL5tUPUVweyml2VMzfby8M NA17WyMi40JX+frdU1ZFQ+RLgVfBiPVpb5HhKf0TwiMwoWj1K89xjjqpQcGuZBD9n4RE BZ7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751889959; x=1752494759; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AbRTOhGVmvoLFbv7787UbxqrHjCa5AmcSlfrkYU6bVo=; b=FlwafD/jRoQM95RJqoDV3pbtRwo5oZlxHvNNYVObAPsP3rCZFZZxa4gnKbhgNYX2Y/ 0rnzzt9oJmbomZjzj06I1IoTRlCqHMPBdZGYi9dShRu8UlSegEs7jixh8RXTOUcrTGpF 9saORFNaEXmC0u/4a1lE4KlXyPKdOu4MyRw5kxYsA87kuwDCO6IGxPXG5a0DFHF+t4nb PcG5DCgEeGJQdnryxLHvEfK/We3TkjCI42rL/v7KSBpBVuL5O0a1oYAQZPvynxvoDDXq dVm+2zBA0U9MqmtCxwrlRbBXA8MuvO8KnjY+zwlk8IAWxzchlNCbrF1ncNmxggXW+q0J nnYA== X-Forwarded-Encrypted: i=1; AJvYcCVj9bmRFHOJOTvJHUmdJTx1rpDI1vnxN0GkhwZ7KB8634T7grbwCTsb3s+vQwxF/p3ji5r5Tvb8lw==@kvack.org X-Gm-Message-State: AOJu0YyWtmjVySLqcXuW8LbE1errmhlCiwrfDABYAnM3HozAuZwU20z4 nQrrl8FvOHyYzc4frEnwaL+rG8qzmOlL7pqYU511rPorgBveFgJsGkH54s/4t4Vvf+nXoEika1r LWt3xriTNmSm6uoJLsFM1B9pRRPq5Q1o6Bwt+hmmZuQ== X-Gm-Gg: ASbGncugqj3oHqYWZdk1nWd8bPJQ6GN84wy5No3A1iXKditJmA+BGpVopfm2O1Phgo3 G/bkTPUk/eZQ3mCYZMcoSzThEInBuoQnrW9Z71yb0Q379C2c5pMefxwW93XgEZXHbNgTmlqKZQq y9DYEY7JDq7c9PuCgdcvkK0ydCjnmnk2WsTvTZH2D46nK66d2Eu2tATmWQrBSy X-Google-Smtp-Source: AGHT+IGUdt3KMjfnarURaNeP6WlX5nDMccMisIpvVAtRfZIXRm1ihWFRYUMZ6WRww+XZ0TQLt/UUU5X1wU/E7Un8bGY= X-Received: by 2002:a17:90b:2ecd:b0:311:ef19:824d with SMTP id 98e67ed59e1d1-31aadcb0f0emr20626562a91.2.1751889959009; Mon, 07 Jul 2025 05:05:59 -0700 (PDT) MIME-Version: 1.0 References: <20250704120604.2688934-1-matt@readmodwrite.com> <202507051300.E0JSHxu1-lkp@intel.com> In-Reply-To: From: Matt Fleming Date: Mon, 7 Jul 2025 13:05:47 +0100 X-Gm-Features: Ac12FXzyYmYk7YR7M3ps6gHcAJL7EYFN2ugE_j8ajeQSisU5-HpmQRqbIHrcaFw Message-ID: Subject: Re: [PATCH v2] stackdepot: Make max number of pools build-time configurable To: Marco Elver Cc: kernel test robot , Andrew Morton , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org, kernel-team@cloudflare.com, Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Oscar Salvador , Vlastimil Babka , Matt Fleming Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 24BE8160009 X-Rspamd-Server: rspam09 X-Stat-Signature: ewa88ix8i8mmft3xuyiow65fokryd7ga X-HE-Tag: 1751889959-325809 X-HE-Meta: U2FsdGVkX19FgBYPAeaJYWnvh/2GN+WcnrwdvKnZ0HxEW2FUeW3rQb0YOn+fuoAcppirY/Ovnp3WnpfJ8wbXujSbjtSRtPGoNpyiHxJAZxRxAyW5tFy6sLPoo0q6E7t8C2BasRUjAv6QPU8Z/V7ZAmHzBtAWtfWnu+GOlMWeF96xSz9EfoorgHknQprAv06qSz+i5ZZNZcBJB72HSgmIHcOx6108Ol0jeQeOuXhQP866m8QygW8TtpDyaTxnBAThwIWDzqN6/HD4i3M12+CAGTp2ywOx++2BCbeSrWIg5xsre3cJZitWI34Rm6pQK/z+pKgCLYsxEVZwHpZ3S3jCudeSdvvUdF0nDkaGl6xqF8sj0KBjV1NHBFHZ2xFEWo3anwrFs3J1XjO9TgqUwcvhbWKc6LhSPj9D/jvD+b/AmSG1PFMjlH0oKH/o1EKLy52+ZuE9tvZMImPvPgtN8tg2SrF4tIInj8l82Xi0YCTA36G09KUNp5FCo6XB21nbrJM5/OMrBAEzZjKLmFTvaKtRE5xMGmTJHj2pnQcKeNTswDP8YrTH7cTE6gwBuXg1JpaVlz9GjKS2CcSpMzzHDjXAMmsXbLZzjP69G3LVx9S2Bm7stzOocAQSMHsgxcKZBnDjQWBj9CLnJpiUYIsHiOD+xWb9bg2Xtx/V5kbJbXx26bJrBh+bTgUcACuYzfgxCimWQhNlE7yyjy/zfhDBgXkQSOSGnIchqhr26m4w9jReYedcJM6RRzLcQH0wyN2ZjinVev90OCYrjTO5awlnY/qYxVk2ru3+goKNgG6iEwr0qz+b2v+Xs1ctndATafGmbNtSb6yFZbi5gq9QP6SzUfPcigoZ0GRPUIhhR4eCHs5d384nM55AuSdu6XJ9A6p4RuqtQq2sWhmx3B3hnfdJTpd3F6KzczemJDErXyILNIXiAo7Z2d5OyWQal3cJP2Kv4rqTqX4Eyitx2XTBkUMI0+h l2fDKDJW x2xgBM5Kaqzggw+WBFnWtnfqWVVzUTJs4FkOdzvfp4+9qrsLcVT7KZgJXaFizoJPPz18sJRCD/tYRN8wouhXiGK3ORuyibEl57BaGgKAAJ87m7IR5lZMCsrtyM/8VlFOpDDRFZhHQvY9GNmQ5qPjjC/Odg3Ef5DA8Q3GzGeQ9IB5wXmRyR0ohJYXjI1AZJ5S7z5y9XzoWlnDXMvV0cQ9Ku+qWAkLKPw5j4Ay/5cEuf0s/wCcBblvYi8frtWbhmhgOgpt5a2l0kHvW9rjOocok6mwzdQpfCe2PZ/o3OPIY2+ObaVInDSojMakfqentZdg+AfvWKdV1aiK7f6YZEnbSm3IkpgbuYN5V03H2MSZvT3JB+B4KeDYd4msiygLa5Llsw3Es X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 7, 2025 at 7:40=E2=80=AFAM Marco Elver wrote= : > > On Sat, 5 Jul 2025 at 08:01, kernel test robot wrote: > > > > Hi Matt, > > > > kernel test robot noticed the following build errors: > > > > [auto build test ERROR on akpm-mm/mm-nonmm-unstable] > > [also build test ERROR on linus/master v6.16-rc4 next-20250704] > > [cannot apply to akpm-mm/mm-everything] > > [If your patch is applied to the wrong git tree, kindly drop us a note. > > And when submitting patch, we suggest to use '--base' as documented in > > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Matt-Fleming/sta= ckdepot-Make-max-number-of-pools-build-time-configurable/20250704-200804 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-= nonmm-unstable > > patch link: https://lore.kernel.org/r/20250704120604.2688934-1-matt%= 40readmodwrite.com > > patch subject: [PATCH v2] stackdepot: Make max number of pools build-ti= me configurable > > config: arm64-randconfig-001-20250705 (https://download.01.org/0day-ci/= archive/20250705/202507051300.E0JSHxu1-lkp@intel.com/config) > > compiler: aarch64-linux-gcc (GCC) 10.5.0 > > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/arc= hive/20250705/202507051300.E0JSHxu1-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new ve= rsion of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202507051300.E0JSHxu1-l= kp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > In file included from include/linux/init.h:5, > > from include/linux/printk.h:6, > > from include/asm-generic/bug.h:22, > > from arch/arm64/include/asm/bug.h:26, > > from include/linux/bug.h:5, > > from include/linux/vfsdebug.h:5, > > from include/linux/fs.h:5, > > from include/linux/debugfs.h:15, > > from lib/stackdepot.c:17: > > >> include/linux/build_bug.h:78:41: error: static assertion failed: "DE= POT_MAX_POOLS <=3D (1LL << (DEPOT_POOL_INDEX_BITS)) - 1" > > 78 | #define __static_assert(expr, msg, ...) _Static_assert(expr,= msg) > > | ^~~~~~~~~~~~~~ > > include/linux/build_bug.h:77:34: note: in expansion of macro '__stat= ic_assert' > > 77 | #define static_assert(expr, ...) __static_assert(expr, ##__V= A_ARGS__, #expr) > > | ^~~~~~~~~~~~~~~ > > lib/stackdepot.c:42:1: note: in expansion of macro 'static_assert' > > 42 | static_assert(DEPOT_MAX_POOLS <=3D (1LL << (DEPOT_POOL_INDEX= _BITS)) - 1); > > | ^~~~~~~~~~~~~ > > This is odd. The randconfig here uses the default: > > > CONFIG_STACKDEPOT_MAX_POOLS=3D8192 Ugh, I see what's happened here. For this config, the expression evaluates = to static_assert(8192 <=3D 8191); So the default needs to be 8191.