From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72DD3C352BE for ; Tue, 14 Apr 2020 23:00:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 26AFF2076C for ; Tue, 14 Apr 2020 23:00:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=magicleap.com header.i=@magicleap.com header.b="a04Fk+K2"; dkim=pass (1024-bit key) header.d=magicleap.com header.i=@magicleap.com header.b="uQXMvzK+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26AFF2076C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=magicleap.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BF4328E0005; Tue, 14 Apr 2020 19:00:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA49D8E0001; Tue, 14 Apr 2020 19:00:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6CB88E0005; Tue, 14 Apr 2020 19:00:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id 8E4738E0001 for ; Tue, 14 Apr 2020 19:00:24 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4CBDE485F for ; Tue, 14 Apr 2020 23:00:24 +0000 (UTC) X-FDA: 76707981168.12.cave62_20923fec4ff07 X-HE-Tag: cave62_20923fec4ff07 X-Filterd-Recvd-Size: 7683 Received: from mx0a-001e9b01.pphosted.com (mx0a-001e9b01.pphosted.com [148.163.157.123]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Apr 2020 23:00:23 +0000 (UTC) Received: from pps.filterd (m0176108.ppops.net [127.0.0.1]) by mx0a-001e9b01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03EMuOl1022844 for ; Tue, 14 Apr 2020 19:00:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=magicleap.com; h=mime-version : references : in-reply-to : from : date : message-id : subject : to : cc : content-type; s=pp09042018; bh=h7uCBdYOOlbhULtGzMDvelvXd/L31rpM8ohvJibODFY=; b=a04Fk+K23ZwXKElmXN9wc2YOXywqfTGrZ28vzNNTzqUpxCgdzw7rLI8jiX9DeUG8mdpP TA7pnUpaU9cWClSY2Qmny6Ii9uH//unfE7XRRZTM8FqunkwBjT2OYV/tLmhujKigibrO ONzn3rkXWlnFTDme1VtEgnlzOS5wBRI8rCmkWz8NoipzAm7nnQ+zFxUQ7MM9N+h8+uk9 f75o5zOy4jF+zoCopa4IO7HDAZDRYVEXX/D5JR8TlFWKlFwGC4uRgxw2HZxWXR4pVPjA kqxB/QRhxmTGmcxnrlFsxrA1V/hKtLJJNg2Ih7tZJENFA2Yc84g/qetosVqui62gegn/ JQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-001e9b01.pphosted.com with ESMTP id 30dn9u82jh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK) for ; Tue, 14 Apr 2020 19:00:22 -0400 Received: by mail-qv1-f71.google.com with SMTP id p6so1290351qvo.18 for ; Tue, 14 Apr 2020 16:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=magicleap.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h7uCBdYOOlbhULtGzMDvelvXd/L31rpM8ohvJibODFY=; b=uQXMvzK+PcuO/4vdcen2hvJ7pTjDEayBvihOwVMPNQMr4TdKID8bjWwjMLmrYid6Cr cJmK7hicwd1giILSFNMm7W9fRA9hZ2o0p2zdGackui2JNcwGdeeJEtiW2tm2O+uO467j MhC/8CGeMb9MU1lHpex5DizDij2/eE0fEn6dM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h7uCBdYOOlbhULtGzMDvelvXd/L31rpM8ohvJibODFY=; b=E0jOoNhWJ1/Fn8DBdPMOlcAGPiuON3ReyMEP1Fv9f0+2ZoI1n7E4ocHBVHFzHrnqZF K5zETyoE3BYSBecy9WVyUgbuhxncSjRtwuoFBZ4zedj1uTThaB5rRkBfqiorN31WIBMz 8O7YPjH/ULy6bR0T3C6pb9wRlJHNnMOR68aFaYV5sfrS1FSWuEWoCDfVDV2nSTWWdwFZ Y4p5b06w9kUtQ9HGjGcGSXYjUU545qvEOMqYInDbigU5QtVm2Ta16q+1MnKa5XNzCBJF bz+GpY3zBUBajU2NOpR58FXBV0wC6c8fQRINUCN6hbUHPkKRYV9GL3VZe+0Ytu7PQZ7u lepg== X-Gm-Message-State: AGi0PuaeQ6rfcrAyEoZL5tzbJ7iyZlQCRdv8wq/VYNxvSRBtjVhOf0Ju wON7IIuFn+JFSqzZHdyymcDJCIHOR+GtBAjHLw0gBbcP2JgrhcJ0pzwhip090LA83IyKvBWbqnT 9YalfzxO00o7XzKFVwrEF6iQssc8= X-Received: by 2002:a37:4902:: with SMTP id w2mr20884623qka.13.1586905221055; Tue, 14 Apr 2020 16:00:21 -0700 (PDT) X-Google-Smtp-Source: APiQypKWqJ7n6QBuG425fCPj3Wq+SD1Y7NWs5GaIpEIdHzISysTUhGMb0T5pQxIdO79vlTyZAT35p0lKcBrLTvmLTag= X-Received: by 2002:a37:4902:: with SMTP id w2mr20884594qka.13.1586905220775; Tue, 14 Apr 2020 16:00:20 -0700 (PDT) MIME-Version: 1.0 References: <20200413215750.7239-1-lmoiseichuk@magicleap.com> <20200413215750.7239-2-lmoiseichuk@magicleap.com> <20200414225525.GA1892067@chrisdown.name> In-Reply-To: <20200414225525.GA1892067@chrisdown.name> From: Leonid Moiseichuk Date: Tue, 14 Apr 2020 19:00:09 -0400 Message-ID: Subject: Re: [PATCH 1/2] memcg: expose vmpressure knobs To: Chris Down Cc: hannes@cmpxchg.org, Michal Hocko , vdavydov.dev@gmail.com, tj@kernel.org, lizefan@huawei.com, cgroups@vger.kernel.org, akpm@linux-foundation.org, rientjes@google.com, minchan@kernel.org, vinmenon@codeaurora.org, andriy.shevchenko@linux.intel.com, penberg@kernel.org, linux-mm@kvack.org Content-Type: multipart/alternative; boundary="000000000000fa1c9905a3482902" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-04-14_11:2020-04-14,2020-04-14 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=848 mlxscore=0 impostorscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 clxscore=1015 priorityscore=1501 suspectscore=1 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004140163 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000fa1c9905a3482902 Content-Type: text/plain; charset="UTF-8" No problem, since cgroups v1 are frozen that is a valid stopper. Let me check what could be done about PSI for swapless cases. On Tue, Apr 14, 2020 at 6:55 PM Chris Down wrote: > svc_lmoiseichuk@magicleap.com writes: > >From: Leonid Moiseichuk > > > >Populating memcg vmpressure controls with legacy defaults: > >- memory.pressure_window (512 or SWAP_CLUSTER_MAX * 16) > >- memory.pressure_level_critical_prio (3) > >- memory.pressure_level_medium (60) > >- memory.pressure_level_critical (95) > > > >Signed-off-by: Leonid Moiseichuk > > I'm against this even in the abstract, cgroup v1 is deprecated and its > interface frozen, and vmpressure is pretty much already supplanted by PSI, > which actually works (whereas vmpressure often doesn't since it mostly > ends up > just measuring reclaim efficiency, rather than actual memory pressure). > > Without an extremely compelling reason to expose these, this just muddles > the > situation. > -- With Best Wishes, Leonid --000000000000fa1c9905a3482902 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
No problem, since cgroups v1 are frozen that is a valid st= opper.
Let me check what could be done about PSI for swapless cases.

On Tue, Apr 14, 2020 at 6:55 PM Chris Down <chris@chrisdown.name> wrote:
svc_lmoiseichuk@magicleap.com writes:
>From: Leonid Moiseichuk <lmoiseichuk@magicleap.com>
>
>Populating memcg vmpressure controls with legacy defaults:
>- memory.pressure_window (512 or SWAP_CLUSTER_MAX * 16)
>- memory.pressure_level_critical_prio (3)
>- memory.pressure_level_medium (60)
>- memory.pressure_level_critical (95)
>
>Signed-off-by: Leonid Moiseichuk <lmoiseichuk@magicleap.com>

I'm against this even in the abstract, cgroup v1 is deprecated and its =
interface frozen, and vmpressure is pretty much already supplanted by PSI, =
which actually works (whereas vmpressure often doesn't since it mostly = ends up
just measuring reclaim efficiency, rather than actual memory pressure).

Without an extremely compelling reason to expose these, this just muddles t= he
situation.


--
With Best Wishes,
Leonid
--000000000000fa1c9905a3482902--