From: Leonid Moiseichuk <lmoiseichuk@magicleap.com>
To: Chris Down <chris@chrisdown.name>
Cc: hannes@cmpxchg.org, Michal Hocko <mhocko@kernel.org>,
vdavydov.dev@gmail.com, tj@kernel.org, lizefan@huawei.com,
cgroups@vger.kernel.org, akpm@linux-foundation.org,
rientjes@google.com, minchan@kernel.org, vinmenon@codeaurora.org,
andriy.shevchenko@linux.intel.com, penberg@kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 1/2] memcg: expose vmpressure knobs
Date: Tue, 14 Apr 2020 19:00:09 -0400 [thread overview]
Message-ID: <CAELvCDSb=EHiUtcBNnE8F4F7OHxYvXVS0Fje1_O8MBbmVJUjBg@mail.gmail.com> (raw)
In-Reply-To: <20200414225525.GA1892067@chrisdown.name>
[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]
No problem, since cgroups v1 are frozen that is a valid stopper.
Let me check what could be done about PSI for swapless cases.
On Tue, Apr 14, 2020 at 6:55 PM Chris Down <chris@chrisdown.name> wrote:
> svc_lmoiseichuk@magicleap.com writes:
> >From: Leonid Moiseichuk <lmoiseichuk@magicleap.com>
> >
> >Populating memcg vmpressure controls with legacy defaults:
> >- memory.pressure_window (512 or SWAP_CLUSTER_MAX * 16)
> >- memory.pressure_level_critical_prio (3)
> >- memory.pressure_level_medium (60)
> >- memory.pressure_level_critical (95)
> >
> >Signed-off-by: Leonid Moiseichuk <lmoiseichuk@magicleap.com>
>
> I'm against this even in the abstract, cgroup v1 is deprecated and its
> interface frozen, and vmpressure is pretty much already supplanted by PSI,
> which actually works (whereas vmpressure often doesn't since it mostly
> ends up
> just measuring reclaim efficiency, rather than actual memory pressure).
>
> Without an extremely compelling reason to expose these, this just muddles
> the
> situation.
>
--
With Best Wishes,
Leonid
[-- Attachment #2: Type: text/html, Size: 1745 bytes --]
next prev parent reply other threads:[~2020-04-14 23:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 21:57 [PATCH 0/2] memcg, vmpressure: expose vmpressure controls svc_lmoiseichuk
2020-04-13 21:57 ` [PATCH 1/2] memcg: expose vmpressure knobs svc_lmoiseichuk
2020-04-14 22:55 ` Chris Down
2020-04-14 23:00 ` Leonid Moiseichuk [this message]
2020-04-13 21:57 ` [PATCH 2/2] memcg, vmpressure: expose vmpressure controls svc_lmoiseichuk
2020-04-14 11:37 ` [PATCH 0/2] " Michal Hocko
2020-04-14 16:42 ` Leonid Moiseichuk
2020-04-14 18:49 ` Michal Hocko
2020-04-14 20:53 ` Leonid Moiseichuk
2020-04-15 7:51 ` Michal Hocko
2020-04-15 12:17 ` Leonid Moiseichuk
2020-04-15 12:28 ` Michal Hocko
2020-04-15 12:33 ` Leonid Moiseichuk
2020-04-14 19:23 ` Johannes Weiner
2020-04-14 22:12 ` Leonid Moiseichuk
2020-04-15 7:55 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAELvCDSb=EHiUtcBNnE8F4F7OHxYvXVS0Fje1_O8MBbmVJUjBg@mail.gmail.com' \
--to=lmoiseichuk@magicleap.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox