From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0DC6C83F1B for ; Mon, 14 Jul 2025 07:57:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3273D6B008A; Mon, 14 Jul 2025 03:57:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FEE26B008C; Mon, 14 Jul 2025 03:57:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23B906B0092; Mon, 14 Jul 2025 03:57:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 146DB6B008A for ; Mon, 14 Jul 2025 03:57:34 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 83C86590FC for ; Mon, 14 Jul 2025 07:57:33 +0000 (UTC) X-FDA: 83662115586.11.279DC72 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf27.hostedemail.com (Postfix) with ESMTP id C7F1B4000B for ; Mon, 14 Jul 2025 07:57:31 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nCKTRZq9; spf=pass (imf27.hostedemail.com: domain of chris.bazley.wg14@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=chris.bazley.wg14@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752479851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=roSjWg6cHsmiMCH7MqmdlcAQ72VjQ3ISK0vUZNe2l3k=; b=IpsVoyXmonZTXYl2iTEX2VkXfE+Twig9zkdWEgbXEEVqREABWHUNdmSh53UJ4zfQ5hX7Oj 0QJRlr7XVU7TfuGBUd+dAGKDU5elvUwTNYTFyD3GwniHJiHcqiX9tv1o+WTbp4tjj6XPAf WiLFNMpoJEj4Ouu8VBQwnwW1qIIFL9E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752479851; a=rsa-sha256; cv=none; b=Wg2vS+QWxPE3zkb/oAEmbaobOIGgDlVyKQ3yUyS2JPOKAl8aaCp3EKq44/AT9owC4g402h yVHDj2kcVPr09hWwxlVVRsGbz+E+osTue1MxOClQWhvHk2VY7WiCAEd/ea8p9i8ArNnUG+ k0CuT2p7Fa8co4TBme2dxmnXepOiEMc= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nCKTRZq9; spf=pass (imf27.hostedemail.com: domain of chris.bazley.wg14@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=chris.bazley.wg14@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-234b440afa7so38922705ad.0 for ; Mon, 14 Jul 2025 00:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752479850; x=1753084650; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=roSjWg6cHsmiMCH7MqmdlcAQ72VjQ3ISK0vUZNe2l3k=; b=nCKTRZq9VrI02BNk0TjLTZC37SUd/rMOEwJ9wn/BGcpKQl3+Y5zVesJHDZTdviSldm +rKXkS9tEGBY/DAP1yFt3PL9+NMvinz7CwyC4L5zL8Kz25zKSc3VumfUS6rIMJ4ow1jR +/UVY7GfmzIsX65K3qfP2I2437GiV2awePIrwY2ICL4orm+2YUThc196stLjZCeLFxsM qyLCoTPtrZ7kRpxUiB7AZ5ZBX48DiyOhtMsRR3ToYopf/Zfkq3qYFr2eF0Vna+Ba+wGB Iw+hxIkaIaZWVBakgFZoT94huOXc7AUCJpZPDIOm4F+OmNW2r7VM+gSTp0IVZM86lFjv ZzUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752479850; x=1753084650; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=roSjWg6cHsmiMCH7MqmdlcAQ72VjQ3ISK0vUZNe2l3k=; b=Z5BPsCnelaPhaN4IFXr7FjHk6GYYzzEi2RrjIgYbJcPH0Rq0E/3ao6LDM/X8GLP29o RVEkfwP4L2254+gIQ5KMXYdYh+J160g/mrwvXQQzYDMsEdHcrIuIgToEk021ulUenRg/ Zc0MO6kVtoDL2izGnI6a55+tfFtc/fLSOqjOZ83wDo2Zjw3b6bSRL4Cm1o5mPNmc6Fuk RPVfwwjL1Q06Bqd5JmektdoXE9oFF3fdr/DBZQEuHzPUxoynjIQLujFQA8Tzx/kuwJ5j wLcWRk7XYYG7it3+XIOuXYJU4rsgRqR+9RjCOkzksgSG2QCiGKdQ1M/T0le5aWeb1toF IoyQ== X-Forwarded-Encrypted: i=1; AJvYcCVFuAOTRd7+q1on06ekKT/HaFjxOgrOZsb72Bex7ch9i6C2k2nM4adFEy7G7qzkowXH4iP0ATyQWw==@kvack.org X-Gm-Message-State: AOJu0YyYroR3W4/OWfbA/3kxdO0lM0J+saN274V5YLKWRoE+C75prkhd XBX1jzyt6CJLKj44RbMsEQiaZeQ/jOLllBqgQ3tHsU9k4kEMsw1paOmsVkr4cSoqppaWCN9T82i DWjhPF92xjCrX7aDWKS+hx7q3qWew9yY= X-Gm-Gg: ASbGnctCTyFVxEgpgWrOOAmkT2SEbZmJmU6amDQNIktoDV5AqAN4xame0eqCC53c0kC MgSc7gUTXFbH8zElijaW+7WsYMnySU5mklOQ6pFTYipm4DQevzFBiWfdNdrAz0jjdOs9DQfV+vl ARntFM3J1vLFRuGE9gQPFz35i1XaVFopYRFVdSd56ROI+Ve0GVwnpz5Xe4+n38QYth1orvXtUxl tLxIW2lvjBIyEg= X-Google-Smtp-Source: AGHT+IFpr5pAueYHXrM1OZmfYU3/Tgdvg6AkbcDgwTXNPQu6TnItlBsyNVYApKSOI86T+XJ2I5iWvpVjvSs/hjFYFWc= X-Received: by 2002:a17:902:f98f:b0:23c:7b9e:1638 with SMTP id d9443c01a7336-23dede8c409mr132835185ad.35.1752479850537; Mon, 14 Jul 2025 00:57:30 -0700 (PDT) MIME-Version: 1.0 References: <033bf00f1fcf808245ae150346019aa7b997ea11.1751862634.git.alx@kernel.org> In-Reply-To: From: Christopher Bazley Date: Mon, 14 Jul 2025 08:57:17 +0100 X-Gm-Features: Ac12FXyCl2UVr3KuLV2X3zg5b49uXMIerI9JyvxvwFjPX5uWMA4vnuopNVK3Pd8 Message-ID: Subject: Re: [RFC v3 3/7] mm: Use seprintf() instead of less ergonomic APIs To: Linus Torvalds Cc: Alejandro Colomar , linux-mm@kvack.org, linux-hardening@vger.kernel.org, Kees Cook , shadow <~hallyn/shadow@lists.sr.ht>, linux-kernel@vger.kernel.org, Andrew Morton , kasan-dev@googlegroups.com, Dmitry Vyukov , Alexander Potapenko , Marco Elver , Christoph Lameter , David Rientjes , Vlastimil Babka , Roman Gushchin , Harry Yoo , Andrew Clayton , Sven Schnelle , Heiko Carstens , Tvrtko Ursulin , "Huang, Ying" , Lee Schermerhorn , Christophe JAILLET , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Chao Yu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C7F1B4000B X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: ikzw4igx5qs8exidnkog86ytycogff96 X-HE-Tag: 1752479851-545165 X-HE-Meta: U2FsdGVkX1/LkOm2ovkVc0SWFCbIbQZCs+ppO7dDukeVKXYf1OtpUYfW4xi/O3zRfc+YThgoFnkAYcPV7euwWkI/5Ay0/E6PC2duLXKO0IqpewpEmjfjUOGsscUoUR+OGX2I+7DzZiogvyOgfj34pXE2lP8gok6M352u/rrNbWufItvTBjk/Gzq28XJ3PlkcsZe7qyogQQUCdLXLJ4UBijO+ISdO8SnoJssHJv34mX0pMJN8MxziyUkMm2z8FG+mGKfOwESh0AdpfEFCYx91dKBhNZUpRsy123h7W4I4fuSFt7lN/ZrXqX6IwtJ6Q8Aosmux9azHwk/eQ1By5ZaXCZdRaRNTU0vzuB4T7g2JSOW6b+8cROKcXQR+z2d+ehEpk4RS/3ljWGvAvDlmucG/HcJgHcxAA53PHPZQJdgSF3tgR8tTyBLB5jPIZeFOcFpqp+4N27W7rOa+MAw0HScGhXzvnmW4501jIyd3amqrIzkL/vSsmRWUsfBi0WEdJWGx4bwu2PkI90jTWyc0gSqddarz6/co+Mnr6vyXDxW+AWginYUArhl7yZRvs9vgLIIAtv5XZOwvvEEsnh1xrdlO46+SpQ8N9P3eZGK3MhJVPyVD3iIG8qeK7CNq6OeP0HCKFMgZVbQ4ZpkZCbd27yFDR54eCriPeWepJzIzxByc2WJBeZA9s9fGF3gwDjpV05aI4xq0/5JFXY0o8z2+tlhPe0IKjO7+dTIEHhQybDB/EUSlzpMI8YJt9OI8lvQ+c6pyu1Dht8FGQQ+IOvvTJaf3ysQYV5FqX5KsCHzzc44RnkadZ8fEqFQrEu2BLiQgsN3P1lMvR0Rwjfds69dNcNMUBg+6N1LKtLunn0Pur8TwGhIpoES4VQoA8N2n4s0kntDPzgUj14/hqj7iQo1/T+mXUQ5SFqdZhmTrHu4IYF8I7O9XBirIhXxlDORKH2sJeLuIgSKi4DyENEUiAMoMz/d 3j6T8jZL 8nKCtgiam2ay8Hq+LrUlmol74kIMK4abSbhTjYn2xGRDEBPt/pHPhaOpnc9U2bTbjG3eik7KvxiGHJGCIGfGujOZw+CzBAfm1+JE0uxstHxIezUY5OynRBSVQsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jul 12, 2025 at 9:58=E2=80=AFPM Christopher Bazley wrote: > > Hi Linus, > > On Mon, Jul 7, 2025 at 8:17=E2=80=AFPM Linus Torvalds > wrote: > > > > On Sun, 6 Jul 2025 at 22:06, Alejandro Colomar wrote: > > > > > > - p +=3D snprintf(p, ID_STR_LENGTH - (p - name), "%07u", s->siz= e); > > > + p =3D seprintf(p, e, "%07u", s->size); > > > > I am *really* not a fan of introducing yet another random non-standard > > string function. > > > > This 'seprintf' thing really seems to be a completely made-up thing. > > Let's not go there. It just adds more confusion - it may be a simpler > > interface, but it's another cogniitive load thing, and honestly, that > > "beginning and end" interface is not great. > > > > I think we'd be better off with real "character buffer" interfaces, > > and they should be *named* that way, not be yet another "random > > character added to the printf family". > > I was really interested to see this comment because I presented a > design for a standard character buffer interface, "strb_t", to WG14 in > summer of 2014. Ugh, that should have been 2024. I'm getting old! Chris