From: Kuo-Hsin Yang <vovoy@chromium.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Hansen <dave.hansen@intel.com>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v6] mm, drm/i915: mark pinned shmemfs pages as unevictable
Date: Tue, 6 Nov 2018 19:49:46 +0800 [thread overview]
Message-ID: <CAEHM+4rEibRffjO0dDncqRpc++8cAOpk-E0PNMW-4E-cMjkNnQ@mail.gmail.com> (raw)
In-Reply-To: <154150241813.6179.68008798371252810@skylake-alporthouse-com>
On Tue, Nov 6, 2018 at 7:07 PM Chris Wilson <chris@chris-wilson.co.uk> wrote:
> This gave disappointing syslatency results until I put a cond_resched()
> here and moved the one in put_pages_gtt to before the page alloc, see
> https://patchwork.freedesktop.org/patch/260332/
>
> The last really nasty wart for syslatency is the spin in
> i915_gem_shrinker, for which I'm investigating
> https://patchwork.freedesktop.org/patch/260365/
>
> All 3 patches together give very reasonable syslatency results! (So
> good that it's time to find a new worst case scenario!)
>
> The challenge for the patch as it stands, is who lands it? We can take
> it through drm-intel (for merging in 4.21) but need Andrew's ack on top
> of all to agree with that path. Or we split the patch and only land the
> i915 portion once we backmerge the mm tree. I think pushing the i915
> portion through the mm tree is going to cause the most conflicts, so
> would recommend against that.
Splitting the patch and landing the mm part first sounds reasonable to me.
next prev parent reply other threads:[~2018-11-06 11:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 9:30 Kuo-Hsin Yang
2018-11-06 10:54 ` Daniel Vetter
2018-11-06 15:19 ` Kuo-Hsin Yang
2018-11-06 11:06 ` Chris Wilson
2018-11-06 11:49 ` Kuo-Hsin Yang [this message]
2018-11-06 12:14 ` Michal Hocko
2018-11-06 13:23 ` [PATCH v7] " Chris Wilson
2018-11-06 14:14 ` Kuo-Hsin Yang
2018-11-06 17:32 ` Dave Hansen
2018-11-06 18:12 ` Andrew Morton
2018-11-07 15:34 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEHM+4rEibRffjO0dDncqRpc++8cAOpk-E0PNMW-4E-cMjkNnQ@mail.gmail.com \
--to=vovoy@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=dave.hansen@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox