From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by kanga.kvack.org (Postfix) with ESMTP id F06738E0001 for ; Tue, 18 Dec 2018 08:34:35 -0500 (EST) Received: by mail-ot1-f69.google.com with SMTP id t13so9504059otk.4 for ; Tue, 18 Dec 2018 05:34:35 -0800 (PST) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id s126sor1419683oig.2.2018.12.18.05.34.34 for (Google Transport Security); Tue, 18 Dec 2018 05:34:34 -0800 (PST) MIME-Version: 1.0 References: <1545104531-30658-1-git-send-email-gchen.guomin@gmail.com> <20181218124710.GU10600@bombadil.infradead.org> In-Reply-To: <20181218124710.GU10600@bombadil.infradead.org> From: gchen chen Date: Tue, 18 Dec 2018 21:34:23 +0800 Message-ID: Subject: Re: [PATCH] Export mm_update_next_owner function for unuse_mm. Content-Type: multipart/alternative; boundary="00000000000048682a057d4bf5ba" Sender: owner-linux-mm@kvack.org List-ID: To: Matthew Wilcox Cc: "Michael S. Tsirkin" , Jason Wang , Christoph Hellwig , Andrew Morton , "Luis R. Rodriguez" , gchen , "Eric W. Biederman" , Dominik Brodowski , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-mm@kvack.org --00000000000048682a057d4bf5ba Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, I don't need to EXPORT this symbol again. i have modified this patch and re-committed it. The email link is : https://lkml.org/lkml/2018/12/18/8 this patch you see is old. thanks and regards Matthew Wilcox =E4=BA=8E2018=E5=B9=B412=E6=9C=8818=E6= =97=A5=E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D=888:47=E5=86=99=E9=81=93=EF=BC=9A > On Tue, Dec 18, 2018 at 11:42:11AM +0800, gchen.guomin@gmail.com wrote: > > +EXPORT_SYMBOL(mm_update_next_owner); > > Unless you've figured out how to build mmu_context.c as a module, you > don't need to EXPORT the symbol. Just the below hunk is enough. > > > diff --git a/mm/mmu_context.c b/mm/mmu_context.c > > index 3e612ae..9eb81aa 100644 > > --- a/mm/mmu_context.c > > +++ b/mm/mmu_context.c > > @@ -60,5 +60,6 @@ void unuse_mm(struct mm_struct *mm) > > /* active_mm is still 'mm' */ > > enter_lazy_tlb(mm, tsk); > > task_unlock(tsk); > > + mm_update_next_owner(mm); > > } > > EXPORT_SYMBOL_GPL(unuse_mm); > > -- > > 1.8.3.1 > > > --00000000000048682a057d4bf5ba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, I don't ne= ed to EXPORT this symbol again.=C2=A0
i have modified this patch = and re-committed it.=C2=A0 The email link is :https://lkml.org/lkml/2018/12/18/8
this pat= ch you see is old.=C2=A0

thanks and regards

Matthew Wilcox= <willy@infrade= ad.org> =E4=BA=8E2018=E5=B9=B412=E6=9C=8818=E6=97=A5=E5=91=A8=E4=BA= =8C =E4=B8=8B=E5=8D=888:47=E5=86=99=E9=81=93=EF=BC=9A
On Tue, Dec 18, 2018 at 11:42:11AM +0= 800, gchen.guom= in@gmail.com wrote:
> +EXPORT_SYMBOL(mm_update_next_owner);

Unless you've figured out how to build mmu_context.c as a module, you don't need to EXPORT the symbol.=C2=A0 Just the below hunk is enough.
> diff --git a/mm/mmu_context.c b/mm/mmu_context.c
> index 3e612ae..9eb81aa 100644
> --- a/mm/mmu_context.c
> +++ b/mm/mmu_context.c
> @@ -60,5 +60,6 @@ void unuse_mm(struct mm_struct *mm)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0/* active_mm is still 'mm' */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0enter_lazy_tlb(mm, tsk);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0task_unlock(tsk);
> +=C2=A0 =C2=A0 =C2=A0mm_update_next_owner(mm);
>=C2=A0 }
>=C2=A0 EXPORT_SYMBOL_GPL(unuse_mm);
> --
> 1.8.3.1
>
--00000000000048682a057d4bf5ba--