From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62FFEC46CD3 for ; Wed, 20 Dec 2023 02:59:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8507F6B0072; Tue, 19 Dec 2023 21:59:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DA5A6B0075; Tue, 19 Dec 2023 21:59:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67AED6B007B; Tue, 19 Dec 2023 21:59:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 515C86B0072 for ; Tue, 19 Dec 2023 21:59:37 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1428A1C0BDA for ; Wed, 20 Dec 2023 02:59:37 +0000 (UTC) X-FDA: 81585691194.25.EA5F6D7 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by imf07.hostedemail.com (Postfix) with ESMTP id CD4CD40023 for ; Wed, 20 Dec 2023 02:59:34 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=at1i6LHJ; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf07.hostedemail.com: domain of cuiyunhui@bytedance.com designates 209.85.160.45 as permitted sender) smtp.mailfrom=cuiyunhui@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703041175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=apsQTMh+wzleRxg4vNWLqcpSsKcn0wPXDH5u/impo2s=; b=bhn6w76xmvIxjzRpE8JFHjar197zrBL/WvYTn90RjKzt+u93yPfBxBrOcDKtEAB+n6xiaO I1rkvbUNaGcJ3NRcz6koDIxUfpEl8NMCDIVwoKhHYgFDQcZP2bce43GNRd7RoTb+Qrt5DC r4zTDFO8+qeWQSB5JUBDdT7fsc30BSI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=at1i6LHJ; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf07.hostedemail.com: domain of cuiyunhui@bytedance.com designates 209.85.160.45 as permitted sender) smtp.mailfrom=cuiyunhui@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703041175; a=rsa-sha256; cv=none; b=bEfhwVeOsUK3kWRhzsfzv9h0K0knoErWIH9mQBLo2OKPndGUVYWCx5d0sQtdlyPO7L6MU6 6SyFcDEMaTfwzAHbVywh8IpSe3tDxJYkEGgH8RS6VEY9FtcKFpPq6YZK5shevwrLK0HKp1 EX2vK+jXIewx0W038TL/K/ihEh+SBuw= Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1fb9a22b4a7so3084141fac.3 for ; Tue, 19 Dec 2023 18:59:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1703041174; x=1703645974; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=apsQTMh+wzleRxg4vNWLqcpSsKcn0wPXDH5u/impo2s=; b=at1i6LHJHz4Aky1MtubaohLlGLtSaonSa0IAha6sdpdjGL+gAnETeDrnD2xJmuP7PF qzEu+qVya4WD/Z02IG5WHDqYb99/oocuxff0gDxSfvxAro59rZyX3iRvEZLoJ8C8/KTs nGQcLbgwf6gRnFp5gYij1hwG/q4mV//xNNd3onOYQYLiIv8kQcO1VZoxQBoSCG9knrDR B3+VuAmj9gUgGKESl9Y0I1Mqe6RfBMyWkacdHhFURjrrqZQ4ED+nJ5bdyCn+RHEk6eI5 xBtBXuMQbQcl7s7OjPDpjeBiciKcroZG/bfmMX35rRvkRAmiZc0SMS7bSJ/gNR1wYKCA gAcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703041174; x=1703645974; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=apsQTMh+wzleRxg4vNWLqcpSsKcn0wPXDH5u/impo2s=; b=GghAvyE8JSqX6ZGYACjZHhx/IUn1M5HRq2705NBkCoqqzYsT78TNzdGAHa8A7VeqRe STPoHcHA5fQBJzr+keW1QdMOKJHvCwBndcRvUpC7LuypS8GCRbYSrfItZ7IKGp6Il8/f GiIvlYDgEaHn3F0TbXV1elf3CUepxi+EDblns02o3vUiFJL2zFH+h2TPgxpdpdkt9/SC QP0Hk6VfcHsTOolqtQHYJfNuIoPfyjmjkZUhdz6Ya3P6MFS2VhsMNDEFjZK6yCHADGaq vNsaRCrEdYrukhDI3+cfvQwAj8yyL58+yZkctAvwjlw0pTir5J1OYPMlIS9LkzEbZ1sK HDpA== X-Gm-Message-State: AOJu0YznA1OTLtLN+pwmEYdC3nMhyjrr2SQCCZan5CB1KDsflLBWsD96 Ho9wsUKpta3bP7GH1wMyl3zEQRYwzA7lwF0SbJT2ww== X-Google-Smtp-Source: AGHT+IHkJO5ZOUzVzVAm0OW2c+XOHReGlsuOrQcjDbsf2O8ij6x/MrBLjV3275c/hmg9Ct7seUt4KRT1EBT+KWFvojQ= X-Received: by 2002:a05:6870:3929:b0:204:20b:2de with SMTP id b41-20020a056870392900b00204020b02demr1067684oap.35.1703041173827; Tue, 19 Dec 2023 18:59:33 -0800 (PST) MIME-Version: 1.0 References: <20231219175046.2496-1-jszhang@kernel.org> <20231219175046.2496-3-jszhang@kernel.org> In-Reply-To: <20231219175046.2496-3-jszhang@kernel.org> From: yunhui cui Date: Wed, 20 Dec 2023 10:59:22 +0800 Message-ID: Subject: Re: [External] [PATCH 2/4] riscv: tlb: convert __p*d_free_tlb() to inline functions To: Jisheng Zhang Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 47hknoih7dkhz5ke7zywj71tacdze7cx X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CD4CD40023 X-HE-Tag: 1703041174-287196 X-HE-Meta: U2FsdGVkX1+99WBokQwX4pnT9lwybWq9n9yp+1hz2MDVwxfzQ1O+MPMXuOWZz65NO0lGJIAzy8mQqs88kqwjQpVUzCLz+EZ4hRUrB48qU2EXUP2PtFSDP/Wt1ueyxTMvYz9+lKjRK4gIWD3tWpAN/iKTOeOAGqxOtboTpPUCGP1DZqscQ9ECxyzvrvhzmKRbYLq+IR+gc5w7zeBb/VLXBAGtcwIMkUm9MXt5HT5y4wF3WGDkQmS9m5P9iXfDUs17yEHp19/CSQdlGVG3ewXYqD2Az+plYfhLm5b4x6eNrpf5QZEN8JesweEccl0017l+OxpEfAY8atzR7xRVxip1HyaJo3xNZ7bTSm5TDVeT7heYg0FzZ1FBraW8b0DhdPq6HUxxYmjlDbgqFmgRbu2vT8urgyRYV+uWhrOff981Vv1EJoBaCF4aYoBrPmElS9pKAzgb871rFuTAgHwI/aF9QMm8uyTXBaAbIVtMYPmYD1Y77u7AgKsT/UFSYNZdiFu2ODKElM8HsQ/7GCRaKIuGHPMiwaMyfskKw+Lnroz7RFy5nAqiZ9E2c7otpZfRbAu7Q8K3p//doHIaOaa0iWAh9SghUVXp0yi5RZOcc8gnflqiltjvZ1b9T0hUNbT6Cen6uCEFCFY/isHMHtYeKiZmLtZi1LlykZGDwx/ynfWavVNyccVhCGET3WSRSb9ddKitjWzul208Ix/r95StCFR57v/55+CWs/kgIQDg0+XUUp7SJzIVed8k42FoOHayTdq5CZXHmrp52+ITVT0xOnoV+GiHpXMly4IZ9gZOVOg+WmoVhJlBQc57r2FgcTtiirKmA08+lOuCFuNQ3USkDC+DrE5k1oOR3WkTtz9e5LPnPdvfFiml33c7UsG9oT3b8L9R13PJfP8gM9Mpr7iDANE0yazNSaM4bPPq23q2Nx9J7BZ4Bn+/LkhxLvQg+jUs6/Rr4iwpOAp3EF8pAitJbst RrLs1cyq AupkaZd8FXJxAW4KmN6A2LKEZXwkD0lF3YFWJyMdzlnLxE5+OcVkXsuP2anFQxX66m9xPVLqjOAd4QnBs6UNIw53rADl+4BB2EfXPgHUBE/9ickrRG9I8n07OzoHEs89WTmu72d7ZkgjT3a86lrB/r/wqf8w0ddhj1PMuMjNk3ssyCyQqs0CWailFaMW+XViA7p8pO0mGezMR6yKkygobH3/o54iVi30rxM4Qb8LmGleuirOJ6NZK13qm7+oBuqP0Jasszs93EPLvFxGfErrymxOV4sNUbexNXMGyEqD63boEUgUlMvDoMsjXZWGwzPhjxDcTF0NcMBzjSjJz2Xt3zu2tIRSWUk9z5n2M X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Jisheng, On Wed, Dec 20, 2023 at 2:04=E2=80=AFAM Jisheng Zhang = wrote: > > This is to prepare for enabling MMU_GATHER_RCU_TABLE_FREE. > No functionality changes. > > Signed-off-by: Jisheng Zhang > --- > arch/riscv/include/asm/pgalloc.h | 54 +++++++++++++++++++------------- > 1 file changed, 32 insertions(+), 22 deletions(-) > > diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pg= alloc.h > index a12fb83fa1f5..3c5e3bd15f46 100644 > --- a/arch/riscv/include/asm/pgalloc.h > +++ b/arch/riscv/include/asm/pgalloc.h > @@ -95,13 +95,16 @@ static inline void pud_free(struct mm_struct *mm, pud= _t *pud) > __pud_free(mm, pud); > } > > -#define __pud_free_tlb(tlb, pud, addr) \ > -do { \ > - if (pgtable_l4_enabled) { \ > - pagetable_pud_dtor(virt_to_ptdesc(pud)); \ > - tlb_remove_page_ptdesc((tlb), virt_to_ptdesc(pud)); \ > - } \ > -} while (0) > +static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud, > + unsigned long addr) > +{ > + if (pgtable_l4_enabled) { > + struct ptdesc *ptdesc =3D virt_to_ptdesc(pud); > + > + pagetable_pud_dtor(ptdesc); > + tlb_remove_page_ptdesc(tlb, ptdesc); > + } > +} > > #define p4d_alloc_one p4d_alloc_one > static inline p4d_t *p4d_alloc_one(struct mm_struct *mm, unsigned long a= ddr) > @@ -130,11 +133,12 @@ static inline void p4d_free(struct mm_struct *mm, p= 4d_t *p4d) > __p4d_free(mm, p4d); > } > > -#define __p4d_free_tlb(tlb, p4d, addr) \ > -do { \ > - if (pgtable_l5_enabled) \ > - tlb_remove_page_ptdesc((tlb), virt_to_ptdesc(p4d)); \ > -} while (0) > +static inline void __p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d, > + unsigned long addr) > +{ > + if (pgtable_l5_enabled) > + tlb_remove_page_ptdesc(tlb, virt_to_ptdesc(p4d)); > +} > #endif /* __PAGETABLE_PMD_FOLDED */ > > static inline void sync_kernel_mappings(pgd_t *pgd) > @@ -159,19 +163,25 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm= ) > > #ifndef __PAGETABLE_PMD_FOLDED > > -#define __pmd_free_tlb(tlb, pmd, addr) \ > -do { \ > - pagetable_pmd_dtor(virt_to_ptdesc(pmd)); \ > - tlb_remove_page_ptdesc((tlb), virt_to_ptdesc(pmd)); \ > -} while (0) > +static inline void __pmd_free_tlb(struct mmu_gather *tlb, pmd_t *pmd, > + unsigned long addr) > +{ > + struct ptdesc *ptdesc =3D virt_to_ptdesc(pmd); > + > + pagetable_pmd_dtor(ptdesc); > + tlb_remove_page_ptdesc(tlb, ptdesc); > +} > > #endif /* __PAGETABLE_PMD_FOLDED */ > > -#define __pte_free_tlb(tlb, pte, buf) \ > -do { \ > - pagetable_pte_dtor(page_ptdesc(pte)); \ > - tlb_remove_page_ptdesc((tlb), page_ptdesc(pte));\ > -} while (0) > +static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, > + unsigned long addr) > +{ > + struct ptdesc *ptdesc =3D page_ptdesc(pte); > + > + pagetable_pte_dtor(ptdesc); > + tlb_remove_page_ptdesc(tlb, ptdesc); > +} > #endif /* CONFIG_MMU */ > > #endif /* _ASM_RISCV_PGALLOC_H */ > -- > 2.40.0 > Why is it necessary to convert to inline functions? Thanks, Yunhui