From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0732FC47258 for ; Mon, 29 Jan 2024 03:07:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 712CC6B0082; Sun, 28 Jan 2024 22:07:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C2B86B0083; Sun, 28 Jan 2024 22:07:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58A116B0085; Sun, 28 Jan 2024 22:07:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 49A156B0082 for ; Sun, 28 Jan 2024 22:07:11 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0FB42A091F for ; Mon, 29 Jan 2024 03:07:11 +0000 (UTC) X-FDA: 81730862262.14.8A68D35 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by imf21.hostedemail.com (Postfix) with ESMTP id 8343A1C0015 for ; Mon, 29 Jan 2024 03:07:08 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Mi0YoUmS; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf21.hostedemail.com: domain of cuiyunhui@bytedance.com designates 209.85.210.43 as permitted sender) smtp.mailfrom=cuiyunhui@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706497629; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5VmEsB3BrVhcksANfHb/8QboZcv6m1DkmrrBxCJMlos=; b=l7noAWmkaQUQt/MyZgE01U0ycbk+Mv2dx0WBuWVquVMPZmsc/eqd4V2dFirWBO1Z7NbW3r xncwalH6X18v0RYtIGlgzrr1+AF8QqP5OT6aB0lr4W527tHfbO8IXJr6E4+dLhbsS9nomw mAs/o9AcjVV/5oOlpX429WuEA5PpVDM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Mi0YoUmS; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf21.hostedemail.com: domain of cuiyunhui@bytedance.com designates 209.85.210.43 as permitted sender) smtp.mailfrom=cuiyunhui@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706497629; a=rsa-sha256; cv=none; b=fKdUcDmnKEQvaKAFqMDCqy2sh0AgkWMTzz8Q4M0byjuSqkhRbb8gun50bLSBQZqUCe9FOc HBl70GL0UfeLN7canASzKczg5YgCj3mAnHKrQU29BiWtvo4Y9WbjUbNS4a34GO4phDKzar fkeCKgEh3TC4jO6N+NC/iOOaMNEI/z0= Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-6dc8b280155so1320793a34.0 for ; Sun, 28 Jan 2024 19:07:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1706497627; x=1707102427; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5VmEsB3BrVhcksANfHb/8QboZcv6m1DkmrrBxCJMlos=; b=Mi0YoUmSwoWQlFBxt33+1C8QYtDCzfPughaxo6LDfWSikixxyfLXaqpJO4zO2dbdHz rN2pm2oEPgR9uOO5k4QiVOXzRO/wV4jlRvl8L22nkKSwKuI25yC7og1oXHTFY7QIfjXx qv5aSugGfE8mcoquphhCMEITWqbw+MGS5HN1VIZn1xsXn21r/KWVhe9Z0hKTBYHmQvcY uve6amyy95ZBkt/LS0aVNkYiL8gXDHyyd2QsxRxVV2ynraX1dQi6fHac4kMYjwH57uWz TQq7bMCAxXq7vbTzQI1CAh/ZokFeAAtFrJ9zVF2KG8r/94OkSecxz4u0ctmQfNDSDga+ IVrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706497627; x=1707102427; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5VmEsB3BrVhcksANfHb/8QboZcv6m1DkmrrBxCJMlos=; b=bvXrD99aF/UfNRqVa3/1nk+kSiNMVaUCvpTUUxr02p7FDamDoXkPyMagnEyWwrT8uZ UfnCjYR/nA+cXoXmoQRCsbTxz6a2sP10WY24ZfyDEd/pWi1LX2xeOCihYcaFDs5ZNbfR WkfkleZlg6WXenH5fHAXwWgn/jHby0oZha6YdNEq8HTyvW2upiekXRZ6mEUWzf6DW9oG 0P6s2o/tRIicnP5x+UNumOehZA7FDYiQr/Ie/e3FswzLfPdMprhZXhUazn015GgenWdL 70jkHz9TgQcYRc+3pXiNDYzxfDGxZu218BnuQAfFffntLzejDJqZV0Fg8GmcEO8yS+lo yOOQ== X-Gm-Message-State: AOJu0YxyDW3+utgf3C8XUD5ZTbcjbW0qpx3haQXRyW07w+WGZvYaETS7 5fcebzzPLzu9LEbNdR4FWYlzPifpf1NgN4fh0P3Ig/UDa9zW5EdkB6Jh3mL+eRPGrsHIPHtrgz2 jAkF4LBcftJCt5M4egC51EvQ5F84XVFGlyhxL4w== X-Google-Smtp-Source: AGHT+IEWlpSCuURK2908qpVhjPZ38PveXtCpdAx9PaagZ0ywJkZb7DWA1aHVXgttgRYK55tCSUygd093guftonqGw1g= X-Received: by 2002:a05:6870:b401:b0:214:fc3f:3471 with SMTP id x1-20020a056870b40100b00214fc3f3471mr1192447oap.40.1706497627335; Sun, 28 Jan 2024 19:07:07 -0800 (PST) MIME-Version: 1.0 References: <20240128120405.25876-1-alexghiti@rivosinc.com> In-Reply-To: <20240128120405.25876-1-alexghiti@rivosinc.com> From: yunhui cui Date: Mon, 29 Jan 2024 11:06:56 +0800 Message-ID: Subject: Re: [External] [PATCH -fixes] riscv: Flush the tlb when a page directory is freed To: Alexandre Ghiti Cc: Will Deacon , "Aneesh Kumar K . V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , Andrew Jones , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8343A1C0015 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: zydy4m656zqoga7hrtnr5xarkizw5ox3 X-HE-Tag: 1706497628-341912 X-HE-Meta: U2FsdGVkX1/l/Jb2fGG5CCjmNDxpw2bGS17iN7bLxHLtIInY9qm4UvhGoXWXG8Y89sBfTSVvik1+Wl2Vyh3QIKmS4++3ov7hHZXfaCWeACdz9XnvWc9BtyVXgqxgbQakD/hYz7kbaPs9HJXYVgrIU+sfHM1cmBiV+UtML+g4oaVHZiP7/JPHWWRTVlmtOGbbOQYv9TUgZH1aMv3yrvYFyAeQ2uSYXHzMXA1ag4cIy2lEiz1U3R1AuZrHghs2JP3ogImIapBvTy+sB/J4W9P244XXkEclTfJusvx8VoVt8FCv7DXEVt+JC5awJkNG9OPedW8f6WdCgqZdjo89Rf8lMF2AJEccDsArTls6xuQobyQYUShgM3nbFFp6+NAYn6ISDgJ8EodDLPE11j/SJXLnanZOqgnKSxlLt2la9fQ+N60Zy0TZ7aPrkjUHgASBRY+GWY3Casuxygj1mxR38y/h7KVZpWjs5BAA5vGtU6KB/5h2boGa929Obom+wqL7KfIr6FMz+yCOEyxZvAPoThzHs5sZv9NSumjE1HlaPe7n2tPhoGNhmrPamWdV4iuaLRdC/+a8vw4mVmJyL/n0K/gxkBQfUZlFTcEx36atBYSrPyEHYOQXEWZ7xRqXE+75Br9BHLvfESc+FYfZ6wfSNm9ESArJ1FZ2JBgvFWvpCEjwsDjC2s/hDg2lyWGEfL9869lpmyQOMXyEnM3794OMQlg7+KM7h9cMqJLuwHv9Of8zwFOBI271Fp/JUIeYXwrvASiQSy15zMpFFcFpca8oAHmRFcUb1dW2bPIf8aPK41KCARb1uBS8nmGRVqUXEcN+TA1VU9+XgI4vJkcXMx79vROPLpELWho2MQu1akOrKwsRu/6gHFRyLsczj4EsyKj959unvt3Z8VREFQKLMTa3mttn3EKaTDaEqLq7YFOyWyzdTr/v2HtABTkdzpJtVv50XUbcsD8KiEK2ta4OH0DqrzB 7vFNrwNA lBPRQl6axL1k6IUmUIacyrv5O0yAdMdvnTgMJp1c3cg89yaAYiMJK3lFlKb1sZ1ykElEmr7HcgAjtL9T15I5gtvr1Vjea7U+Vn/vfTVOZ7R2Nl8OrQ50Q3khEBrEUDBg28N+3AIMxPdQk8t19R9rEYK2nr7IXuzadwB8enRSEYr6G8u/TQR+jX9EZij8apjxxt9tioGBJCj5xl/zbnBYH/Msy2y+wgRgIeQzc6ySOE9VuI+XT28b0RMA17Lg7FsIIXimXLqJjiT6xCyomgvpRTE85af5t60gnxBXn7d1AIaoutAs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Alexandre, On Sun, Jan 28, 2024 at 8:04=E2=80=AFPM Alexandre Ghiti wrote: > > The riscv privileged specification mandates to flush the TLB whenever a > page directory is modified, so add that to tlb_flush(). > > Fixes: c5e9b2c2ae82 ("riscv: Improve tlb_flush()") > Signed-off-by: Alexandre Ghiti > --- > arch/riscv/include/asm/tlb.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/include/asm/tlb.h b/arch/riscv/include/asm/tlb.h > index 1eb5682b2af6..50b63b5c15bd 100644 > --- a/arch/riscv/include/asm/tlb.h > +++ b/arch/riscv/include/asm/tlb.h > @@ -16,7 +16,7 @@ static void tlb_flush(struct mmu_gather *tlb); > static inline void tlb_flush(struct mmu_gather *tlb) > { > #ifdef CONFIG_MMU > - if (tlb->fullmm || tlb->need_flush_all) > + if (tlb->fullmm || tlb->need_flush_all || tlb->freed_tables) > flush_tlb_mm(tlb->mm); Why is it necessary to flush all TLB entries of the process? Thanks, Yunhui