From: Yinghai Lu <yinghai@kernel.org>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Johannes Weiner <hannes@cmpxchg.org>,
Jiang Liu <liuj97@gmail.com>
Subject: Re: [PATCH 2/3] mm, nobootmem: clean-up of free_low_memory_core_early()
Date: Mon, 18 Mar 2013 22:51:43 -0700 [thread overview]
Message-ID: <CAE9FiQXypPJbhT4mm-wfbO0G65eNSTRCE0DJoB+bXtNfvg7HbQ@mail.gmail.com> (raw)
In-Reply-To: <1363670161-9214-2-git-send-email-iamjoonsoo.kim@lge.com>
On Mon, Mar 18, 2013 at 10:16 PM, Joonsoo Kim <iamjoonsoo.kim@lge.com> wrote:
> Remove unused argument and make function static,
> because there is no user outside of nobootmem.c
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
> diff --git a/include/linux/bootmem.h b/include/linux/bootmem.h
> index cdc3bab..5f0b0e1 100644
> --- a/include/linux/bootmem.h
> +++ b/include/linux/bootmem.h
> @@ -44,7 +44,6 @@ extern unsigned long init_bootmem_node(pg_data_t *pgdat,
> unsigned long endpfn);
> extern unsigned long init_bootmem(unsigned long addr, unsigned long memend);
>
> -extern unsigned long free_low_memory_core_early(int nodeid);
> extern unsigned long free_all_bootmem_node(pg_data_t *pgdat);
> extern unsigned long free_all_bootmem(void);
>
> diff --git a/mm/nobootmem.c b/mm/nobootmem.c
> index 4711e91..589c673 100644
> --- a/mm/nobootmem.c
> +++ b/mm/nobootmem.c
> @@ -120,7 +120,7 @@ static unsigned long __init __free_memory_core(phys_addr_t start,
> return end_pfn - start_pfn;
> }
>
> -unsigned long __init free_low_memory_core_early(int nodeid)
> +static unsigned long __init free_low_memory_core_early()
(void) ?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-03-19 5:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 5:15 [PATCH 1/3] mm, nobootmem: fix wrong usage of max_low_pfn Joonsoo Kim
2013-03-19 5:16 ` [PATCH 2/3] mm, nobootmem: clean-up of free_low_memory_core_early() Joonsoo Kim
2013-03-19 5:50 ` Joonsoo Kim
2013-03-19 5:51 ` Yinghai Lu [this message]
2013-03-19 5:58 ` Joonsoo Kim
2013-03-19 5:16 ` [PATCH 3/3] mm, nobootmem: do memset() after memblock_reserve() Joonsoo Kim
2013-03-19 5:53 ` Yinghai Lu
2013-03-19 5:58 ` Joonsoo Kim
2013-03-19 5:47 ` [PATCH 1/3] mm, nobootmem: fix wrong usage of max_low_pfn Yinghai Lu
2013-03-19 6:25 ` Joonsoo Kim
2013-03-19 6:42 ` Joonsoo Kim
2013-03-19 7:35 ` Yinghai Lu
2013-03-19 8:07 ` Joonsoo Kim
2013-03-20 20:18 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE9FiQXypPJbhT4mm-wfbO0G65eNSTRCE0DJoB+bXtNfvg7HbQ@mail.gmail.com \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuj97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox