From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx150.postini.com [74.125.245.150]) by kanga.kvack.org (Postfix) with SMTP id 8820F6B0088 for ; Tue, 26 Mar 2013 13:56:59 -0400 (EDT) Received: by mail-ie0-f182.google.com with SMTP id at1so5263029iec.41 for ; Tue, 26 Mar 2013 10:56:58 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1364319962-30967-3-git-send-email-cody@linux.vnet.ibm.com> References: <1364319962-30967-1-git-send-email-cody@linux.vnet.ibm.com> <1364319962-30967-3-git-send-email-cody@linux.vnet.ibm.com> Date: Tue, 26 Mar 2013 10:56:58 -0700 Message-ID: Subject: Re: [PATCH 2/3] x86/mm/numa: use setup_nr_node_ids() instead of opencoding. From: Yinghai Lu Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Cody P Schafer Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Paul Mackerras , Benjamin Herrenschmidt On Tue, Mar 26, 2013 at 10:46 AM, Cody P Schafer wrote: > Signed-off-by: Cody P Schafer > --- > arch/x86/mm/numa.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c > index 72fe01e..a71c4e2 100644 > --- a/arch/x86/mm/numa.c > +++ b/arch/x86/mm/numa.c > @@ -114,14 +114,11 @@ void numa_clear_node(int cpu) > */ > void __init setup_node_to_cpumask_map(void) > { > - unsigned int node, num = 0; > + unsigned int node; > > /* setup nr_node_ids if not done yet */ > - if (nr_node_ids == MAX_NUMNODES) { > - for_each_node_mask(node, node_possible_map) > - num = node; > - nr_node_ids = num + 1; > - } > + if (nr_node_ids == MAX_NUMNODES) > + setup_nr_node_ids(); For 1 and 2, Acked-by: Yinghai Lu -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org