From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bk0-f42.google.com (mail-bk0-f42.google.com [209.85.214.42]) by kanga.kvack.org (Postfix) with ESMTP id 696046B0037 for ; Fri, 24 Jan 2014 13:51:43 -0500 (EST) Received: by mail-bk0-f42.google.com with SMTP id 6so1384410bkj.15 for ; Fri, 24 Jan 2014 10:51:42 -0800 (PST) Received: from mail-ig0-x234.google.com (mail-ig0-x234.google.com [2607:f8b0:4001:c05::234]) by mx.google.com with ESMTPS id q2si4045106bkr.171.2014.01.24.10.51.42 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 24 Jan 2014 10:51:42 -0800 (PST) Received: by mail-ig0-f180.google.com with SMTP id m12so3349270iga.1 for ; Fri, 24 Jan 2014 10:51:41 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <52E2B431.5090705@intel.com> References: <52E19C7D.7050603@intel.com> <52E28067.1060507@intel.com> <52E2AC5A.3000005@intel.com> <52E2AEA3.2020907@intel.com> <52E2B431.5090705@intel.com> Date: Fri, 24 Jan 2014 10:51:40 -0800 Message-ID: Subject: Re: Panic on 8-node system in memblock_virt_alloc_try_nid() From: Yinghai Lu Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen Cc: "H. Peter Anvin" , Ingo Molnar , Grygorii Strashko , Linux-MM , LKML , Santosh Shilimkar , Tejun Heo , Andrew Morton On Fri, Jan 24, 2014 at 10:42 AM, Dave Hansen wrote: > On 01/24/2014 10:24 AM, Yinghai Lu wrote: >> On Fri, Jan 24, 2014 at 10:19 AM, Dave Hansen wrote: >>> FWIW, I did turn of memblock=debug. It eventually booted, but >>> slooooooooooowly. >> >> then that is not a problem, as you are using 4k page mapping only. >> and that printout is too spew... > > This means that, essentially, memblock=debug and > KMEMCHECK/DEBUG_PAGEALLOC can't be used together. That's a shame > because my DEBUG_PAGEALLOC config *broke* this code a few months ago, > right? Oh well. should only be broken when MOVABLE_NODE is enabled on big system. > >>> How many problems in this code are we tracking, btw? This is at least >>> 3, right? >> >> two problems: >> 1. big numa system. >> 2. Andrew's system with swiotlb. > > Can I ask politely for some more caution on your part in this area? > This is two consecutive kernels where this code has broken my system. I agree, the code get messy as now we have top_down and bottom up mapping for different configuration. I already tried hard to make parsing srat early solution instead that split. Yinghai -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org