linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: lai bin <sclaibin@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
	 vincent.guittot@linaro.org, akpm@linux-foundation.org,
	 dietmar.eggemann@arm.com, rostedt@goodmis.org,
	bsegall@google.com,  mgorman@suse.de, bristot@redhat.com,
	vschneid@redhat.com,  linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org,  linux-mm@kvack.org,
	Bin Lai <robinlai@tencent.com>
Subject: Re: [PATCH] sched/wait: introduce endmark in __wake_up_common
Date: Tue, 10 Oct 2023 15:04:04 +0800	[thread overview]
Message-ID: <CAE82Ze2HSJcTp4aNzMne877L+kyCwG3WXTLMdSwJ+HqsfbnHSw@mail.gmail.com> (raw)
In-Reply-To: <ZSTLxuiJssT9aYb0@casper.infradead.org>

Yes,  you are right. Now that bookmarks weren't actually useful any
more, removing  bookmarks  is a better way to address the livelocks.

Matthew Wilcox <willy@infradead.org> 于2023年10月10日周二 11:58写道：
>
> On Tue, Oct 10, 2023 at 11:28:33AM +0800, Bin Lai wrote:
> > Without this patch applied, it can cause the waker to fall into an
> > infinite loop in some cases. The commit 2554db916586 ("sched/wait: Break
> > up long wake list walk") introduces WQ_FLAG_BOOKMARK to break up long
> > wake list walk. When the number of walked entries reach 64, the waker
> > will record scan position and release the queue lock, which reduces
> > interrupts and rescheduling latency.
>
> Maybe we could try removing bookmarks instead?  There was a thread a
> while ago where we agreed they weren't actually useful any more.
>
> Patches to follow ...


  reply	other threads:[~2023-10-10  7:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10  3:28 Bin Lai
2023-10-10  3:57 ` Matthew Wilcox
2023-10-10  7:04   ` lai bin [this message]
2023-10-10  3:58 ` [PATCH 1/2] filemap: Remove use of wait bookmarks Matthew Wilcox (Oracle)
2023-10-10  3:58   ` [PATCH 2/2] sched: Remove " Matthew Wilcox (Oracle)
2023-10-10  7:13     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE82Ze2HSJcTp4aNzMne877L+kyCwG3WXTLMdSwJ+HqsfbnHSw@mail.gmail.com \
    --to=sclaibin@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=robinlai@tencent.com \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox