From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0141FC2D0A3 for ; Wed, 4 Nov 2020 17:51:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 671962087D for ; Wed, 4 Nov 2020 17:51:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IXl11llE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 671962087D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9BDF36B005D; Wed, 4 Nov 2020 12:51:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 96D6E6B0068; Wed, 4 Nov 2020 12:51:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 883D06B006E; Wed, 4 Nov 2020 12:51:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0159.hostedemail.com [216.40.44.159]) by kanga.kvack.org (Postfix) with ESMTP id 5B6C56B005D for ; Wed, 4 Nov 2020 12:51:01 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E7ACA824999B for ; Wed, 4 Nov 2020 17:51:00 +0000 (UTC) X-FDA: 77447476680.08.shape07_200a549272c3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id C73381819E76F for ; Wed, 4 Nov 2020 17:51:00 +0000 (UTC) X-HE-Tag: shape07_200a549272c3 X-Filterd-Recvd-Size: 9808 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Nov 2020 17:51:00 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id t16so5681440oie.11 for ; Wed, 04 Nov 2020 09:51:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SmmRKfUI57+ASIBQcePaOUav20StSxB9VBqKRyvBS+I=; b=IXl11llEDPCGFmMnByQchu6QJ/G9RuygDTJ6zdfz3YLJoJgTpZyNPA7NScfBUeZZL0 ioCcO3qLRkFrHG7VBPjFMMrUk6cicIe/3mvk8GLiEVmDc+JIT2Aud55PXRClDb4dZLmU uWYo0GqDTPZzm552NXOE4BgMZSkxJbYw9x6MQP3NmNhCQHbmdzqO3psEDAbfH2sV92z3 eTDX9+CcRVp4iSTo/bjB/oTshfVx0IZVWqKQOijXiPNyrsHzqXnu0EvgxRMtx0cQdXX7 eolrYdzb6Tu/THwdaLi48bHHoTS+daz0MmnIjKvVZpJphjH4lM7A00dfo45sHa6zXokM OfSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SmmRKfUI57+ASIBQcePaOUav20StSxB9VBqKRyvBS+I=; b=eR0wIu1oOLcPE0y47V8fMuuYkMZUwaN2oft0va/Qgdi+5pm/czPIOPbFpLcQxxAlxj kE+/b+R1jqbxo9ySaZ0ZDZywj3qjnDC/5BH8W3TxjVHAXuxZagKCbRduQ/BYIlRNrS9X EERpkHHk/o70dG8VgOIZTjshibAJFEhESRxOqqjMFoh+o6HjPkigWSzaf/GU/J3iABSy 18tEBqAfokKb2Falr2pb9Lcyr+93kCOjoChhAee1s2Q2vcuiNLT64RoufKxSmGi6HdPu Lspb2YPNcNnhL31Yz4cvMkoTjk9756xmYW9nrD4cOfIX2k7v1TCdsq23kj2ZBuQ/m+rP GcKA== X-Gm-Message-State: AOAM530/dgFaICZSOr7S1CGtptwmr7thNGdl8LvgqBDOYqmeHSsIS7IQ N1v0zNQKXxwb6DT+w5wRoyTnUQImFzH3hSbeGtw= X-Google-Smtp-Source: ABdhPJyp/bySwbgpnfVqpcVm6qeBLsAtShC3BCzZbdsFWLYVFWvZo/RdZBU9xKZonDTjq644fJI7pAow4vVcNkGdmUQ= X-Received: by 2002:a05:6808:2c4:: with SMTP id a4mr3079382oid.114.1604512259492; Wed, 04 Nov 2020 09:50:59 -0800 (PST) MIME-Version: 1.0 References: <20201103131754.94949-1-laoar.shao@gmail.com> <20201103131754.94949-2-laoar.shao@gmail.com> <20201103194819.GM7123@magnolia> <20201104162640.GD7115@magnolia> In-Reply-To: <20201104162640.GD7115@magnolia> From: Amy Parker Date: Wed, 4 Nov 2020 09:50:47 -0800 Message-ID: Subject: Re: [PATCH v8 resend 1/2] mm: Add become_kswapd and restore_kswapd To: "Darrick J. Wong" Cc: Yafang Shao , Andrew Morton , Dave Chinner , Christoph Hellwig , Matthew Wilcox , Michal Hocko , Linux MM , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 4, 2020 at 8:30 AM Darrick J. Wong wrote: > > On Wed, Nov 04, 2020 at 10:17:16PM +0800, Yafang Shao wrote: > > On Wed, Nov 4, 2020 at 3:48 AM Darrick J. Wong wrote: > > > > > > On Tue, Nov 03, 2020 at 09:17:53PM +0800, Yafang Shao wrote: > > > > From: "Matthew Wilcox (Oracle)" > > > > > > > > Since XFS needs to pretend to be kswapd in some of its worker threads, > > > > create methods to save & restore kswapd state. Don't bother restoring > > > > kswapd state in kswapd -- the only time we reach this code is when we're > > > > exiting and the task_struct is about to be destroyed anyway. > > > > > > > > Cc: Dave Chinner > > > > Acked-by: Michal Hocko > > > > Reviewed-by: Darrick J. Wong > > > > Reviewed-by: Christoph Hellwig > > > > Signed-off-by: Matthew Wilcox (Oracle) > > > > Signed-off-by: Yafang Shao > > > > --- > > > > fs/xfs/libxfs/xfs_btree.c | 14 ++++++++------ > > > > include/linux/sched/mm.h | 23 +++++++++++++++++++++++ > > > > mm/vmscan.c | 16 +--------------- > > > > 3 files changed, 32 insertions(+), 21 deletions(-) > > > > > > > > diff --git a/fs/xfs/libxfs/xfs_btree.c b/fs/xfs/libxfs/xfs_btree.c > > > > index 2d25bab..a04a442 100644 > > > > --- a/fs/xfs/libxfs/xfs_btree.c > > > > +++ b/fs/xfs/libxfs/xfs_btree.c > > > > @@ -2813,8 +2813,9 @@ struct xfs_btree_split_args { > > > > { > > > > struct xfs_btree_split_args *args = container_of(work, > > > > struct xfs_btree_split_args, work); > > > > + bool is_kswapd = args->kswapd; > > > > unsigned long pflags; > > > > - unsigned long new_pflags = PF_MEMALLOC_NOFS; > > > > + int memalloc_nofs; > > > > > > > > /* > > > > * we are in a transaction context here, but may also be doing work > > > > @@ -2822,16 +2823,17 @@ struct xfs_btree_split_args { > > > > * temporarily to ensure that we don't block waiting for memory reclaim > > > > * in any way. > > > > */ > > > > - if (args->kswapd) > > > > - new_pflags |= PF_MEMALLOC | PF_SWAPWRITE | PF_KSWAPD; > > > > - > > > > - current_set_flags_nested(&pflags, new_pflags); > > > > + if (is_kswapd) > > > > + pflags = become_kswapd(); > > > > + memalloc_nofs = memalloc_nofs_save(); > > > > > > > > args->result = __xfs_btree_split(args->cur, args->level, args->ptrp, > > > > args->key, args->curp, args->stat); > > > > complete(args->done); > > > > > > > > - current_restore_flags_nested(&pflags, new_pflags); > > > > + memalloc_nofs_restore(memalloc_nofs); > > > > + if (is_kswapd) > > > > + restore_kswapd(pflags); > > > > > > Note that there's a trivial merge conflict with the mrlock_t removal > > > series. I'll carry the fix in the tree, assuming that everything > > > passes. > > > > > > > This patchset is based on Andrew's tree currently. > > Seems I should rebase this patchset on your tree instead of Andrew's tree ? > > That depends on whether or not you want me to push these two patches > through the xfs tree or if they're going through Andrew (Morton?)'s > quiltset. I think they could go through either, but the XFS tree might be ever-so-slightly better. > > Frankly I'd rather take them via xfs since most of the diff is xfs... Yeah, it's an XFS patch so let's throw it through the XFS tree. > > --D > > > > --D > > > > > > > } > > > > > > > > /* > > > > diff --git a/include/linux/sched/mm.h b/include/linux/sched/mm.h > > > > index d5ece7a..2faf03e 100644 > > > > --- a/include/linux/sched/mm.h > > > > +++ b/include/linux/sched/mm.h > > > > @@ -278,6 +278,29 @@ static inline void memalloc_nocma_restore(unsigned int flags) > > > > } > > > > #endif > > > > > > > > +/* > > > > + * Tell the memory management code that this thread is working on behalf > > > > + * of background memory reclaim (like kswapd). That means that it will > > > > + * get access to memory reserves should it need to allocate memory in > > > > + * order to make forward progress. With this great power comes great > > > > + * responsibility to not exhaust those reserves. > > > > + */ > > > > +#define KSWAPD_PF_FLAGS (PF_MEMALLOC | PF_SWAPWRITE | PF_KSWAPD) > > > > + > > > > +static inline unsigned long become_kswapd(void) > > > > +{ > > > > + unsigned long flags = current->flags & KSWAPD_PF_FLAGS; > > > > + > > > > + current->flags |= KSWAPD_PF_FLAGS; > > > > + > > > > + return flags; > > > > +} > > > > + > > > > +static inline void restore_kswapd(unsigned long flags) > > > > +{ > > > > + current->flags &= ~(flags ^ KSWAPD_PF_FLAGS); > > > > +} > > > > + > > > > #ifdef CONFIG_MEMCG > > > > DECLARE_PER_CPU(struct mem_cgroup *, int_active_memcg); > > > > /** > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > > > index 1b8f0e0..77bc1dd 100644 > > > > --- a/mm/vmscan.c > > > > +++ b/mm/vmscan.c > > > > @@ -3869,19 +3869,7 @@ static int kswapd(void *p) > > > > if (!cpumask_empty(cpumask)) > > > > set_cpus_allowed_ptr(tsk, cpumask); > > > > > > > > - /* > > > > - * Tell the memory management that we're a "memory allocator", > > > > - * and that if we need more memory we should get access to it > > > > - * regardless (see "__alloc_pages()"). "kswapd" should > > > > - * never get caught in the normal page freeing logic. > > > > - * > > > > - * (Kswapd normally doesn't need memory anyway, but sometimes > > > > - * you need a small amount of memory in order to be able to > > > > - * page out something else, and this flag essentially protects > > > > - * us from recursively trying to free more memory as we're > > > > - * trying to free the first piece of memory in the first place). > > > > - */ > > > > - tsk->flags |= PF_MEMALLOC | PF_SWAPWRITE | PF_KSWAPD; > > > > + become_kswapd(); > > > > set_freezable(); > > > > > > > > WRITE_ONCE(pgdat->kswapd_order, 0); > > > > @@ -3931,8 +3919,6 @@ static int kswapd(void *p) > > > > goto kswapd_try_sleep; > > > > } > > > > > > > > - tsk->flags &= ~(PF_MEMALLOC | PF_SWAPWRITE | PF_KSWAPD); > > > > - > > > > return 0; > > > > } > > > > > > > > -- > > > > 1.8.3.1 > > > > > > > > > > > > -- > > Thanks > > Yafang Best regards, Amy Parker (they/them)