From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6198FC2D0A3 for ; Tue, 3 Nov 2020 15:03:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D44DB20780 for ; Tue, 3 Nov 2020 15:03:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A0ueR2wh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D44DB20780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 020B36B005C; Tue, 3 Nov 2020 10:03:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EECF66B005D; Tue, 3 Nov 2020 10:03:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB6D96B0070; Tue, 3 Nov 2020 10:03:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id AB4A76B005C for ; Tue, 3 Nov 2020 10:03:35 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 446991EE6 for ; Tue, 3 Nov 2020 15:03:35 +0000 (UTC) X-FDA: 77443425990.29.trick03_46176b6272b9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 6D3D718024CE9 for ; Tue, 3 Nov 2020 15:02:48 +0000 (UTC) X-HE-Tag: trick03_46176b6272b9 X-Filterd-Recvd-Size: 4031 Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Nov 2020 15:02:47 +0000 (UTC) Received: by mail-oi1-f195.google.com with SMTP id w145so12982011oie.9 for ; Tue, 03 Nov 2020 07:02:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5cSj1qyXPcAnIprjkzrJyn0tLU6UO+RSsAyudL3znpE=; b=A0ueR2whzabPvobC83uA8Ecpb5mhETm5xYuhVKX/pA6/uuZJeIrE5mL1i5k6/j08Cj I7tWWvYQNEL2QWJMcgLlTTUnhJjBemK4BMO1zlXGSjn6HI746Q24v/Hy7q+nIcInzY/o EO400+F8h0igJ9oUbr9dWb3553af6m95x/wsErcPJXszDlC6eGxbjuBNoSWfEqyd6ofK 34mu8ffPfQwuNWC5r9UUu9H6OHzUkFfHnYfTFsI71yDNn9lwKHnU7FJ3/OjZrsgjGapG XNKcBIdfD4604AnahM/p9cqNIhv8cJWK5wIuclybFcjh3kzMO9YREsu8m3D67/hJqYJC E57g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5cSj1qyXPcAnIprjkzrJyn0tLU6UO+RSsAyudL3znpE=; b=N9NEDvKoq92Dhv7c7H/AmiBS5RaF2ru3XCZ2SM5OKcy0pp0HQMgIFLC4hkbw10Nlvl c9VGDARTOSgvoYqrEHKK6yKuIERmrDmka8d72tJiOz9shienoxiZgeP2XoLnSMS0l9em OL2H/gGWxyXd32Lk0yHwGqpfDJqmfsd7ycN0y3xUcQoj6Fxpm2yRMEcqbywXwwHet9Jj cZIqOlY3BYu2mBt31jm5P9/qucZUJlNzfdp5ePRpwNeLmFWYU2NehmA5eMyBlpMqx06R R4Vr1bFoErkeJsOBcPBr8v10LVkspgS3829ntfw0PEwpf9n6CCiMAjVhblCLHv+jhUCM 73ow== X-Gm-Message-State: AOAM533ngGgBPgTAc4fNS1sHjvlc4xqi+uBTpGU6iemfZBq7gGUWXMh5 4vFTZ1qebH1QmH65jeRaNMQPH8U2DW6Uos/2S1o= X-Google-Smtp-Source: ABdhPJz3SXex+eqBK9cJWVNs2PeRmh1EbeSIyFf4MDZEYfI7pO6vgtipWtAumPk+ebuoP60Rj8x1+OzJPjyaZucz0VY= X-Received: by 2002:aca:cc08:: with SMTP id c8mr67114oig.161.1604415767222; Tue, 03 Nov 2020 07:02:47 -0800 (PST) MIME-Version: 1.0 References: <20201102184312.25926-1-willy@infradead.org> <20201102184312.25926-2-willy@infradead.org> <20201103072700.GA8389@lst.de> <20201103145250.GX27442@casper.infradead.org> In-Reply-To: <20201103145250.GX27442@casper.infradead.org> From: Amy Parker Date: Tue, 3 Nov 2020 07:02:36 -0800 Message-ID: Subject: Re: [PATCH 01/17] mm/filemap: Rename generic_file_buffered_read subfunctions To: Matthew Wilcox Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, kent.overstreet@gmail.com Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.001693, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 3, 2020 at 6:53 AM Matthew Wilcox wrote: > > On Tue, Nov 03, 2020 at 08:27:00AM +0100, Christoph Hellwig wrote: > > On Mon, Nov 02, 2020 at 06:42:56PM +0000, Matthew Wilcox (Oracle) wrote: > > > The recent split of generic_file_buffered_read() created some very > > > long function names which are hard to distinguish from each other. > > > Rename as follows: > > > > > > generic_file_buffered_read_readpage -> filemap_read_page > > > generic_file_buffered_read_pagenotuptodate -> filemap_update_page > > > generic_file_buffered_read_no_cached_page -> filemap_create_page > > > generic_file_buffered_read_get_pages -> filemap_get_pages > > > > Find with me, although I think filemap_find_get_pages would be a better > > name for filemap_get_pages. > > To me, 'find' means 'starting from this position, search forward in the > array for the next page', but we don't want to do that, we just want to > get a batch of pages starting _at_ this index. Arguably it'd be better > named filemap_get_or_create_batch(). filemap_get_or_crerate_batch() would be a better name, as to me, find entails "begin here and continue looking for the next instance" (in this case, an instance would be a page). Best regards, Amy Parker (they/them)