From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9695DC433E0 for ; Mon, 1 Feb 2021 23:54:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E893464ED2 for ; Mon, 1 Feb 2021 23:54:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E893464ED2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3B2896B0005; Mon, 1 Feb 2021 18:54:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 363086B0006; Mon, 1 Feb 2021 18:54:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 22A3F6B006E; Mon, 1 Feb 2021 18:54:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 0ED0E6B0005 for ; Mon, 1 Feb 2021 18:54:29 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D13EC180AD81A for ; Mon, 1 Feb 2021 23:54:28 +0000 (UTC) X-FDA: 77771355816.02.low71_13128fc275c6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id ACE9310097AA1 for ; Mon, 1 Feb 2021 23:54:28 +0000 (UTC) X-HE-Tag: low71_13128fc275c6 X-Filterd-Recvd-Size: 3650 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Mon, 1 Feb 2021 23:54:28 +0000 (UTC) Received: by mail-ot1-f54.google.com with SMTP id e70so18119801ote.11 for ; Mon, 01 Feb 2021 15:54:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3aDojUkHo90pEvXpZkv6t3T7DNgGSpgLl4Ya1KVsoDg=; b=SfPPo5qo4TCbx8PCc9ZAnK4vquw07MtaBluOtSn9+pBr7hKOO71zebkb3RW6fx/IeT Y6Hq9g1voseYoRkM4LcKZmrUSzv4UOoi99X4mPdw78ccW0i4g29tBt0zNsn1vMLdL6wj 1KzJZgmHRJFHrQaIqyn5pnD6NaNn4Oh6EZN/BU/8Ac+sjZDVsow1+gNQY54dEKSmZhAf QBONNo+qg0r+pC+wSDgvpYet+6RKa8uzd5AaZ5GkzoOkPK6Ul/PLHNhIeVx+8KiMZlXO kfcYhfVko/xwTPeaSSG82Eztsry2ESa3icu0OboHvKHlkRCpiuNsOC/KQkHmvONE4SdB DaKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3aDojUkHo90pEvXpZkv6t3T7DNgGSpgLl4Ya1KVsoDg=; b=PIAcp9HjLRzIkRKnddRlcGGIGrf87Dk0tobYKdSwMbS5lwEW22I24E+wzH++Hirq0P ZAwxONoq1cqcocVNCGAuD9XfPCheXsmG8PJUe+UunB0Yt33Jbz2TEE6tAEJwLmiuQHfI rj/sDbM38RQWl9J9TR1nrFaS10I8Egq4AiSHamN3Ap/4PAR3PMm+A3s29Hs3TpkC3ep4 W8GGTJz3gkZwOahPk+Hh2+7qpfjsxZHOu8qegXIlqxImC81P32wXfxV6Tx5T7bxykvRY 47kyA722vPEYdQUie6x0FmZwhLKwQ+60rs+zdx44NS/d3lRJlPTBWRUvF1AlbB8yq6hP VOVg== X-Gm-Message-State: AOAM533oXTg6yEd+QhjRQOhjvawqnQjelA8+yTmE37nCN5S/lt1QfEwm DebyYebDZpOyfCdA5i/RxPt32qsv//POJuddvmh2wjMrW94= X-Google-Smtp-Source: ABdhPJwQYlfkagOgAez/IT1Hbig0YufGodBOSs2aQZQSR8SNzoXURKsbDPAmOs6KWJBgQa/EvaxKVa2clF7JDJ/XAWE= X-Received: by 2002:a05:6830:15c5:: with SMTP id j5mr13495926otr.185.1612223667775; Mon, 01 Feb 2021 15:54:27 -0800 (PST) MIME-Version: 1.0 References: <20210201233254.91809-1-rikard.falkeborn@gmail.com> In-Reply-To: <20210201233254.91809-1-rikard.falkeborn@gmail.com> From: Amy Parker Date: Mon, 1 Feb 2021 15:54:15 -0800 Message-ID: Subject: Re: [PATCH] mm/swap_state: Constify static struct attribute_group To: Rikard Falkeborn Cc: Andrew Morton , Linux MM , linux-kernel@vger.kernel.org, Huang Ying Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 1, 2021 at 3:37 PM Rikard Falkeborn wrote: > > The only usage of swap_attr_group is to pass its address to > sysfs_create_group() which takes a pointer to const attribute_group. > Make it const to allow the compiler to put it in read-only memory. > > Signed-off-by: Rikard Falkeborn > --- > mm/swap_state.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/swap_state.c b/mm/swap_state.c > index d0d417efeecc..3cdee7b11da9 100644 > --- a/mm/swap_state.c > +++ b/mm/swap_state.c > @@ -901,7 +901,7 @@ static struct attribute *swap_attrs[] = { > NULL, > }; > > -static struct attribute_group swap_attr_group = { > +static const struct attribute_group swap_attr_group = { > .attrs = swap_attrs, > }; > > -- > 2.30.0 > Looks all good to me - there aren't any dependencies on it anywhere else. Reviewed-by: Amy Parker