From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07DC5C47088 for ; Wed, 26 May 2021 20:20:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A6830613BF for ; Wed, 26 May 2021 20:20:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6830613BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9B3F36B0036; Wed, 26 May 2021 16:20:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 938406B006E; Wed, 26 May 2021 16:20:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4596C6B0070; Wed, 26 May 2021 16:20:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 05C1C6B0036 for ; Wed, 26 May 2021 16:20:17 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A6B05B7AD for ; Wed, 26 May 2021 20:20:17 +0000 (UTC) X-FDA: 78184499274.39.F01188E Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by imf16.hostedemail.com (Postfix) with ESMTP id 9FF048019127 for ; Wed, 26 May 2021 20:20:10 +0000 (UTC) Received: by mail-oi1-f170.google.com with SMTP id w127so2770271oig.12 for ; Wed, 26 May 2021 13:20:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=fqFRJj/H0421cmdUHy5MiAH5BPkuY5lwOXhKnmr6YX8=; b=bWyT5uik5LFbEbtHC/QkvEhIAEBoh4m2QVgGQCpbyBfevTfRutPAVwzFDfOJIYUweL h50y3P6QR9wFBoR2J4HYDOvx9PKjVjFGNK1RK+DABJ4zt8dzaXN4/1brL1FCq4LP4Z0V zJG8uLzlOnGRCXFjgf/F35i5k++TuVTgLTj8o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=fqFRJj/H0421cmdUHy5MiAH5BPkuY5lwOXhKnmr6YX8=; b=DEKGhoRCN77Z2N35B6Uj6ef7yGCDXfksbQ1yfncjVXQO+pvoY6eXve0fftm8ksyKQh UIQerEzZJrRZxDpKHLWq2pWlaDf7IO3yfLnraUS4/zifEaUWaOXoA6CyIb6053oUHmbC YmOY+y9vGGux091TE/yfBpDha+FdlNdKudhCW8c4JW1JuKu/hosVCwpMWK86WAQJ6leW /qitLzteNXNzoG11F6z5F5XFe/xguGJmyPOVK1qXqCo0fYlNMy88pUzYcIOd64lgCn85 fn9kNbFH6vpsmw/HcvmrOocqUdNXlmbRfYbifPLgMITs0LtzlVSUCYzCyv9K9y2j5W9r Iq0Q== X-Gm-Message-State: AOAM533dpsB8X0BOzupKk46FHD1a4NRhsr2gMMXDsTTT1aVNYQ8T/Ab0 rpod6NR3Zor+RBky6f0oNA4IuzA0ADkt1jZ4hiKXGQ== X-Google-Smtp-Source: ABdhPJy99awNtyh5dTExQ4QXD1TMtQFD6lpm7mhJDcOWhrNz8PtqTy4TGH9OqBxmADLKe5YKljyWxBfvjQfYal4flHY= X-Received: by 2002:aca:654d:: with SMTP id j13mr3221559oiw.125.1622060416706; Wed, 26 May 2021 13:20:16 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 26 May 2021 16:20:16 -0400 MIME-Version: 1.0 In-Reply-To: References: <20210526025625.601023-1-swboyd@chromium.org> <20210526025625.601023-2-swboyd@chromium.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Wed, 26 May 2021 16:20:16 -0400 Message-ID: Subject: Re: [External] [PATCH v2 1/4] slub: Restore slub_debug=- behavior To: Muchun Song , Vlastimil Babka Cc: Andrew Morton , LKML , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Linux Memory Management List , Petr Mladek , Joe Perches Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=bWyT5uik; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf16.hostedemail.com: domain of swboyd@chromium.org designates 209.85.167.170 as permitted sender) smtp.mailfrom=swboyd@chromium.org X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9FF048019127 X-Stat-Signature: paqsn9dmqopdowwxq8rxx6xqfc9jqqwp X-HE-Tag: 1622060410-317874 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Quoting Vlastimil Babka (2021-05-26 03:39:54) > On 5/26/21 6:04 AM, Muchun Song wrote: > > On Wed, May 26, 2021 at 10:56 AM Stephen Boyd wrote: > >> > >> Passing slub_debug=- on the kernel commandline is supposed to disable > >> slub debugging. This is especially useful with CONFIG_SLUB_DEBUG_ON > >> where the default is to have slub debugging enabled in the build. Due to > >> some code reorganization this behavior was dropped, but the code to make > >> it work mostly stuck around. Restore the previous behavior by disabling > >> the static key when we parse the commandline and see that we're trying > >> to disable slub debugging. > >> > >> Cc: Vlastimil Babka > >> Fixes: e17f1dfba37b ("mm, slub: extend slub_debug syntax for multiple blocks") > > Acked-by: Vlastimil Babka > > > > > Is it caused by the commit ca0cab65ea2b ("mm, slub: introduce static > > key for slub_debug()")? > > Yep, looks like a better Fixes: candidate. > Fixed it. Thanks.