From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF34CC47082 for ; Wed, 26 May 2021 19:27:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 69552613D3 for ; Wed, 26 May 2021 19:27:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69552613D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 757A36B006E; Wed, 26 May 2021 15:27:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 705CC6B0070; Wed, 26 May 2021 15:27:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2976B6B0071; Wed, 26 May 2021 15:27:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0233.hostedemail.com [216.40.44.233]) by kanga.kvack.org (Postfix) with ESMTP id DC2556B006E for ; Wed, 26 May 2021 15:27:39 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8352A83EF for ; Wed, 26 May 2021 19:27:39 +0000 (UTC) X-FDA: 78184366638.37.011093F Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by imf22.hostedemail.com (Postfix) with ESMTP id 1C52AC0042E4 for ; Wed, 26 May 2021 19:27:32 +0000 (UTC) Received: by mail-ot1-f51.google.com with SMTP id i14-20020a9d624e0000b029033683c71999so2097823otk.5 for ; Wed, 26 May 2021 12:27:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=XLye5dQGV2iB+VVuo0c6btLDSSuBEMFIhskiJnvHVYE=; b=Th5Nl+hYwEnZ+/OeAZzVsdhzied7v7MgxFvVj2nodjNlf4B0V9dqPcI7kOoa1HfK/t aTg76GIhBg8QQ+gnFmEDQ18hEZTFTNR9q9tAjaFhvnZLW4AXwFjw5IzGBqzrVEnNXpYs cSGmvPIOnLQJixXlHYQMmBOCzMXKD439PiAeU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=XLye5dQGV2iB+VVuo0c6btLDSSuBEMFIhskiJnvHVYE=; b=NVD4GHypE7Nt1XIhmKXMO0kVYcT5c8cpEVhZV7W21CuNfN59bhsedNBNvjs3fkIYwG hmp66VKlU6Yc5WoNKemoL8/oJDeKDX8Ve1m8RqcLR4qq+8JHRrAs/rZbOAyHQp9TGFWA T8ujh1cVR8MuO3E13+I/Mz9ftadLvlARKrvaZUdnzdytm+ajeFTTipU+9L0AmB0GgDkd bLoYos3H4Jl2aeTBotrMOel/jZ/fHxJ5gaQGT5c/GlyBKdVz2ZQms1g8iehkI+f16hi+ CjlbzRCfv82kL/+NcHK7Eq0LVZm8tpb+qaIBF+lFGSSil7k0vo1KcgUNfuu5y7JtZZRM ruaw== X-Gm-Message-State: AOAM530CNHMbNE0BsNIGYWTuxzIT6yf7wJWfHT0gbgo4bjoEduY2VGe0 1ePL0a2aILD43nX42JKDaeLx+VkqHho0vFBF2qbxoQ== X-Google-Smtp-Source: ABdhPJxmCzw3SOm2nc1UuS4XbsXRw1QkeeGorCYH2p0j+n9kIHqeE9+ZBWGu1fqJIYtpQcsAP2a3ReNuzbpYD1N1Sng= X-Received: by 2002:a05:6830:1556:: with SMTP id l22mr3602055otp.34.1622057258594; Wed, 26 May 2021 12:27:38 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 26 May 2021 15:27:37 -0400 MIME-Version: 1.0 In-Reply-To: References: <20210526025625.601023-1-swboyd@chromium.org> <20210526025625.601023-5-swboyd@chromium.org> <555eaf8b-deb2-fa49-ddef-a74645848159@suse.cz> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Wed, 26 May 2021 15:27:37 -0400 Message-ID: Subject: Re: [PATCH v2 4/4] slub: Force on no_hash_pointers when slub_debug is enabled To: Petr Mladek , Vlastimil Babka Cc: Andrew Morton , linux-kernel@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , linux-mm@kvack.org, Joe Perches Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Th5Nl+hY; spf=pass (imf22.hostedemail.com: domain of swboyd@chromium.org designates 209.85.210.51 as permitted sender) smtp.mailfrom=swboyd@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 1C52AC0042E4 X-Stat-Signature: dj68eq5u7pq6kxaxgeheg3mkjginjwn7 X-HE-Tag: 1622057252-515726 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Quoting Petr Mladek (2021-05-26 06:47:23) > On Wed 2021-05-26 12:48:47, Vlastimil Babka wrote: > > On 5/26/21 4:56 AM, Stephen Boyd wrote: > > > Obscuring the pointers that slub shows when debugging makes for some > > > confusing slub debug messages: > > > > > > Padding overwritten. 0x0000000079f0674a-0x000000000d4dce17 > > > > > > I opted for extern because I guess we don't want to advertise > > > no_hash_pointers_enable() in some sort of header file? It can be put in > > > a header file > > > > Hm looks like the bots disagree. I suppose a declaration right above definition > > in lib/vsprintf.c would silence them, but I'll leave it to printk maintainers if > > they would prefer that way or traditionally > > include/linux/kernel.h > > I slightly prefer to put it into kernel.h. I expect that some more > debugging facilities would want to enable this in the future. > But I would accept even the "ugly" declaration in vsprintf.c. Ok no problem. Would printk.h be more appropriate?