linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Joseph Yasi <joe.yasi@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: bugzilla-daemon@bugzilla.kernel.org, linux-mm@kvack.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [Bug 180101] New: BUG: unable to handle kernel paging request at x with "mm: remove gup_flags FOLL_WRITE games from __get_user_pages()"
Date: Fri, 28 Oct 2016 18:25:15 -0400	[thread overview]
Message-ID: <CADzA9onJOyKGWkzzr7HP742-xXpiJciNddhv946Yg_tPSszTDQ@mail.gmail.com> (raw)
In-Reply-To: <20161028145215.87fd39d8f8822a2cd11b621c@linux-foundation.org>

[-- Attachment #1: Type: text/plain, Size: 2516 bytes --]

On Fri, Oct 28, 2016 at 5:52 PM, Andrew Morton <akpm@linux-foundation.org>
wrote:

>
> (switched to email.  Please respond via emailed reply-to-all, not via the
> bugzilla web interface).
>
> On Mon, 24 Oct 2016 01:27:15 +0000 bugzilla-daemon@bugzilla.kernel.org
> wrote:
>
> > https://bugzilla.kernel.org/show_bug.cgi?id=180101
> >
> >             Bug ID: 180101
> >            Summary: BUG: unable to handle kernel paging request at x with
> >                     "mm: remove gup_flags FOLL_WRITE games from
> >                     __get_user_pages()"
> >            Product: Memory Management
> >            Version: 2.5
> >     Kernel Version: 4.8.4
> >           Hardware: x86-64
> >                 OS: Linux
> >               Tree: Mainline
> >             Status: NEW
> >           Severity: high
> >           Priority: P1
> >          Component: Other
> >           Assignee: akpm@linux-foundation.org
> >           Reporter: joe.yasi@gmail.com
> >         Regression: No
> >
> > After updating to 4.8.3 and 4.8.4, I am having stability issues. I can
> also
> > reproduce them with 4.7.10. This issue does not occur with 4.8.2. I can
> also
> > not reproduce after reverting the security fix
> > 89eeba1594ac641a30b91942961e80fae978f839 "mm: remove gup_flags
> FOLL_WRITE games
> > from __get_user_pages()" with 4.8.4.
>
> That's 19be0eaffa3ac7d8eb ("mm: remove gup_flags FOLL_WRITE games from
> __get_user_pages()") in the upstream tree.
>
> I seem to recall a fix for that patch went flying past earlier this
> week.  Perhaps Linus recalls?
>
> 19be0eaffa3ac7d8eb has gone into a billion -stable trees so we'll need
> to be attentive...
>
>
I've been able to reproduce the issue with 19be0eaffa3ac7d8eb ("mm: remove
gup_flags FOLL_WRITE games from __get_user_pages()") reverted. I initially
suspected it because I hadn't seen the issue until 4.8.3, and also saw it
when I tried 4.7.10. Initially, I wasn't able to reproduce it with 4.8.2,
but I've since been able to do that. This smells like a race condition
somewhere. It's possible I just happened to never encounter that race
before.

The /home partition in question is btrfs on bcache in writethrough mode.
The cache drive is an 180 GB Intel SATA SSD, and the backing device is two
WD 3 TB SATA HDDs configured in MD RAID 10 f2 layout. / is btrfs on an NVMe
SSD.

I've also seen btrfs checksum errors in the kernel log when reproducing
this. Rebooting and running btrfs scrub finds nothing though so it seems
like in memory corruption.

Thanks,
Joe

[-- Attachment #2: Type: text/html, Size: 3578 bytes --]

  reply	other threads:[~2016-10-28 22:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-180101-27@https.bugzilla.kernel.org/>
2016-10-28 21:52 ` Andrew Morton
2016-10-28 22:25   ` Joseph Yasi [this message]
2016-10-28 23:12     ` Linus Torvalds
2016-10-29  1:00       ` Joseph Yasi
2016-10-29  1:26         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADzA9onJOyKGWkzzr7HP742-xXpiJciNddhv946Yg_tPSszTDQ@mail.gmail.com \
    --to=joe.yasi@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox