From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6716C433E0 for ; Wed, 17 Mar 2021 20:45:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0382464F30 for ; Wed, 17 Mar 2021 20:45:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0382464F30 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3E33B6B006E; Wed, 17 Mar 2021 16:45:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 39DAF6B0070; Wed, 17 Mar 2021 16:45:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20C5B6B0071; Wed, 17 Mar 2021 16:45:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 0514F6B006E for ; Wed, 17 Mar 2021 16:45:11 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AA56F1807B53E for ; Wed, 17 Mar 2021 20:45:11 +0000 (UTC) X-FDA: 77930546022.14.8F89E0D Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf09.hostedemail.com (Postfix) with ESMTP id 9DE476001E7C for ; Wed, 17 Mar 2021 20:45:04 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id t18so473346ejc.13 for ; Wed, 17 Mar 2021 13:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VXDBuwtZDRVlKmXjX6RLYWp8aN0fn5ihDHSgEVvVeSI=; b=fCaFXuUoCSuTNHW1TUhZFbvJdVn9mau28hZtqJ3USyaTxWHCSRusVH5MDeD4JJrjFV 8VjR9pyET6P5O5cdIHfSkMQLw5D6J0LtyOnE0RQf9Pm28gbEMnbuCJjvkLjG6wsC49+r WJGUv9nIFTKFstSgGl3P9zv2NyigfksGOiX5yE65u9D0I1haEGE3FI/Cqx/K39wOPmum nzF/3mRkpgib1vU9xEqL4qBNDbCoH1dbQrYb5l9PRwKQZco/J8ugutvdoe4VyhWrGSeZ yWMZBqAZOqGbWdx0JWhmb9+xtF6Drvct656lP46WS+4kvbZLOLPABFgpnp70+NS26UvB eP4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VXDBuwtZDRVlKmXjX6RLYWp8aN0fn5ihDHSgEVvVeSI=; b=WMNf7GdNDy9VrcAXKlrUbA30jStcK3/Z2ETI9fgKitDExa4Yfx0LCuF0dw/dVr/GuJ djfXN6WqHKJQl27s+lrjO5cLsT2cOxXIjRv81AAPXWqIUoyFocduMfBsPr/JQts0gHiP 7l+fmQMDzmwoJrGRSeGBxvWfOgRHgVSJSJbhQC93gvD5QB7/ucSH7RSxY6Lor4uA1YX/ MlyYiYXDebqqkrfQk8URkWOA460ABjp0ckXYO42VdzY0fKL1kghnT7lrJUFOvn6PzTL8 hA2eEL7XvALy6E3pYy/1CLAG/Jli8Lf4PbqDXLGCV7BbJl5KzwEVqo6XkPz3tboyQ+0h 3Wdg== X-Gm-Message-State: AOAM531vU6XwzTD7TmR/17p/j00hkLnqLHuWnMaSPRzsuMSJhsTzOgXJ crLqwFO1GPVQ1gkak0JCFw9kSezctTWbGj0/R702/g== X-Google-Smtp-Source: ABdhPJwPKLSVtSLBjWwvmw/X3ooel+wWPEypK/xdpz3ZnNCEqaxWW6LhkTLZWYeG5ckcrR8Q/c5X0BGrAryTGMxAD/c= X-Received: by 2002:a17:906:d157:: with SMTP id br23mr38497318ejb.192.1616013903040; Wed, 17 Mar 2021 13:45:03 -0700 (PDT) MIME-Version: 1.0 References: <20210303175235.3308220-1-bgeffon@google.com> <20210317191334.564944-1-bgeffon@google.com> <20210317204015.GM395976@xz-x1> In-Reply-To: <20210317204015.GM395976@xz-x1> From: Brian Geffon Date: Wed, 17 Mar 2021 16:44:25 -0400 Message-ID: Subject: Re: [PATCH v2 1/2] mm: Allow non-VM_DONTEXPAND and VM_PFNMAP mappings with MREMAP_DONTUNMAP To: Peter Xu Cc: Andrew Morton , Axel Rasmussen , Lokesh Gidra , Mike Rapoport , Hugh Dickins , "Michael S . Tsirkin" , LKML , linux-mm , Andy Lutomirski , Vlastimil Babka , Andrea Arcangeli , Sonny Rao , Minchan Kim , "Kirill A . Shutemov" , Dmitry Safonov Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 7scprxkkeoyuc3ojfnufhz5foq317nis X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9DE476001E7C Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf09; identity=mailfrom; envelope-from=""; helo=mail-ej1-f43.google.com; client-ip=209.85.218.43 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1616013904-628593 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Peter, Thank you as always for taking a look. This change relies on the existing check in vma_to_resize on line 686: https://elixir.bootlin.com/linux/v5.12-rc3/source/mm/mremap.c#L686 which returns -EFAULT when the vma is VM_DONTEXPAND or VM_PFNMAP. Thanks Brian On Wed, Mar 17, 2021 at 4:40 PM Peter Xu wrote: > > Hi, Brian, > > On Wed, Mar 17, 2021 at 12:13:33PM -0700, Brian Geffon wrote: > > Currently MREMAP_DONTUNMAP only accepts private anonymous mappings. This > > change will widen the support to include any mappings which are not > > VM_DONTEXPAND or VM_PFNMAP. The primary use case is to support > > MREMAP_DONTUNMAP on mappings which may have been created from a memfd. > > > > This change which takes advantage of the existing check in vma_to_resize > > for non-VM_DONTEXPAND and non-VM_PFNMAP mappings will cause > > MREMAP_DONTUNMAP to return -EFAULT if such mappings are remapped. This > > behavior is consistent with existing behavior when using mremap with > > such mappings. > > > > Lokesh Gidra who works on the Android JVM, provided an explanation of how > > such a feature will improve Android JVM garbage collection: > > "Android is developing a new garbage collector (GC), based on userfaultfd. > > The garbage collector will use userfaultfd (uffd) on the java heap during > > compaction. On accessing any uncompacted page, the application threads will > > find it missing, at which point the thread will create the compacted page > > and then use UFFDIO_COPY ioctl to get it mapped and then resume execution. > > Before starting this compaction, in a stop-the-world pause the heap will be > > mremap(MREMAP_DONTUNMAP) so that the java heap is ready to receive > > UFFD_EVENT_PAGEFAULT events after resuming execution. > > > > To speedup mremap operations, pagetable movement was optimized by moving > > PUD entries instead of PTE entries [1]. It was necessary as mremap of even > > modest sized memory ranges also took several milliseconds, and stopping the > > application for that long isn't acceptable in response-time sensitive > > cases. > > > > With UFFDIO_CONTINUE feature [2], it will be even more efficient to > > implement this GC, particularly the 'non-moveable' portions of the heap. > > It will also help in reducing the need to copy (UFFDIO_COPY) the pages. > > However, for this to work, the java heap has to be on a 'shared' vma. > > Currently MREMAP_DONTUNMAP only supports private anonymous mappings, this > > patch will enable using UFFDIO_CONTINUE for the new userfaultfd-based heap > > compaction." > > > > [1] https://lore.kernel.org/linux-mm/20201215030730.NC3CU98e4%25akpm@linux-foundation.org/ > > [2] https://lore.kernel.org/linux-mm/20210302000133.272579-1-axelrasmussen@google.com/ > > > > Signed-off-by: Brian Geffon > > --- > > mm/mremap.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/mm/mremap.c b/mm/mremap.c > > index ec8f840399ed..2c57dc4bc8b6 100644 > > --- a/mm/mremap.c > > +++ b/mm/mremap.c > > @@ -653,10 +653,6 @@ static struct vm_area_struct *vma_to_resize(unsigned long addr, > > return ERR_PTR(-EINVAL); > > } > > > > - if (flags & MREMAP_DONTUNMAP && (!vma_is_anonymous(vma) || > > - vma->vm_flags & VM_SHARED)) > > - return ERR_PTR(-EINVAL); > > - > > if (is_vm_hugetlb_page(vma)) > > return ERR_PTR(-EINVAL); > > The code change seems to be not aligned with what the commit message said. Did > you perhaps forget to add the checks against VM_DONTEXPAND | VM_PFNMAP? I'm > guessing that (instead of commit message to be touched up) because you still > attached the revert patch, then that check seems to be needed. Thanks, > > -- > Peter Xu >