From: Brian Geffon <bgeffon@google.com>
To: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
linux-block@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] zram: use GFP_KERNEL for post-processing slot allocation
Date: Thu, 5 Mar 2026 02:05:19 -0800 [thread overview]
Message-ID: <CADyq12y1r9G9WZd0ODY1OhhHMzjELQeqp5nORc2rVMsbKXfMBQ@mail.gmail.com> (raw)
In-Reply-To: <20260305021619.617481-1-senozhatsky@chromium.org>
On Wed, Mar 4, 2026 at 6:16 PM Sergey Senozhatsky
<senozhatsky@chromium.org> wrote:
>
> Post-processing slot allocation used to be performed under
> slot bit-lock, so gfp was restricted, then we switched to
> a sleepable slot lock but gpf still remained restricted.
> Drop that restriction and use GFP_KERNEL instead.
>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Acked-by: Brian Geffon <bgeffon@google.com>
> ---
> drivers/block/zram/zram_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index fa38d26119ec..6a6fd08a5a15 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -297,7 +297,7 @@ static bool place_pp_slot(struct zram *zram, struct zram_pp_ctl *ctl,
> struct zram_pp_slot *pps;
> u32 bid;
>
> - pps = kmalloc_obj(*pps, GFP_NOIO | __GFP_NOWARN);
> + pps = kmalloc_obj(*pps, GFP_KERNEL | __GFP_NOWARN);
> if (!pps)
> return false;
>
> --
> 2.53.0.473.g4a7958ca14-goog
>
prev parent reply other threads:[~2026-03-05 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 2:16 Sergey Senozhatsky
2026-03-05 10:05 ` Brian Geffon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADyq12y1r9G9WZd0ODY1OhhHMzjELQeqp5nORc2rVMsbKXfMBQ@mail.gmail.com \
--to=bgeffon@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox