From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7757C35240 for ; Sun, 2 Feb 2020 04:18:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 44B622082E for ; Sun, 2 Feb 2020 04:18:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BZ9+x4AU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44B622082E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 878666B061F; Sat, 1 Feb 2020 23:18:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 828D86B0621; Sat, 1 Feb 2020 23:18:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73E1E6B0622; Sat, 1 Feb 2020 23:18:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id 5C6696B061F for ; Sat, 1 Feb 2020 23:18:23 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0AFBC180AD804 for ; Sun, 2 Feb 2020 04:18:23 +0000 (UTC) X-FDA: 76443880086.29.cup40_eef75c2afe54 X-HE-Tag: cup40_eef75c2afe54 X-Filterd-Recvd-Size: 3787 Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Sun, 2 Feb 2020 04:18:22 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id m8so12330889edi.13 for ; Sat, 01 Feb 2020 20:18:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UuEb10QAUcFcGwJKCFeGhLUYYwMKG3vOlYqSejkAJjc=; b=BZ9+x4AUIFJLiX/N1VBjRD80E1JAY6p+Ow1VTwbX6FGZWiklyuGDkrP0qeMciPsMUe 8nTSaKr4Ho6/S7dW2SpMb/OZSIj7QcOWDEwMYH9REu0dT4ejNyJIPZbDM/NhReSGj4pW 0F1tPaYk4DNXr3WnbLQ58PPhFJERk1lmkG/IK6NW0wEAsqpyEd1UQ7Ty1JL1Akh47bmN tF+Efol3wF29/cOHJt8lRHPpntXfHAZbLjNTGpINUaeSuWaHL5PYTdxO5Kg4v+zE+uWo aQd7vruF8DxQ/LOBHcs/1WTiM3K89c7fQpOzkqbwjA03mvKLkr+BDjefK9rnfrRqG2H5 UqtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UuEb10QAUcFcGwJKCFeGhLUYYwMKG3vOlYqSejkAJjc=; b=cPmhg0IntprHEBb06Gsra0f2zs0TKTN3+SigVZe6dq2gMM2j96GDhsihkqjJq/ff9I fejxpHwE8nXAE/SV6gVONlpnp3mwCW+5AV4yn45XpDI+f/BDFc3yLxI1p23BNTnIiIUY Fxy6TpVHJ5p+MizsUdqT56QV/qaV46WHqF/hP91I44ukgjBRWw6+Rg8CwsuceI0konFX UzwfEqx+M/8AWPZmJe6o3DuXMySc5ZZqV02MkNGbqTc9K9fXWirIl07yo/OVzoBSI/UB 7oOVVVhjPF9mzns8DIWKHChv1jN61mkB0XFE8xmbYbYkMqOcb7JtlrbZt1XlwFf9LirS kBYA== X-Gm-Message-State: APjAAAV6ms5V4yJ65r5eom1TGvAkktvR8qucEflVVTldgCzRaXIavoUQ /KROswtsUiCQnTIc8P1X+2n1x3t8ED9frG13tbkmgg== X-Google-Smtp-Source: APXvYqybtw5f2jTQcpV4gY36OnxNY8241JvcKkzJUpgAl0cx/UBNZIzQjpkYuf3EJT/Lyi67pPW/bR73IKtF1FLPUjE= X-Received: by 2002:a17:906:82d6:: with SMTP id a22mr15774735ejy.242.1580617100799; Sat, 01 Feb 2020 20:18:20 -0800 (PST) MIME-Version: 1.0 References: <20200123014627.71720-1-bgeffon@google.com> <20200124190625.257659-1-bgeffon@google.com> <20200126220650.i4lwljpvohpgvsi2@box> <20200129104655.egvpavc2tzozlbqe@box> In-Reply-To: <20200129104655.egvpavc2tzozlbqe@box> From: Brian Geffon Date: Sun, 2 Feb 2020 05:17:53 +0100 Message-ID: Subject: Re: [PATCH v2] mm: Add MREMAP_DONTUNMAP to mremap(). To: "Kirill A. Shutemov" Cc: Andrew Morton , "Michael S . Tsirkin" , Arnd Bergmann , LKML , linux-mm , linux-api@vger.kernel.org, Andy Lutomirski , Andrea Arcangeli , Sonny Rao , Minchan Kim , Joel Fernandes , Yu Zhao , Jesse Barnes Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 29, 2020 at 11:46 AM Kirill A. Shutemov wrote: > Any better options for the flag name? (I have none) The other option is that it's broken up into two new flags the first MREMAP_MUSTMOVE which can be used regardless of whether or not you're leaving the original mapping mapped. This would do exactly what it describes: move the mapping to a new address with or without MREMAP_FIXED, this keeps consistency with MAYMOVE. The second flag would be the new MREMAP_DONTUNMAP flag which requires MREMAP_MUSTMOVE, again with or without MREMAP_FIXED. What are your thoughts on this?