From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45F43C00140 for ; Wed, 10 Aug 2022 19:19:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0EA86B0071; Wed, 10 Aug 2022 15:19:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBDE88E0002; Wed, 10 Aug 2022 15:19:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A854A8E0001; Wed, 10 Aug 2022 15:19:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 993D76B0071 for ; Wed, 10 Aug 2022 15:19:31 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6CCB6A1544 for ; Wed, 10 Aug 2022 19:19:31 +0000 (UTC) X-FDA: 79784646942.17.832621E Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf26.hostedemail.com (Postfix) with ESMTP id E78A614005B for ; Wed, 10 Aug 2022 19:19:30 +0000 (UTC) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-32269d60830so152559777b3.2 for ; Wed, 10 Aug 2022 12:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=hKx1VWalS/Kw4WukWOwnOrv52qOFOeVZOoDS2/nyvSw=; b=nDGS9Ngr7R8HMVfZu5I+9ubbd0j2NaAEp8oNKV0QVn5OeFo1iuYRpxDtgfR1ofERGA Q0aIZOGzb5H0gz7tnUwtWDN0zkX7lOq4ZeY9KWI4Ggu8rFWqT7gyP/sRJMGjeU2+qp4i M2SX3+GDvjvzrByd4uNbKs5h6dIB+S3bNo15q14WKCUu9O1e7AEsLnIMilWNYSlM3x95 8HvKc1ZpN6Ci3dlEaFIHqv3HgvdDzmAZmtUDRkFITKqZLAaUNkwntlWeBTbMc7dTnj0j 54LdGXtA7MZFZ0TldAae9FeMcs0Fa3ibtNHMKCh8UJJSr67nzRNb6n150FmM3nFBkdOv 02tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=hKx1VWalS/Kw4WukWOwnOrv52qOFOeVZOoDS2/nyvSw=; b=WLhIYiFHsPpTC8DE8vpW5jPlAupIk6Hz1Po9Cq3dYV99mSuns7M1lVdntzlLZpVzCx 1E6+A/kJZg8OZAmyRrg/lHuGHW4RRuziu6kb/PTO3Dens9TovUqSIZSawkQKB3bTawZW p27EM5a6P1urcIEBnXG9muT5EFb4rFMJhFyjBWKmhXeyZWeEt1pCrPSTd2qQXDcpAiX5 qg29To7OxY1j5OxbPrx5ZJXI/zYd9A2ciVYrT2QFRvf/jIDzwv/1NYSXILkmNHO6LBg8 femdIsH4pFdOcLJhLOc1x44psBuAh68gZRSEcX+EsE+VtLmTjz/pvytcgIeoxHFqV6th NTlQ== X-Gm-Message-State: ACgBeo3ApNGNgOTws/h9Msq6usAlvXx+nqAT/5LHoiO1J6AETJRKgHmb 8fKa/D8IMBiaBKpyPCQ+xOX9wVKzjAbZXEpEN2P+GQ== X-Google-Smtp-Source: AA6agR4pNhuhSEdQX5dtH5AS5BITIuc/wWSKN+Z/7iwgnq68yrCaELClYNgORMcTEzoHJIMq0Rf4uaPgWHmqTs3ammc= X-Received: by 2002:a81:6e87:0:b0:323:828:2175 with SMTP id j129-20020a816e87000000b0032308282175mr30324091ywc.71.1660159170067; Wed, 10 Aug 2022 12:19:30 -0700 (PDT) MIME-Version: 1.0 References: <20220808165006.2451180-1-bgeffon@google.com> <20220808165006.2451180-2-bgeffon@google.com> In-Reply-To: From: Brian Geffon Date: Wed, 10 Aug 2022 15:18:54 -0400 Message-ID: Subject: Re: [RFC PATCH 1/1] zram: Allow rw_page when page isn't written back. To: Sergey Senozhatsky Cc: Andrew Morton , Minchan Kim , Nitin Gupta , LKML , Suleiman Souhlal , linux-mm Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660159171; a=rsa-sha256; cv=none; b=pxMT2PogkIongx5380GSkhX/2ArqiZmm+I8lyDqNyfSmUK9Jc1iwrogEC8yQMqQK+/aYIW UgWBwZWJdcQPEjyluPnAU3ltoVYyTs7szk4C+7BRtc1UUOrndBdm0u0kji0wNSVk4NoH6O jpLF1oPQQV9dgRhEfi6UZ+Kqmk0KXeQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=nDGS9Ngr; spf=pass (imf26.hostedemail.com: domain of bgeffon@google.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=bgeffon@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660159171; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hKx1VWalS/Kw4WukWOwnOrv52qOFOeVZOoDS2/nyvSw=; b=Zr4kpEuOjFYeX/akeLUy2zrT32rcYwlSfLZ/2PxfERjNrhmpgr3taAwLJSzUqlJlHiO0c+ 9JFsYKQUcaBocNmgRb4pWn1S3xczneBd6FwXvzU7A1WK6XEzd8Tn8OoZYKMO1INhKYqPdh o+fAWZzcEEEsO2kyL71MLLdyZeHkUjw= X-Rspamd-Queue-Id: E78A614005B Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=nDGS9Ngr; spf=pass (imf26.hostedemail.com: domain of bgeffon@google.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=bgeffon@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: 8cqunuodspan5qwfjw6fsos6ur478x6o X-HE-Tag: 1660159170-271904 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks Sergey, On Mon, Aug 8, 2022 at 9:38 PM Sergey Senozhatsky wrote: > > On (22/08/08 12:50), Brian Geffon wrote: > [..] > > > > pr_info("setup backing device %s\n", file_name); > > @@ -722,7 +707,8 @@ static ssize_t writeback_store(struct device *dev, > > > > if (zram_test_flag(zram, index, ZRAM_WB) || > > zram_test_flag(zram, index, ZRAM_SAME) || > > - zram_test_flag(zram, index, ZRAM_UNDER_WB)) > > + zram_test_flag(zram, index, ZRAM_UNDER_WB) || > > + zram_test_flag(zram, index, ZRAM_NO_WB)) > > goto next; > > mark_idle() probably should also test ZRAM_NO_WB bit. While we definitely can add that check in mark_idle() it actually doesn't hurt to allow marking the page as idle as NO_WB only controls the writeback aspect and as long as the page is marked NO_WB it won't be written back, idle or not. Definitely happy to add it in later versions if people like this approach in general.