From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92DB9C38A2D for ; Tue, 25 Oct 2022 10:22:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2B8B8E0002; Tue, 25 Oct 2022 06:22:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDB728E0001; Tue, 25 Oct 2022 06:22:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA3888E0002; Tue, 25 Oct 2022 06:22:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A7B458E0001 for ; Tue, 25 Oct 2022 06:22:58 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7C2271A0174 for ; Tue, 25 Oct 2022 10:22:58 +0000 (UTC) X-FDA: 80059083636.15.24E4C2D Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf03.hostedemail.com (Postfix) with ESMTP id 1BDFC20003 for ; Tue, 25 Oct 2022 10:22:57 +0000 (UTC) Received: by mail-wr1-f42.google.com with SMTP id v1so19985607wrt.11 for ; Tue, 25 Oct 2022 03:22:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0y7iDQCensAtux3dcwN/gwY7QUae/GZDIlFm3Ei8Y2A=; b=gb01ow7fMtdcOsSJMFf9yQwB6aEFE1KHQuLXR4On+crZ/Tnwk6TxtFOtbAwtEuccmS NRR6lVnd6dPIHWBC6GU+1J64OO4PijHPGb1jULxScHraNbhMjsxvpM7YVB7zf3jgCnpN hz6VeoQY6Uz9AzSCXhNRZ1zoUKbAKAK7Iwieh0vWJhwiinEiFMZB3pxkRJjtjHkauFer fF3SReeIXGhF7y9+axeIvKsEVrFVx2Ojp5JNHQWPAJLCqGK9hrB73YzeLb3J8d+ih5Uw N7RRvmLFd3kjascKk080k8/bUjmQliXyeG63zH0t5ijr3mEzUYjQerQRzo3hMa8KGsH6 8mQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0y7iDQCensAtux3dcwN/gwY7QUae/GZDIlFm3Ei8Y2A=; b=kHa6aRVjEnZwIidKzGiikWiZKIgJCCZEKMkvtPRLmpjhS4gkTRn/KqBOkbl8SiTYs4 31JVWZPwOruBD84hj4grN9LXjf+01Ws3tRsK/YCz4yBrIcIly2BoMix6cIPRGskrvfbl HYGHIlwqGGOFHi1heic3paEK99oUMxbk9Iro+UsyeZnCTo8dZ9If9rSI79zynKZj1Dof Hooy528RlTloByb/C9xYosybKhVOFFY5nVMSpFOiSDQjsfa157W2psPaS9J5o24qXjQb bzQH6oSlwTJvIzAWU8LVQwb3KfHecph6dhSlOG8Fo9k7PLit4wqObqvBHZcyYb9K6Wuz v/lA== X-Gm-Message-State: ACrzQf1d4cPDVTJwFGgj/vtlzLSV27MIYoaGNcf1+57IJ6X2wuuQdl/A glW3f/prEKT0dspWzfca1UkHJIfRaIO9KhTYIsw= X-Google-Smtp-Source: AMsMyM6qWwwHEiDFs/RyxbmrHvG4DfXAV4EqSzWHktBtr9+zi38/uUyCJD98wpW3g7aV0Ck3czdOKlfDMNWoyOu4MyY= X-Received: by 2002:a05:6000:22f:b0:236:4f8e:a913 with SMTP id l15-20020a056000022f00b002364f8ea913mr15877728wrz.240.1666693376743; Tue, 25 Oct 2022 03:22:56 -0700 (PDT) MIME-Version: 1.0 References: <20220811161331.37055-1-peterx@redhat.com> <20220811161331.37055-5-peterx@redhat.com> <20221021160603.GA23307@u164.east.ru> In-Reply-To: From: Anatoly Pugachev Date: Tue, 25 Oct 2022 13:22:45 +0300 Message-ID: Subject: Re: dpkg fails on sparc64 (was: [PATCH v4 4/7] mm/thp: Carry over dirty bit when thp splits on pmd) To: Peter Xu Cc: David Miller , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , "Kirill A . Shutemov" , Alistair Popple , Andrea Arcangeli , Minchan Kim , Andrew Morton , David Hildenbrand , Andi Kleen , Nadav Amit , Huang Ying , Vlastimil Babka , sparclinux@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666693378; a=rsa-sha256; cv=none; b=ZdQQ6aTUm82AwR2ULXswxLSODaAzahj6H0f5EbbdTPeFZOJ/qjXrYNV5C1ay2IgH45quA1 U9Fse/IpugB/DM+1nz46SwUEQ3v3sR3qwqbEoV/3EjFLUMGbd1zB07KKT+zm/Oc/jlqvQg 3v1RzTFbFyxdTGivShqxCzcbk1VONVw= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gb01ow7f; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of matorola@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=matorola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666693378; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0y7iDQCensAtux3dcwN/gwY7QUae/GZDIlFm3Ei8Y2A=; b=uLMgFTbF9sahFotWjwgZiHZQ1KZ8KTSaiTaSJ6QqewvHeO4Df/8aeKoTy+UMbDKciW3m+H qMxPeNjz9frO+YvvdvYjtmkk0yq//v4lOsH+KFsZVnTA8zUJ3Je58I6W7sR5vSQMJhb9q1 7rePJi6nQtxUAg7tFyRFW5kUtc4rWb0= X-Rspamd-Queue-Id: 1BDFC20003 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gb01ow7f; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of matorola@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=matorola@gmail.com X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: hke1tkjjk4z74yj56mkthkk9mt5axk6i X-HE-Tag: 1666693377-986695 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 23, 2022 at 10:53 PM Peter Xu wrote: > On Fri, Oct 21, 2022 at 07:06:03PM +0300, Anatoly Pugachev wrote: > > > > Link: https://lkml.kernel.org/r/20220811161331.37055-5-peterx@redha= t.com > > > > So, v6.0-rc3-176-g0d206b5d2e0d) does not segfault dpkg, > > v6.0-rc3-177-g0ccf7f168e17 segfaults it on package install. > > > > dpkg test was (apt) install/remove some packages, segfaults only on ins= tall > > (not remove). > > > > Reverted 0ccf7f168e17bb7eb5a322397ba5a841f4fbaccb from top of v6.1-rc1 = and > > tried to compile kernel, but got error > > > > mm/huge_memory.c: In function =E2=80=98__split_huge_pmd_locked=E2=80=99= : > > mm/huge_memory.c:2129:17: error: =E2=80=98dirty=E2=80=99 undeclared (fi= rst use in this function) > > 2129 | dirty =3D is_migration_entry_dirty(entry); > > | ^~~~~ > > mm/huge_memory.c:2129:17: note: each undeclared identifier is reported = only once for each function it appears in > > make[2]: *** [scripts/Makefile.build:250: mm/huge_memory.o] Error 1 > > > > So can't test v6.1-rc1 with patch reverted... > > Sorry to know this, and thanks for the report and debugging. The revert > won't work because dirty variable is used in later patch for the swap pat= h > too. I've attached a partial (and minimum) revert, feel free to try. Peter, tested again with 6.1.0-rc2 already, non patched kernel segfaulting dpkg, using your patch makes dpkg (or kernel) to behave properly. Thanks! > I had a feeling that it's somehow related to the special impl of sparc64 > pte_mkdirty() where a kernel patching mechanism is used to share code > between sun4[uv]. I'd assume your machine is sun4v? As that's the one > that needs the patching, iiuc. kernel boot log reports ARCH: SUN4V