From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49826C433EF for ; Tue, 1 Feb 2022 10:03:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABFB56B017E; Tue, 1 Feb 2022 05:03:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A70796B0180; Tue, 1 Feb 2022 05:03:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95F2C6B0181; Tue, 1 Feb 2022 05:03:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id 8828F6B017E for ; Tue, 1 Feb 2022 05:03:00 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4843E96349 for ; Tue, 1 Feb 2022 10:03:00 +0000 (UTC) X-FDA: 79093772520.09.587A325 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf30.hostedemail.com (Postfix) with ESMTP id EDA208000C for ; Tue, 1 Feb 2022 10:02:59 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id ah7so52246429ejc.4 for ; Tue, 01 Feb 2022 02:02:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mClIZuGiU90N8/wVEGuz0kPrT8HDVsO1SF0mMBp9TKA=; b=m8l3iizy6m+bL/jBYQ1WY3ATqWzlyg2KTCyNULM3eVNvkC5wqKTucOmaIxZWFKKHKC O4vEtqtNwuq399PL5WPFG5Z7vCu6zPPjoimtCnr8vb/5lojlVqjvZJwxMJzVd0Vk35+r ZVAR+4L1KqtGJhgkD+zr3U76KGUGG1P7/BPweFRor+Y6JBV2yCS0CX+UFmYJA0lC10As KSMXOwfQMpM5C1cOo7NxFB454lv8KZ0AWzZzM/pxNJiKv31JpTcyWfsVCUPzCl573dFS WOqZrDF8DuO60afmvVeUg1FCdgzqdmHYIJrUyRb6laaV9nlyKLCU0X2qcosie45x9Rgc yezw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mClIZuGiU90N8/wVEGuz0kPrT8HDVsO1SF0mMBp9TKA=; b=rWwDkntCk7PNifssbcu9hCAAO4eAwoUKpf7zj6rotGCxfT1hRhxVcwDlfgB2Xfi3W2 ueuSmbezUZuwp4oe98sbrdQKg1LOLlpaOqy2Sx83McVs9rW6lp7CIwHpvQ29hmfT4YzK uIhT5GRpqE9mLxxYrq535flsxWU8hduGEPXBup9OegAxFF9dmcERNgsFYW7cV33oYNVw Mmq+Y7q+pLs5hffqtfyfYnXf3ihzoAKwf2KSgWrIoNaxzlYi7fo1fn40XRIuQISnUHWY k3at1zNflfj/rhQwkDorTKwgim7U/o+kCcRLNzWApGBzBnfUG/ooYABs3ixQL17x/KmC aZBA== X-Gm-Message-State: AOAM531EEHcqb+iiCmimAQqBXFX/6vC7RXv6MCcoqOqhkTchNyhlR5WW 4ywUYpcnvwTPYQhc4uSRSTwccArVoAs1r4zQPCc= X-Google-Smtp-Source: ABdhPJyfD5PfJ3o2DgbfikfmuisQ6IDuSCV1txCGADlAID79HMnZ8k2HT/445aAlBSn/3Hrxj9wDnw0NxNHNH60hLfE= X-Received: by 2002:a17:907:1c1c:: with SMTP id nc28mr20280513ejc.651.1643709778741; Tue, 01 Feb 2022 02:02:58 -0800 (PST) MIME-Version: 1.0 References: <20220128151540.164759-1-david@redhat.com> In-Reply-To: <20220128151540.164759-1-david@redhat.com> From: Anatoly Pugachev Date: Tue, 1 Feb 2022 13:02:45 +0300 Message-ID: Subject: Re: [PATCH RFC v1] drivers/base/node: consolidate node device subsystem initialization in node_dev_init() To: David Hildenbrand Cc: Linux Kernel list , linux-mm , Andrew Morton , Greg Kroah-Hartman , Michal Hocko , Oscar Salvador , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Yoshinori Sato , Rich Felker , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Rafael J. Wysocki" , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390 , linux-sh@vger.kernel.org, Sparc kernel list Content-Type: text/plain; charset="UTF-8" X-Rspam-User: nil X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EDA208000C X-Stat-Signature: q9a584ur59tqw1knr69qiirc7hhx1j45 Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=m8l3iizy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of matorola@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=matorola@gmail.com X-HE-Tag: 1643709779-238940 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 31, 2022 at 2:11 PM David Hildenbrand wrote: > > ... and call node_dev_init() after memory_dev_init() from driver_init(), > so before any of the existing arch/subsys calls. All online nodes should > be known at that point. > > This is in line with memory_dev_init(), which initializes the memory > device subsystem and creates all memory block devices. > > Similar to memory_dev_init(), panic() if anything goes wrong, we don't > want to continue with such basic initialization errors. > > The important part is that node_dev_init() gets called after > memory_dev_init() and after cpu_dev_init(), but before any of the > relevant archs call register_cpu() to register the new cpu device under > the node device. The latter should be the case for the current users > of topology_init(). > > RFC because I tested only on x86-64 and s390x, I think I cross-compiled all > applicable architectures except riscv and sparc. Compiled and boot tested on sparc. Tested-by: Anatoly Pugachev (sparc64)