Re: [PATCH] mm: cma: fix CMA aligned offset calculation

[Gregory Fong <gregory.0xf0@gmail.com>]

[removed stable from cc]

On Tue, Feb 24, 2015 at 11:55 AM, Danesh Petigara
<dpetigara@broadcom.com> wrote:
> diff --git a/mm/cma.c b/mm/cma.c
> index 75016fd..58f37bd 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -70,9 +70,13 @@ static unsigned long cma_bitmap_aligned_offset(struct cma *cma, int align_order)
>
>         if (align_order <= cma->order_per_bit)
>                 return 0;
> -       alignment = 1UL << (align_order - cma->order_per_bit);
> -       return ALIGN(cma->base_pfn, alignment) -
> -               (cma->base_pfn >> cma->order_per_bit);
> +
> +       /*
> +        * Find a PFN aligned to the specified order and return
> +        * an offset represented in order_per_bits.
> +        */
> +       return (ALIGN(cma->base_pfn, (1UL << align_order))
> +               - cma->base_pfn) >> cma->order_per_bit;

It was noticed that this doesn't remove the now-unused 'alignment'
variable, so I think Danesh is planning to submit an updated patch.

Best regards,
Gregory

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>