From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A1D0C61DA3 for ; Tue, 21 Feb 2023 16:17:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1458F6B0072; Tue, 21 Feb 2023 11:17:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F5DB6B0073; Tue, 21 Feb 2023 11:17:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFFD26B0074; Tue, 21 Feb 2023 11:17:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E14096B0072 for ; Tue, 21 Feb 2023 11:17:20 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B214980211 for ; Tue, 21 Feb 2023 16:17:20 +0000 (UTC) X-FDA: 80491803840.08.0DEFD57 Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com [209.85.222.50]) by imf24.hostedemail.com (Postfix) with ESMTP id CBD81180026 for ; Tue, 21 Feb 2023 16:17:18 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="OGU9x/cs"; spf=pass (imf24.hostedemail.com: domain of jthoughton@google.com designates 209.85.222.50 as permitted sender) smtp.mailfrom=jthoughton@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676996238; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rZd3kSfNGA1PHVCAPaBvCHlOyxSL9wfTIK5IbE0HRRI=; b=d9ZdKZmpzL99hd6gimqLz1JFuV+RciDUReeuCTvNIXpbmPWSzO6Na6tSTLwR5PWNHc/tM4 c4KP7GKkUmULnaj1ah49XekUBDU1xXlrx3QcZct/c6MWS3F9QUbeOdiuitc4Z0FMr8W+P1 isOMOrcKkVYLWKUFN7jxLRPC6kF3gKY= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="OGU9x/cs"; spf=pass (imf24.hostedemail.com: domain of jthoughton@google.com designates 209.85.222.50 as permitted sender) smtp.mailfrom=jthoughton@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676996238; a=rsa-sha256; cv=none; b=G7obHgh+umqfWkw3/7jqWW2ahotWz3NERna08hjSzegN9ePA4wVV452SYFBu2u//vO8m+5 mC1sZkWmAGgJ/4S64F16Bz5rMpnGiI3pH+H3/3KW0PkgDYNt4S+TRb6e0hst0KVA13Jfz6 ntBCgkycBMYjrTau/Z+CKF5m/GoaGPY= Received: by mail-ua1-f50.google.com with SMTP id f36so884489uae.6 for ; Tue, 21 Feb 2023 08:17:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1676996238; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rZd3kSfNGA1PHVCAPaBvCHlOyxSL9wfTIK5IbE0HRRI=; b=OGU9x/csY9RolGb9FqqDo1Mov8yqY4AD6vdB1wFGpnQAxqMB8/q3roetWUUCSXJ1Bh 4x11R7Ic9xznvrxj7jIg0qxp/gZkBy1z7kGwmEpXH85Ei/eWzMakSuJVpcRDQ1Ggj0we YsQfVS3dnCxwm/jQ0OYQIL9021IaFf4hIbMNfeYQi+31ixY/AILxPazuA5wJoJmR8j29 weQYzCjQuF2IDQpOIywBJD/NdO+lJZR2t1ThdN+arlm3dwsLr0OyncjSiEay+Y/kLrfl eLNS6O2RcLwEsH425VLI5EzLJlD4TF+8va9eP1dhoJKdk3bAOH+QlPbu0u4/x/wriEXS 00bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676996238; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rZd3kSfNGA1PHVCAPaBvCHlOyxSL9wfTIK5IbE0HRRI=; b=rDP0HUd3VS2zo4R0heTy77XXWo4XAwIDBoTp6cOCafH9ECl3p+Nlbnb0ltmDLySNpy +ofWHbZo31DDNS1cwIj+A8/JmjV3U+QrNlMd4vxcNOFQWaqK1txDMrV3iIwDXDMujPoE gCIUgvppgvDYLQLtO44jm0gLYIqbu79U+hP2L4umvhgmGrvm//nLC7cq6FVIPxXSKrTD M2mCC2R2Imwl/Y4oYnDVNQkh+8iv/kdOy887wLzGkySLgEvfMzhdd1rfthXm/o8O+N47 zt8WvMalFxcx7vMxQZLE9cZgmvhQJsr+5rkEkcjLWgRW9l4hHXq8j2SVUYBqQsjFhUXS eMUg== X-Gm-Message-State: AO0yUKV6+oFar948e9f1xuIm5KGCV9AdhU0dZqUCEgBGg4/SZQ37bqGm x9PwkWpBXUHuBYD3u2NoVv7PMI5Tshpbj+wLTv6zng== X-Google-Smtp-Source: AK7set/FTbhy2QinX1nfpt4pgKPaIOPugBCH8djx/8IFrfwqKhU7NQ30t+tWJLaoNQ72vVheI57wMf1yRD8ZVRDtBJ8= X-Received: by 2002:a05:6122:71b:b0:401:72fb:a212 with SMTP id 27-20020a056122071b00b0040172fba212mr1109772vki.27.1676996237794; Tue, 21 Feb 2023 08:17:17 -0800 (PST) MIME-Version: 1.0 References: <20230218002819.1486479-1-jthoughton@google.com> <20230218002819.1486479-9-jthoughton@google.com> In-Reply-To: From: James Houghton Date: Tue, 21 Feb 2023 08:16:41 -0800 Message-ID: Subject: Re: [PATCH v2 08/46] hugetlb: add HugeTLB HGM enablement helpers To: Mina Almasry Cc: Mike Kravetz , Muchun Song , Peter Xu , Andrew Morton , David Hildenbrand , David Rientjes , Axel Rasmussen , "Zach O'Keefe" , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Frank van der Linden , Jiaqi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CBD81180026 X-Rspam-User: X-Stat-Signature: it9rt147oxm1ptsyas8tsy7aai7a6bad X-HE-Tag: 1676996238-5056 X-HE-Meta: U2FsdGVkX19w1elvvOOOOflunFTVFnSozkZhi3lMfeOP3Sf2g6mBsuG6z0uWfvg9Ru5eevQDGd4rxNKMf7049pGGHUpdx2mAMVACyofpYjIwlWrfMzIhuQnVL6wcqcjeZjnjkIvn/OSaZZlyl2Tx1Tx1H6DIThXozpF+fdK9n2WGMX8KpLYB62OuEctKtrh+hB5WYK14DenN7oiAgIiIP97ojIx3xJLm1FnC7GuArdb1Ha3h0YMFtClycAnNEsQPBrjDElU32ww4oNl2eYhwMwTNq6pN1J+lrvnEhfk87QS02vngaRm2VavyJQk6sBPXFyb2/f4BNtBMrzTdHtxQEDfXYTBuFigs9ls1do3j8rwiPndaNawfxHAC9Yx0bpzoLkDCuk63zoq8fVIGT2F2/gaWyKVUtu1UBmXQ2YsxP92t6rmdIkrXBtLoDt7B27aoef2gFOICRXi16szYhQJ/KKmUm5G/VGtiaNZlEf2blMUuWTyPqUku7fZL+W2QWMKjcfumSVFe0rH10L4xhaT4Cg0PV9uMj36wwsEZzDEuuLoISxU4zWB9Pc9Su6BAOAY8E6i+/RGNPuJ7a1yjVrAkGyJwjrY0hHEfWZqF0R8gjJUw6Z/pPBPaek3S+HDt4BhxqooXKxnCWHfl7MkZCNrCjrlgll/0YS7zxchVCr5w46IvK/+VYb3gKLJ5V4fXuoJhwbLe2JHe5ZEbye88iIw9OvTT0tGxkT0345CuFprDiGECLpbJInC4YkTPwOMbv6oRu2Z0KIF6ODpQVe7hWM3aZxElwMyQrBhYsnUx29GzwATkt41NgtZCcpSGzgKZ/a3xFDbdhvAgSTS5dKhuoifqjgAVQsT47Wqgmh7rMNDx9aHTld0F651Jjn9Xn5VZZKla5QyLlFjQFJJ4q8UhgR7g8O1rucHG2l3AZUet4ztdxuzKjmUtGNMMyBPKOjdn7h/B8jCSa1xQF6mCcdv9ftp S8TJNp3Z jZunKgtms+y0A4dAuGAVk69imnAYXndJorVkuu5ycpg43CTaj/sIkOgOsCYuDa9MqlBBszvg5T08oMNmbNXwgCw91I5HmTlL5z2w3YclgCqI3zvPTxqlillYCkWaWUHOWrzkYN0zMoDBQ1zNgQXEgtllLPSFnoVftMdA4yAAphAUXK0a6+3bGQZWuVBanBwjueFdW9ZPux1RMOvnUWOmWZbNssJmFEr/5gVhNmGDyXMjsQK1dbLsJeDqbzcBtXMFRI/r4diTF38CAHng2lHfPlZ6rz5CeB/GRc/ILYkhwNQbGBgxgEOQ8ijABxw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 17, 2023 at 5:40 PM Mina Almasry wrote= : > > On Fri, Feb 17, 2023 at 4:28=E2=80=AFPM James Houghton wrote: > > > > hugetlb_hgm_eligible indicates that a VMA is eligible to have HGM > > explicitly enabled via MADV_SPLIT, and hugetlb_hgm_enabled indicates > > that HGM has been enabled. > > > > Signed-off-by: James Houghton > > Only nits: > Reviewed-by: Mina Almasry Thanks Mina. :) > > > > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > > index 7c977d234aba..efd2635a87f5 100644 > > --- a/include/linux/hugetlb.h > > +++ b/include/linux/hugetlb.h > > @@ -1211,6 +1211,20 @@ static inline void hugetlb_unregister_node(struc= t node *node) > > } > > #endif /* CONFIG_HUGETLB_PAGE */ > > > > +#ifdef CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING > > +bool hugetlb_hgm_enabled(struct vm_area_struct *vma); > > +bool hugetlb_hgm_eligible(struct vm_area_struct *vma); > > +#else > > +static inline bool hugetlb_hgm_enabled(struct vm_area_struct *vma) > > +{ > > + return false; > > +} > > +static inline bool hugetlb_hgm_eligible(struct vm_area_struct *vma) > > +{ > > + return false; > > +} > > +#endif > > + > > static inline spinlock_t *huge_pte_lock(struct hstate *h, > > struct mm_struct *mm, pte_t *pt= e) > > { > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > > index 6c008c9de80e..0576dcc98044 100644 > > --- a/mm/hugetlb.c > > +++ b/mm/hugetlb.c > > @@ -7004,6 +7004,10 @@ static bool pmd_sharing_possible(struct vm_area_= struct *vma) > > #ifdef CONFIG_USERFAULTFD > > if (uffd_disable_huge_pmd_share(vma)) > > return false; > > +#endif > > +#ifdef CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING > > + if (hugetlb_hgm_enabled(vma)) > > + return false; > > #endif > > /* > > * Only shared VMAs can share PMDs. > > @@ -7267,6 +7271,18 @@ __weak unsigned long hugetlb_mask_last_page(stru= ct hstate *h) > > > > #endif /* CONFIG_ARCH_WANT_GENERAL_HUGETLB */ > > > > +#ifdef CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING > > +bool hugetlb_hgm_eligible(struct vm_area_struct *vma) > > I think the other function you named pmd_sharing_possible(), I suggest > hugetlb_hgm_possible() for some consistency. Good idea. Will do. > > > +{ > > + /* All shared VMAs may have HGM. */ > > I think this is a redundant comment. Indeed. I'll change it to something like: "HGM is not supported for private mappings. Operations that apply to MAP_PRIVATE VMAs like hugetlb_wp haven't been updated to support high-granularity mappings." > > > + return vma && (vma->vm_flags & VM_MAYSHARE); > > +} > > +bool hugetlb_hgm_enabled(struct vm_area_struct *vma) > > +{ > > + return vma && (vma->vm_flags & VM_HUGETLB_HGM); > > +} > > +#endif /* CONFIG_HUGETLB_HIGH_GRANULARITY_MAPPING */ > > + > > /* > > * These functions are overwritable if your architecture needs its own > > * behavior. > > -- > > 2.39.2.637.g21b0678d19-goog > >