From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8AA7C4332F for ; Mon, 11 Dec 2023 19:02:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57EE96B01F3; Mon, 11 Dec 2023 14:02:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 52EA76B01F5; Mon, 11 Dec 2023 14:02:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41DC26B01F6; Mon, 11 Dec 2023 14:02:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3335C6B01F3 for ; Mon, 11 Dec 2023 14:02:18 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E62EF806D5 for ; Mon, 11 Dec 2023 19:02:17 +0000 (UTC) X-FDA: 81555457914.29.148F6B0 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf01.hostedemail.com (Postfix) with ESMTP id F37C640020 for ; Mon, 11 Dec 2023 19:02:15 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Q43KjJ4t; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of jthoughton@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=jthoughton@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702321336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3KbcZPb3ouJho6Kgt8unn6XTmhQsbLYfRLMQ3Ty9aJ8=; b=dpIEx5DMil2sJGoKHw2V9FvhJZ84K8lCnWjHBLTZmXdVbbJ7y9gZGHwfW/Vx3YiguFWQdO TlbSURVVlCMktLAn1Ez57Oq/bh25i/LpCHKlVM5vlYF69nAoLqaZkY3zKAzscAh5Iivvve BcGqU24kYkUc1uWQkDTBXNT1kHg8PdA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Q43KjJ4t; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf01.hostedemail.com: domain of jthoughton@google.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=jthoughton@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702321336; a=rsa-sha256; cv=none; b=aJSnkEhAfFHNA8qKUg1vebigXgi8aEgqOB+alL3Ya1hEgpA1cpelneCfXL/ts/wxr/Eook a1Q0Isk65I6/L1Fmo6hMOxgn3v4vO79kj5/1wVEdPtTvC+ZEs4uMoRt+O6hvtlfSD7tV3Y eYUOWCCACWX3GhrEOfKyGv8HxbzxLYs= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-425928c24easo60491cf.0 for ; Mon, 11 Dec 2023 11:02:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702321335; x=1702926135; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3KbcZPb3ouJho6Kgt8unn6XTmhQsbLYfRLMQ3Ty9aJ8=; b=Q43KjJ4tvi7nmE7j/1p++kBAn20aeU9VLHjLd460QBWH/NKWNzJaWn5LQ4dD5n8V0o TxlMzIxwn3dKOIMh3/MwWkaH97JYYfn3KapJImsc+6YKCG7nXmNvL5XOIa0AGV1IBsEn eOx3BSvgbu9NmpzNys5GKkLSztC30A4Wsj87EnJFDd/Jne9Yzae5fAVgGWUxvVWeBTug 7aI0E5jpro9zh6+A+HZyoTI2pqZUVqo9pM2mWmMfX0jKh5JpRDtO9n03LUxmxjx3ZOW0 Cn48sZfRhDjBP4OLDqpY+oLT9Uhb6ioHjkxzBBRL6Swz8zG9SXHpd17Hhb6aq1z4SfvO XG6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702321335; x=1702926135; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3KbcZPb3ouJho6Kgt8unn6XTmhQsbLYfRLMQ3Ty9aJ8=; b=QBWcMTXLLWQ2Jr5p664EBrKquCGyfIKBA1P1pVI/WzGBdWacwu8cIe1VBER9AtDQ5E 4QZHF1E48if3fqm4HYY+/m/QX0/Mft21GE8h6jE+kwLvf35+MmzsWWc8h3I5msS4Hswl vcNwVCZKDvzVohkIqBjc6O3R4abQwmmpAGdtN3F4N/DP2Lv7DNP+dA80r0h91CZRklvt N8cAGIo2wgyEszfoMeyRI1wy2sNyDp3nmYhL/QrOIxeVCqHYGpLEpRX9AYz0RiMKtC2B VK+aq5m81+LIwqY/qyqXDKma7eQfrv0Mjw7kHtyr/HX/tNWSG2Bh/ZUR3HSI+oNLW/Mc ombw== X-Gm-Message-State: AOJu0YxPk3nDiAFpwgUDMGXsXxtS37xHt/WNxRRkGxh9+OoxqXIS/niG eez7WVzdblpg+3sUAZzHCUp5i93ioX9srnbuedsONw== X-Google-Smtp-Source: AGHT+IFrfbj+eLMmkxLHWrqC5LctWxqWsndhpUQUdOAM30S9/QPHzDfQh81E3QDwDztHsUxuyk9EMgb9BvR0ULYp+nM= X-Received: by 2002:a05:622a:190c:b0:423:b6a1:2088 with SMTP id w12-20020a05622a190c00b00423b6a12088mr738239qtc.5.1702321334910; Mon, 11 Dec 2023 11:02:14 -0800 (PST) MIME-Version: 1.0 References: <20231204172646.2541916-1-jthoughton@google.com> <20231204172646.2541916-3-jthoughton@google.com> <20231211184236.GB26462@willie-the-truck> In-Reply-To: <20231211184236.GB26462@willie-the-truck> From: James Houghton Date: Mon, 11 Dec 2023 11:01:38 -0800 Message-ID: Subject: Re: [PATCH 2/2] arm64: mm: Always make sw-dirty PTEs hw-dirty in pte_modify To: Will Deacon Cc: Steve Capper , Andrew Morton , Mike Kravetz , Muchun Song , Anshuman Khandual , Catalin Marinas , Ryan Roberts , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: F37C640020 X-Stat-Signature: ny8sfcyhj4tw3s661cdb6c5igb6dghsj X-Rspam-User: X-HE-Tag: 1702321335-884042 X-HE-Meta: U2FsdGVkX18x47dVsENiSV7B769P9otiCxehYHLv62592bYlOhrLkfj3AjQhRiAFFxFaV+4uo27JQXNON11/2w+ojCxA138r+NBDtpzXaFXDsPB7TUUjCHD0dzHeI4F9hfbifMporfG7ajT5hTpI4e3X8o00NFckqO8pvyEbcZYczY7jEo7ZTho6ZYszYVUFnXqdF21jUsgRfjnrR2vrysf3Xf+CAB8iLFCbt0KFI2Furnct2rxAQXpGuKYUyRWIiEqdUbAbFDiYdvCY0KahLCt/PYNjEFfBVunTAuD8K3YTsWEs3yWroZ4h3vv0bjEU0ma6ZJsh2qwWmKdf7n2IuCCmuedhpblGxXCiJwmJepNRgujLt/j/spNl9kC1OL5ivpJ0QQ42xsO389ePH3uyTaJttxFm6Ckan86yM0BCsKQwM8RS01I22gFn4XwKBO0DxgooQcpYOMlh2JRBil0ryDZy3WS4Mg71nZGgPG8SQZUMrEDD9d4FkM9eoiCIbe49YxAxfWR3GzIjlDDRUNNiLUihwOL6UIjgur6W5w9GbM9Y9LtTSq627itM3Ir24tqtc/mQvOUB4fZdEF6yuP32n1SEGOjqqTbcwPTgH8DfQQTP/EUP8AgUtq5zicRsUj1vue11NyH3qRABzI37jHuGVRlpHZcVhAEVENk7Maz72GqGfiohnzA8eajvNFUJKtUkSdawbKZ6EyAGZN9zu5GVmLftDGb/9TJLtB2ybZfRvQKNHyTGc4qQDlLBAr1K9Sp1wOmi0tODcHuTN1q7HQHYjecElc+PdgPCvSui3+vWW5rHP23qKeN5Sqanudn72dKf6n494ei38tyPoJs5ax2lXPDZdHMvre+zHsuNWVsZ2iwTdomOPAySHGj0Htqg4NG3wDcLSqinu7UHORYUY0tRoGa8h9LifnznaBW+DXijY3uXnWT89PXs+E8r2QXZSkmutG1eZdm/JZVGZVJ1j/g /G02RV1h BfJZuqnMpJ5YjeZ6RA/swD/hsA0jKEGHH+LPVkpoQUOA6GYDjrc7oV6yP3b8J8qmnVQPMEIzbLxVMfX424L/NQ0r52rXinP74RQ3KCiDxdSlxRSY1A8NKI2WAECjGQ78yUmpEJAgsI1D7azEQ0J0GIIk0fB1f4MJP45kUeUjWwPPfriQzTP8Xk5Iqw/wjY5b7LxJF/3VxDJNsQ9tMP2LeQDN0XP3RvWWZAJat/JNFJ1gGSaS4IBi/xzpJwGuWMubgNEPu9M2uNZULNyg3TA3Mb7L/AUDh6V0nisRgAKyNEyKHQK5wSM28UWtb/VUN5qziQcCO4dg9uUuG3qFkbjdpEH0lb5x4fJKyAAiY1B83R5zdVMo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 11, 2023 at 10:42=E2=80=AFAM Will Deacon wrot= e: > > On Mon, Dec 04, 2023 at 05:26:46PM +0000, James Houghton wrote: > > Make it impossible to create a sw-dirty, hw-clean PTE with pte_modify. > > Such a PTE should be impossible to create, and there may be places that > > assume that pte_dirty() implies pte_hw_dirty(). > > > > Signed-off-by: James Houghton > > I'm not sure how, but you seem to be missing the '---' separator and the > diffstat here, so I suspect this might confuse tools such as b4 which try > to apply the patch directly. Thanks for pointing that out. Looks like it came from using `--summary` in git format-patch. :/ > > > diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/= pgtable.h > > index b19a8aee684c..79ce70fbb751 100644 > > --- a/arch/arm64/include/asm/pgtable.h > > +++ b/arch/arm64/include/asm/pgtable.h > > @@ -834,6 +834,12 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t= newprot) > > pte =3D set_pte_bit(pte, __pgprot(PTE_DIRTY)); > > > > pte_val(pte) =3D (pte_val(pte) & ~mask) | (pgprot_val(newprot) & = mask); > > + /* > > + * If we end up clearing hw dirtiness for a sw-dirty PTE, set har= dware > > + * dirtiness again. > > + */ > > + if (pte_sw_dirty(pte)) > > + pte =3D pte_mkdirty(pte); > > return pte; > > Looks like this is a fix for Catalin to pick up (patch #1 isn't necessary > afaict). If only this patch is taken, make sure to add cc:stable and the fixes tag from patch #1. Thank you!