From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AC73C2D0CD for ; Thu, 15 May 2025 23:51:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2918B6B0092; Thu, 15 May 2025 19:51:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23FD66B0093; Thu, 15 May 2025 19:51:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 130836B0095; Thu, 15 May 2025 19:51:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E86D76B0092 for ; Thu, 15 May 2025 19:51:24 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 678FF120271 for ; Thu, 15 May 2025 23:51:25 +0000 (UTC) X-FDA: 83446791330.27.993D42B Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by imf03.hostedemail.com (Postfix) with ESMTP id 87A9B20008 for ; Thu, 15 May 2025 23:51:23 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4A4mdytR; spf=pass (imf03.hostedemail.com: domain of jthoughton@google.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=jthoughton@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=4A4mdytR; spf=pass (imf03.hostedemail.com: domain of jthoughton@google.com designates 209.85.128.176 as permitted sender) smtp.mailfrom=jthoughton@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747353083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XPr3QgE6XopAJbneoL2gWRrUZHMd+L1uMUHvEpVxd34=; b=HF6UfRunFeVldRzClJ9N+VXlJKpD1Nw4pJ6raG5A1EpFgwx3c2tiLdLQ1NhPrQFdTKuxpj 0+e/JJG4Q67ZI0HdgM+wPBbdioCae9dif1IStahGgyGu8nxz35NSGLxQIbxVfdLzhy2HNu 563BiNoFCxMn6/DyFbYJPdSmn7c4ckI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747353083; a=rsa-sha256; cv=none; b=mDtiZ3Q88dBD950kSQukPMzTx/SNjgPsRnzIFIBdEyGUuZzQkhC54w0Ww309fGJfTVvJWz uQwo7YjAlzKj2qVaEKEAL4b5ebhhNQ+69IU2VJPRhQAgxWeuu9ZwM0084P/9N2iIYGOEJm A73dTAEc50zRMPwSArPGpwX6xN8GQqw= Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-70a32708b4eso11366097b3.3 for ; Thu, 15 May 2025 16:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747353082; x=1747957882; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XPr3QgE6XopAJbneoL2gWRrUZHMd+L1uMUHvEpVxd34=; b=4A4mdytRj9eou4IgnNJvu1Ry1UDqNnOIUMkfjcaSfmao6S0K/EzFLzrkPNnjS1oaEJ HQq5/BGiVIfazXRm/oDwguMxQySgP1rlEaVXGE3HIAJHa0sTBPDzOOuokm2pRXSWVL3Z iDhuzfaFRzLCtDhJZ70XLpsptZzjeO70aN/V+oSo9hIqSZH+FiOfpsRw6afNMF7iCt11 A1k9ES8Rh6jXvRELZ9+W+aJggzASKjyJmIjnbuKCQCNwO6A0crY5OmKCBw6vrPDCZw2U BqQ7YWBNZFBzp3l9C3MksFOWsVu75LcrUb42pxaBxHEZ6qbRQRJqaxWfRgDMReUA8Wqm MVvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747353082; x=1747957882; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XPr3QgE6XopAJbneoL2gWRrUZHMd+L1uMUHvEpVxd34=; b=HqHIulzCGCzk0eyei4UVIUnmD9eSG505bp3JpT8LpIAvOy1bC3qQ9sTi7XtDmflJBv BEdqowbJBTdj46U80MAMbEBhZ8f1wBvkXKeaQMbp1Vm13V7UL1vpE2kAxOZ/tURBlzfD MhpIieF1vyAacwa71La9slZG/7uOEBdcoTjuX/rNui4H/cZc8fDmvIdrI6tBa197mZ3c j1d35tAsU0HR7rPoHWlyoztFtxoMliq02u3kUKobrDxdh64h5nXAcFcP0VLsLJSFLtoo 6qSOjBEu2P63DUaYs1LhGsEnt6yBNw3rh3q7kHsK8/CMH/9VJeyFM7Ef9MMMXOTO/JCm IYuw== X-Forwarded-Encrypted: i=1; AJvYcCUfvp+LKNovGia/SBJK/GjxDuQiVLidc/VHXQjITfdNI43KEPvhkSdqV8rCQVa3oz/1IPHxbk8+rg==@kvack.org X-Gm-Message-State: AOJu0Yxu4BEvyYV/vKVujksL1c0kZijgcBDOMsUuaP0CkD1E7955XE5m 1sFDlXqoYCVw8qBCTy/16VcmQ4sEAbjEMBs+TpXdjX/QTSxYcpsf1JOuntrZMVprAgAxQGN0ZIa rXBnIexpnHzQgONAfh4rc1JRY+Uz6O2SHYSbni9ow07ZkcLHc52JFMVNM+YLJPA== X-Gm-Gg: ASbGncs+/x070coDm55gT/vBZGQdAUqrxyv4KiMq7WCv9tgM9lHUwZLF3yUg+02fNN5 a7ipXLcXPLAqNJ9z/uGtl9C/27smEkasO7fqjTOWj8J9khb6HGYtK1HHSeSvuBnP/FQn1J+E9mn kR31jx1BFfPE7QXG8Ahyo5DHTHkcKYb7fImqTFYGl9Str4nXgTrRCY6In87qi8PYOh8qC8CBVUS A== X-Google-Smtp-Source: AGHT+IFtFp+P9O4VK8Qg9OzC+jX855YZKb1zj5TbuTuZP6rzUXb2ZUvAPIYYnFVnT20lddtCCBfDaOJ6HpF0TmLVRBg= X-Received: by 2002:a05:690c:74c8:b0:709:32df:b41d with SMTP id 00721157ae682-70ca797c496mr28163037b3.8.1747353082130; Thu, 15 May 2025 16:51:22 -0700 (PDT) MIME-Version: 1.0 References: <20250513163438.3942405-1-tabba@google.com> <20250513163438.3942405-15-tabba@google.com> In-Reply-To: <20250513163438.3942405-15-tabba@google.com> From: James Houghton Date: Thu, 15 May 2025 16:50:45 -0700 X-Gm-Features: AX0GCFsvPupUGBEWmI9iLoV-X7DO-vyiE5FRi3DFqxSHp3h36n9H0MRG3xg22Hg Message-ID: Subject: Re: [PATCH v9 14/17] KVM: arm64: Enable mapping guest_memfd in arm64 To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 87A9B20008 X-Stat-Signature: rh71yh51ps1uktt3swdme5r1w315ruie X-Rspam-User: X-HE-Tag: 1747353083-345112 X-HE-Meta: U2FsdGVkX18KbzYgEP/bEqefY6V3km4AkfPL43rJng+8YUrfFnhWmvutTQg6tJ/McqCA1QiBluu4AV6PVBBZyVVulKoPIlOFKNHUO01zwKHFApKz2Z8hhctVayHlCSnsTwxQOI6unTLEWWFVFB3FEXB7lL+jxX9ReQGGolvjKsq/A/SpI+r1J2NZzKwHu+fRqQ3EF2rI5VxxEk/wlQZYzfdyEFaEcwDf8Sepq2vIgpIamVZaXrkhL+fZNOYq6u0k+RHSyzvyWnReqjXLEWUUySKNAljV/awS5J6yXoosJRVASsxAKKk+RE2EaHb06S4dUKXdqGB1S7Z+yj/L2p71MZ/7lOrpIVFq3h7hfFF09TfhX3CnAO/kbiaB8z601PnClq+J2JOlX57L7dm9kTAl12jXt0pVT+IbhBl0rm5NsK7/rDplh2gyw0x3o4cGYjrgB+dsNn7OLYGOyz2t1EZZuM+LoPoOR5ygrMhkXgvelo4evUTeMVrclREpJd7B3JvvH8IJOxJVH2KGT2j431kA7BUBDPDCXdERPma86oyf4dYz2TAejNShILyr9kr5LmmfCtYV+fjNi8oL/n9OX4yYaU4jZOlmw908icGb9BZgswYCRiuV/4EAmp0fLFfxuV3wIML4yrL8PMR/P3H2C9WQuKjrQvbOIf7trKzDsKTdh9zmCtXC9oeP/1RVopIV/Fc9KSEFBY4NJ21xrPGsQ9pgAmmDjNZ8AifpKkB6j3dyXWRIlueU0Ng5ZmcAaE1BETib7F2G6Q6xmw/Zxeee1Uyyq8VdQJBxfY7Lk0m2SH7RNYZNYo0Ahxs0ghavh2tlTg+YORPrKNG4Ol/fYr9kSqcXFp6NWjV1EhrWkqHt3U2vhQYY5WKouqwDqAjl7ekRHocigR52UfMeJhfbguYtTayKYniBTSoUhUc80gTdy7yEeRpnFAvvgsVWT1IG8yhVaWA0yXEFXQEoyAGzq0yjZkj iayaPCNd nbvzkncNCURG+Ri+bLfmhJzOEY8LvZmtLRnPpVNqzozIte2LrPlxamPU5eHhA/eCnph8ArrLCy3wiC84/qV5Q/xCuTlrcjRv5iGTk4oEUYE7Oga3wlhF87F0AHflRqkvIerAmpr7yZYWP5saZDndXwl3PJ0yNfjONXH/w20KLxdhlF+LKc3aAoMPUKXSBQBVaaCyMgiSDyACGfgOacAsLsbtdETaV8fEN5j6o+ObdKfMMcpHC4wtlPrNOos+7rUa/W/rjocdg5Ap1S6G8ZJELHcdOIPW3hI3Hg8j5EdQOnYWUcWN3EMLJCfWSssKJGnuv0KoUqoZBdYmFbB0clEJyOqfGaQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 13, 2025 at 9:35=E2=80=AFAM Fuad Tabba wrote= : > > Enable mapping guest_memfd in arm64. For now, it applies to all > VMs in arm64 that use guest_memfd. In the future, new VM types > can restrict this via kvm_arch_gmem_supports_shared_mem(). > > Signed-off-by: Fuad Tabba > --- > arch/arm64/include/asm/kvm_host.h | 10 ++++++++++ > arch/arm64/kvm/Kconfig | 1 + > 2 files changed, 11 insertions(+) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/k= vm_host.h > index 08ba91e6fb03..2514779f5131 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -1593,4 +1593,14 @@ static inline bool kvm_arch_has_irq_bypass(void) > return true; > } > > +static inline bool kvm_arch_supports_gmem(struct kvm *kvm) > +{ > + return IS_ENABLED(CONFIG_KVM_GMEM); > +} This is written as if it is okay for CONFIG_KVM_GMEM not to be enabled, but when disabling CONFIG_KVM_GMEM you will get an error for redefining kvm_arch_supports_gmem(). I think you either want to include: #define kvm_arch_supports_gmem kvm_arch_supports_gmem or just do something closer to what x86 does: #ifdef CONFIG_KVM_GMEM #define kvm_arch_supports_gmem(kvm) true #endif > + > +static inline bool kvm_arch_vm_supports_gmem_shared_mem(struct kvm *kvm) > +{ > + return IS_ENABLED(CONFIG_KVM_GMEM_SHARED_MEM); > +} And this applies here as well. #define kvm_arch_vm_supports_gmem_shared_mem kvm_arch_vm_supports_gmem_shared_mem or #ifdef CONFIG_KVM_GMEM #define kvm_arch_vm_supports_gmem_shared_mem(kvm) IS_ENABLED(CONFIG_KVM_GMEM_SHARED_MEM); #endif > + > #endif /* __ARM64_KVM_HOST_H__ */ > diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig > index 096e45acadb2..8c1e1964b46a 100644 > --- a/arch/arm64/kvm/Kconfig > +++ b/arch/arm64/kvm/Kconfig > @@ -38,6 +38,7 @@ menuconfig KVM > select HAVE_KVM_VCPU_RUN_PID_CHANGE > select SCHED_INFO > select GUEST_PERF_EVENTS if PERF_EVENTS > + select KVM_GMEM_SHARED_MEM This makes it impossible to see the error, but I think we should fix it anyway. :) > help > Support hosting virtualized guest machines. > > -- > 2.49.0.1045.g170613ef41-goog >