From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C56CF34C3 for ; Thu, 3 Oct 2024 20:06:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54FAC6B00B5; Thu, 3 Oct 2024 16:06:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 500A06B024C; Thu, 3 Oct 2024 16:06:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C9B46B012F; Thu, 3 Oct 2024 16:06:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1CB1D6B043E for ; Thu, 3 Oct 2024 16:06:08 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B7C371A0680 for ; Thu, 3 Oct 2024 20:06:07 +0000 (UTC) X-FDA: 82633372374.04.4299D36 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) by imf09.hostedemail.com (Postfix) with ESMTP id EEAC4140008 for ; Thu, 3 Oct 2024 20:06:05 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QCEDuvz5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of jthoughton@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=jthoughton@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727985823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iHzI9kibwBGfbX+u9LfgG392Bz0yBO/FrADznXjpfXo=; b=482WMsURAYlAsjmkxUTNCLYnoOfpqW6kdBNwMexUOQFxXLaMCfjsWlub8dByit1JfrlJTL 7ZmT8NY0zPWv/qsSDVnSrg4k8/xHh9r6Rtj2s3bZPsZ2c5kU9BW3/D0EDyoDxeLJnxtWbT 8ePQwBMmXxrJhe+g8YJPHDnVhomICHM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727985823; a=rsa-sha256; cv=none; b=IrbfTZRrDhbKMy09ojSEc6EFZRivS3dN+p68XPxUvbotCNhmiLjqUdeBrrxSfMKupVZaI6 KfdbQQiK50lyVimr9oWh+029f7FOfqEN23akAGVFI6kBopj8UjnRVCJGgnnOu09W+vW1TJ cUxnTzz3w0gifXsVr+ziszwdb8HItkw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=QCEDuvz5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of jthoughton@google.com designates 209.85.128.169 as permitted sender) smtp.mailfrom=jthoughton@google.com Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-6dbc5db8a31so11521657b3.1 for ; Thu, 03 Oct 2024 13:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727985965; x=1728590765; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iHzI9kibwBGfbX+u9LfgG392Bz0yBO/FrADznXjpfXo=; b=QCEDuvz5PLr4Dr8+SIWOngR8r60jifo1i7edN6LAm5e+JAbwKBz/UlxOd1EpTsbh/I ZqGhOsG+XeDY9Y3l6UUbbAKWjY3jOvpv39J3CsJ7U+umBlGFLh1kKSRfQM8qMN9RCQ/O zIJfoaMDRR801Iv/LKiiwBQgX8sCSkH+e4Dnf7xupMXn6fVN1NEoH/TjXXq3S/Vl8z75 Ryd3MILcnIKmHli06YfyfUnF0+Yy3l1ALOEGoInThjrRlTcL6w5iD5uYlUQa76Obng8u 65cqMwcXmb58wP0m5FrCrEpnCZlYQHsJpsC8JSKxibzb0E3SU9PfGjdAsEM83U8hgQNp ibLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727985965; x=1728590765; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iHzI9kibwBGfbX+u9LfgG392Bz0yBO/FrADznXjpfXo=; b=tIE3WWDH9lXA3AD129PzbY4bDuV0b2+p8xWazXw60/Aa+QwbqAEyaQZI3lXRmAQCDa QV6sP0RGdTxzouHI+GufA6QJV79yQw5A82KY0FRBDEsvMFyxKA9ueRwQTWGE3yGY3/HC sCtGo7HbQe+/Jfp4rdUBfcpUj/Qxc5Gg4r9Zj8KKYxfw0icTvAEgVVJ9qEpUUzC931Vl e/IEYnFS6n2/JMGuSIBXXvX83x7bBZCF84mwwl2PxsrayJVPn7YwG2gaPxptXVkvcSOy Zkl7Y6nEiV/umjalStYoaNw4sfQ7G6vUP3uLVts8venEdC4ulx8wadgexkAAZyONo7d4 HeVg== X-Forwarded-Encrypted: i=1; AJvYcCW1fpX9eB5ZKCPzNUZDqcm5QaOWLVoQa+Bx0IUzqJku8+E86ZFmmyCGZYI2UsLWefvqVSWNYZcDxw==@kvack.org X-Gm-Message-State: AOJu0Ywh8vQ6z8tH57FKmCI0Wq/58mQ8SmmX9jEwJ2rUHowy4PTIXbxi HdO1E8bc0MW0yunBdFUDvLkRi7oyFqRLbV8+3Bgi84/rS9/qinTz+sUw3z4YNqtEE90VLm7wBZb cXl4MEHPMp36nS+JC61sKx1Wjfleam1FkDNGl X-Google-Smtp-Source: AGHT+IESiGJnMtl1gZFqJRNktO5r59aOQQF1KKLqhp/PZ7O+Nz98cRWkE2b6UlCPgSskCbDZSVsRWB9LF8R5tSuAhAA= X-Received: by 2002:a05:690c:60c2:b0:63b:ba95:c8b3 with SMTP id 00721157ae682-6e2c7c16a00mr3687097b3.6.1727985964764; Thu, 03 Oct 2024 13:06:04 -0700 (PDT) MIME-Version: 1.0 References: <20240926013506.860253-1-jthoughton@google.com> <20240926013506.860253-5-jthoughton@google.com> In-Reply-To: <20240926013506.860253-5-jthoughton@google.com> From: James Houghton Date: Thu, 3 Oct 2024 13:05:28 -0700 Message-ID: Subject: Re: [PATCH v7 04/18] KVM: x86/mmu: Relax locking for kvm_test_age_gfn and kvm_age_gfn To: Sean Christopherson , Paolo Bonzini Cc: Andrew Morton , David Matlack , David Rientjes , Jason Gunthorpe , Jonathan Corbet , Marc Zyngier , Oliver Upton , Wei Xu , Yu Zhao , Axel Rasmussen , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: EEAC4140008 X-Stat-Signature: h8uxm81c4p8n69mxozaxhrf6ty3d8oeg X-Rspam-User: X-HE-Tag: 1727985965-934092 X-HE-Meta: U2FsdGVkX1/6Vf5udeYne6k0kIZQAnuZ36nMWXbyJFJN3iZovSeHtim2Cjkt4SjEWxH7dCGvu7x9v3HOk+vjw5tn19kvgnQfh0qz9o9EwVoSEBiu2gxiQ05QB8WJFZW/HMXHxUvRZj9gXCy2G9SoaKdP+d4S8XdMZ1CNdBcXME9hmppncd4rRV7Y6HDWTwWtdMzU9RL0uyLSLWclKI+PFgF76ilnw2XBVfXFHNTZJKmXRtixC2zyfSDvFBt0NJbVe27oxg+EIsEEd0dblrVuYmiwBkifZRJzR3lr3KlXfPbf7eJftK/nAIHQoe8UgQr1pLX6hAKLl+dRHgbkOqq4dhakzES0lNF4ZCj90XHC0XKUd0K5Ogg351U8lCIITUdgpUgUfMt0oogGdOIw0jZL922WBhcxr0yJ1p9qlMyCY6MnaQAv0GskM7Ru0KSzqE/O7MMwDnwT0Dfs10loxQkJXid2trtbpq9unpoCRgsZhiKoCN5Q9bq3AccZmlbarKBMEKD5O2IsMrKy4bkk+eyDfQAWNfL5Gv72Z8tlv8fCcHrUCIvwgZO1shkKPfLuvdhh5YqLYP979yTo6pJ8/2wfC/Tjgzvk/MvQDxtqAn65tsumD5yHdmc3G0r3gjvGa/bZhRZh+tWIN7CcBjPyAHCU14LABe1F49w0qXt1KQ55FptlEFhKz9pYJwH2H7TpMMMeOwG2SPY1FORM87ZD+xsqVfEhELhgp4Qtvn+E9bYQ5mi26RXAQ+L0DwmdivfNChwSifv3d+klq9g9MovFB7FT00lA0wrLvxoZ++4dHE1IKVwQmz8Xf/jLbklsAsYYDYu8nEemxfZ7S7DMa8WAjOc6hAmRo6ed0y66P+HO+6HTYlyjLycu6Vbas/XrhYyDS1V6+bZAKs6ii3pcwQoQkJ4uh76CUsBXw4uguix8dBf5oXwkQ/AJ7ehIhEqvnxneW1HcVwgtd0GrJm36UFmY/N+ jXYfhf2m YcA5nm1pBTNZfiBG2is7flGB9oVLlX5ZeG0zhwvd1GRv1cOV6E9jhoH2hiOP1mSSXTOXwerqyFhdyzndbwq1cVFVZobJaLJz2RmNkwj7BpLllhgfZqbSKwH0WtsP/5C77YI9r3NhYFPIJJwJLg/qf32Dia/PxP3iAV4w/IaRnyhGVB9AOwSuFEGyj8uXJER9HQB4eZ//+9MWwpgEiykzFaR/r5TqZHTF4Y+SHBGsjXpU61Nc/Ed10jSqf7rD/wdrYNXYSwAdVeelaQFc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001255, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 25, 2024 at 6:35=E2=80=AFPM James Houghton wrote: > @@ -70,8 +70,6 @@ static inline u64 kvm_tdp_mmu_write_spte(tdp_ptep_t spt= ep, u64 old_spte, > static inline u64 tdp_mmu_clear_spte_bits(tdp_ptep_t sptep, u64 old_spte= , > u64 mask, int level) > { > - atomic64_t *sptep_atomic; > - > if (kvm_tdp_mmu_spte_need_atomic_write(old_spte, level)) > return tdp_mmu_clear_spte_bits_atomic(sptep, mask); > This delete should have gone in the previous patch. Will be fixed in v8.