From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAE29C61DB3 for ; Thu, 12 Jan 2023 20:08:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 419428E0002; Thu, 12 Jan 2023 15:08:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C99C8E0001; Thu, 12 Jan 2023 15:08:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2438B8E0002; Thu, 12 Jan 2023 15:08:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1134E8E0001 for ; Thu, 12 Jan 2023 15:08:08 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CB924120DE7 for ; Thu, 12 Jan 2023 20:08:07 +0000 (UTC) X-FDA: 80347233414.18.9504C93 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf27.hostedemail.com (Postfix) with ESMTP id E438840017 for ; Thu, 12 Jan 2023 20:08:04 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=EHveCHrE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of jthoughton@google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=jthoughton@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673554086; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L+Y11wIGuYqM3WI5W/LJtU3EbjeOxgch9hg5fvLKprA=; b=4gNcY0nUTVAL54ApgE7WagcLOyL4M2zHZsNarfZXL6cLeag3U7e727ywhKH3O7iNzyW6Cf SEarpXgGwruOhG6nax8j8o4Zzzt8Xz2wae7hkQ+L5vZxGC6vv2ceebS+QOch4efLu51qYF 1UU7IFWxh8Vh/Bl8jwIYJqPHcs1QdnE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=EHveCHrE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of jthoughton@google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=jthoughton@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673554086; a=rsa-sha256; cv=none; b=YErvZwXBGq3hwpOl3p5XgURLuN3m3lEqSFJG4I9w2PYCnuvnIrejLhVa60/k+asXdoBvsM 5Mg0Z15nzjmC6B/YnEOt6X0K9I+iCZKtlccc9Xi+JJB+RYTJXAuTGvg+SuIT1E0ECdHWUw 7LjzNSAAfyq9Kf0zrAvJQhl1odol0AM= Received: by mail-wm1-f52.google.com with SMTP id g10so13973474wmo.1 for ; Thu, 12 Jan 2023 12:08:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L+Y11wIGuYqM3WI5W/LJtU3EbjeOxgch9hg5fvLKprA=; b=EHveCHrEQM6di4eSOYUn1btRpD7sMd94Bvi9ViJpKA7vkN9kosVxVrfw8UfaPKaW7p sAWGmoLAGpNUi6o4VBQiTkStcPlu/rQY7MrC44vezeiiwL9zYXiBU9yXSRMccAK39SIF 8WRGS7ztDz1uRJ77JocG4wUZC+91enLHst4i8QyGXVT2PzRvsiaaWcjVThWyB6x+H4ZN w2BDNvEf8mgti6WQQkDbxZLG8aG2rQyBDOHaV2rSIyngZ+9fEVfKMk85TLURuQldC2xN itKHuvGps12X8lmw72CziPs7BqcrgOCAuKejJsTAARdi9z7fUZV8n663jsPv7Zl6N92U ZwMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L+Y11wIGuYqM3WI5W/LJtU3EbjeOxgch9hg5fvLKprA=; b=ozGbqzSe9+YNDRoHvmEXrr5uL4VV9qpuaXZPWw6tWTlV9kbcPhKr3FscAzYZn73Y+J iiDhwvS9z7Zyc4avhbMyYojld1DmwpNtffYAvGLgMi2QT3ADp3nUQTHXxko6H+5pULxu YEHhp840g91OLTx2BGnBiuopyR5qv4ZTTlIW8+qEOK3aHNhYHNqumSKvx+1VBVKoFmQc Q1OG7KDu5Z34E8Cuhg22InIAE4XTyF1NCJ8dPg+3Pki7c1VGeeHtkcLHOra+UC4nLO+2 gYQd/wOxRSRiw2nDxKiSZTyMh9Eodr+rEIM/9PXxljM6bbdKsVBY4rQaxA/C4pqZpeNv g+/g== X-Gm-Message-State: AFqh2kpoHwQja5olVgM7mVz8V01p+dyKYbxwN59pyzkv2VC3RJFTTwEb AVY5pkdbUggHixEQcSZVB+Rfy0zRXIe4eXsRcnpp9g== X-Google-Smtp-Source: AMrXdXufgQGH2cEs5Qj5NeuGspAW8MOLszNSVJ+/Ep0+vTsrcrJhgZmp1AMKaWLGQUBrPsSiKKaJiEXHH9XRcZ/ywSM= X-Received: by 2002:a05:600c:4c22:b0:3cf:f2aa:3dc2 with SMTP id d34-20020a05600c4c2200b003cff2aa3dc2mr4165848wmp.175.1673554084644; Thu, 12 Jan 2023 12:08:04 -0800 (PST) MIME-Version: 1.0 References: <20230105101844.1893104-1-jthoughton@google.com> <20230105101844.1893104-40-jthoughton@google.com> In-Reply-To: <20230105101844.1893104-40-jthoughton@google.com> From: James Houghton Date: Thu, 12 Jan 2023 15:07:53 -0500 Message-ID: Subject: Re: [PATCH 39/46] hugetlb: x86: enable high-granularity mapping To: Mike Kravetz , Muchun Song , Peter Xu Cc: David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , "Zach O'Keefe" , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: E438840017 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: q1qupgzo3nsb476m78pg4gkrfjd643cz X-HE-Tag: 1673554084-68344 X-HE-Meta: U2FsdGVkX19Np+oH0YYFXBd+UvqAgAaQJFKwZWBK709PIuSIFyFHC5kmsqdN+UBdAzYfrvwg8hKk5SNzM4k1OBK90zpeK37c/3y80pNe2tfpjtZrcZFxGfKFwJeJJbKHaERSazHXdHKpf6IDhYlUPuDxZjdG2+aRvB70Wvc0G3sIsE9s55UBpGDIkJuMCzqUnGue1j2M/z/QeRoSPzANTDaxFjgGX8shi63DkuDU8RHmzRvKo31a3vN+moSzQzR8IhbdF4XRGutTZXyhjMPpSJ70VgJbG7em9CCfyb2ZsozjnKjh0bfj4HJ1Zdc+Pu5gguGJcIsouAgtPiYnglqhHwhz0ySS9qjYgZZ0X1n1EA4HDXzPv9B6Yg1NX6YyvyQBWtAbws6+/JvHfimQic7VUPrpwSrJf6fNxD2lNpDrH4OaxiEAieV0jv88NYxv09jCmKYxvcAWfAErIv9Fn6bCI5sIopjgUexp63F5hhPXeHCHbQj7kaoKCaPi6fyRQkGROkBOrmOwq7ylPk171taO0n2tPMGo4mzahJ7MaqfsiFdFfR/fKrBnbqlrzEjllxPN7Nlphz9hrAXoTG3grmSBUieghdVHefhF5RKsF5VNStyDE48XbeYtwGr0notrsPa5qwjExuBTuExferJglg/n8xLC32Lg3pBBiarSpRATkwoOJlvVTAKTcC7dPk6rYM9JWzs54WzGQ/NtqN6cLDrURIVRUeOTIrnzkZTA3cMB8bLWlxWUmzE+bI2vnJORRyR5BAXgGcWW2XOM8AvsXl/Q3g3Wn1Ij27mTLGiHu9aJaAJcEdcaqaUFb5puL4lObcvbUrANRJooGr13pzhoWbXD3wmRAno5UR+ukEGWnhQ4x4vKsbph4iJzyO4Ng0CfURFrzQZOwf3xajRY6paXaWqlP8eSz+HTVrFgUUqzr0k4ZGYnYQOt7AnIavgGGp0aapqb+SVma+T4/0iKgS2eOO1 yaEtQBTs E9IDlK+x5Jh6w1WM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 5, 2023 at 5:19 AM James Houghton wrote: > > Now that HGM is fully supported for GENERAL_HUGETLB, x86 can enable it. > The x86 KVM MMU already properly handles HugeTLB HGM pages (it does a > page table walk to determine which size to use in the second-stage page > table instead of, for example, checking vma_mmu_pagesize, like arm64 > does). > > We could also enable HugeTLB HGM for arm (32-bit) at this point, as it > also uses GENERAL_HUGETLB and I don't see anything else that is needed > for it. However, I haven't tested on arm at all, so I won't enable it. Given that we are using a high bit for VM_HUGETLB_HGM, we can only support 64-bit architectures. Userfaultfd minor faults is limited to 64-bit architectures for the same reason: VM_UFFD_MINOR uses a bit. > > Signed-off-by: James Houghton > --- > arch/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 3604074a878b..3d08cd45549c 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -126,6 +126,7 @@ config X86 > select ARCH_WANT_GENERAL_HUGETLB > select ARCH_WANT_HUGE_PMD_SHARE > select ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP if X86_64 > + select ARCH_WANT_HUGETLB_HIGH_GRANULARITY_MAPPING This needs `if X86_64` at the end. Will be corrected for v2. > select ARCH_WANT_LD_ORPHAN_WARN > select ARCH_WANTS_THP_SWAP if X86_64 > select ARCH_HAS_PARANOID_L1D_FLUSH > -- > 2.39.0.314.g84b9a713c41-goog >