From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5C5DC25B75 for ; Thu, 30 May 2024 03:28:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57C6C6B009C; Wed, 29 May 2024 23:28:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52D246B009D; Wed, 29 May 2024 23:28:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CE656B009E; Wed, 29 May 2024 23:28:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1D8CA6B009C for ; Wed, 29 May 2024 23:28:25 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B9952C096D for ; Thu, 30 May 2024 03:28:24 +0000 (UTC) X-FDA: 82173629328.22.3C10FA5 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by imf19.hostedemail.com (Postfix) with ESMTP id 006F31A0017 for ; Thu, 30 May 2024 03:28:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3B23piV4; spf=pass (imf19.hostedemail.com: domain of jthoughton@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=jthoughton@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717039703; a=rsa-sha256; cv=none; b=rHsTt0aWMvbSiW0K9AdZ/QbWs8WDQXe+xNAjgNQ2EV4L5ztrQjDn4Bz+Q87/7wOps2MhbJ gJkm9TxF9t2VZYUDkdywdlPr4hO9XghcBHuPHNmAOXgUxxmqS+wYw1sxduO7LSIGhTdPtM 6rIjofFugXsFzMY7V2BxDVHQQZ7m7pk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3B23piV4; spf=pass (imf19.hostedemail.com: domain of jthoughton@google.com designates 209.85.160.177 as permitted sender) smtp.mailfrom=jthoughton@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717039703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CyFUQdvGKe8UpOcfXmkz33OD4v6xcNcft6Wk6HjbLrw=; b=P+bAQ6N7rjlWdM7BLZ2C4Wqt22Q7i9jg8Ej4qi4ytSKeBU0SuqTushvjikLnBw8dOOyWIi BMWZUeLSrkDgdkV8PedHSZc69QKPQnxWsqa8G+GtHmJ/mMeXsSOUQd3KfL9C0/GhfG1lMK rZGRadPHjjYZJ3Ed5G4pLbH6m2kv6JQ= Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-43dfe020675so187391cf.0 for ; Wed, 29 May 2024 20:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717039702; x=1717644502; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CyFUQdvGKe8UpOcfXmkz33OD4v6xcNcft6Wk6HjbLrw=; b=3B23piV4JLkQDntMggVTTPAzdLxQ00T6dyXruxdymcE79iy9ZL9k+zu7NWzCIoyFYZ MvqBEAQVHkrcNGExeuirv3RVfHx7Dy9w29ZZQpSHHt2HuZMJYHS4b1og5YwXIyReE7n6 HfU2SikbGfPg9vqtdmt+OVxkgIZnne3zacLMVKjleqFc3jUoK7VC0iAb4uEu82HrP6cl MJVm8rXkcADKd4ZuoHvkL4fdlq31sBB9MfzPm3nefZixOtkySfRQjxW6PIwYCOP8UQa6 HsVsTk775Q457djD3QYqYgsfAnXE1yXU5UlM7mvD+Reg/FHrWi2484s2OGq2rKvBTFVG 79jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717039702; x=1717644502; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CyFUQdvGKe8UpOcfXmkz33OD4v6xcNcft6Wk6HjbLrw=; b=lYwdegVUXoGOghVSxfz3mEoEZ6e7TPZqyf9i0In2aHyEeORmVQRNE82U+VyuKyCGpx lUwV/HstjloZod0Jh1CRkD1FEaWM3u4kOO5M1y/7P3FmUbxK+6qf0YJq341rUyj8hTG1 IKC6hXAaj6xyv4zk7IY2I08XuQ3jbYkF2zfK3ZtWBL8pKMy2uxmDKnzk1w2QTKTWHvq9 BS/FZqYkHTaXTjR/B3tGS+VNs0kEJQaLIO6lN1HnF0oi908LO/816zDQkZ1nHzrByzFl pywYYv5X1+4AyCD/t4GAinjjeLSmbfvwIEtl1fMNTe68CGLj46LPS8a7CPNMH6ndsZBw 2Mhw== X-Forwarded-Encrypted: i=1; AJvYcCWIch02kCfYKKSjkBwZGozsiVnGwArqmrub0lw6W6l9JICZIOdobOsg0tex8E8v7Ps+6yHeIBtqgsccNnqOERPJsV8= X-Gm-Message-State: AOJu0Yx5vRzTl7tiwMQGAV126kH3CQQu7ZT621xP58dZ2rUOapsMkOVv R93MbuQztOkD8PaQqs7qq3meeYKI867wH0i82rzqJ4Kjq/hZVsmcm7DWsaiaztWqVYDMOp7WtRh 6+5+FapI3Ef2jlI58mOSquSiotY90x26Dpxok X-Google-Smtp-Source: AGHT+IGBhNbFRaaD0WOEIsVSMflxCvd13kkSSK1hcGeX1B4TzLlXvTq7xC3rTsBmGx8uhqPHEIa2GYmfEXsD+JkYxAs= X-Received: by 2002:a05:622a:90e:b0:43e:cb4:1d10 with SMTP id d75a77b69052e-43fe8e5f830mr1851431cf.14.1717039701993; Wed, 29 May 2024 20:28:21 -0700 (PDT) MIME-Version: 1.0 References: <20240529180510.2295118-1-jthoughton@google.com> <20240529180510.2295118-5-jthoughton@google.com> In-Reply-To: From: James Houghton Date: Wed, 29 May 2024 20:27:45 -0700 Message-ID: Subject: Re: [PATCH v4 4/7] KVM: Move MMU lock acquisition for test/clear_young to architecture To: Sean Christopherson Cc: Andrew Morton , Paolo Bonzini , Albert Ou , Ankit Agrawal , Anup Patel , Atish Patra , Axel Rasmussen , Bibo Mao , Catalin Marinas , David Matlack , David Rientjes , Huacai Chen , James Morse , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Oliver Upton , Palmer Dabbelt , Paul Walmsley , Raghavendra Rao Ananta , Ryan Roberts , Shaoqin Huang , Shuah Khan , Suzuki K Poulose , Tianrui Zhao , Will Deacon , Yu Zhao , Zenghui Yu , kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 006F31A0017 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: 3mrypzxuusjkqiknfkiebz4pyd8xnnoz X-HE-Tag: 1717039702-781275 X-HE-Meta: U2FsdGVkX19+Ws4URBxIzHEsD8aYJCbx9szk8QPV5m54wv/GqBMngTJudO1RSgUoHhlZ0DOG91Ukra1uOFwo9LJmZY042VPaTRC5IWkYnDZN00N5NDf04CAP6D9O6GlV61eggYy8dfJmTNUSCzbLvabD+0Y9DbehUAPj0Ibjri/uAfeJtGowRoIuTUEtw/GhY+R6szKZmWF8QB6gaqVBD4oTi91Z6K3dj4zXfBMJV7PyRfrYQu2Xz7KwzlhirPDIqpYsxkweN0e17vxKoOTp99tla51HxDLmF2yaFWhcCVQNRHkYmfLB61FNm6P5W1iqBbGQQn6eSlYxVkOHBdNTz+cy2kc/FU2zmUjQ6MHgnf17eWaGFdH6Hcsf2VmCftevCZIRBSn+PvDfHvH+5k8asO0AD6lKknJOG6Gi1q5pmZkUHZcVJvkssIlADsm/bI0UfyzqiMACGqCJ1pVRBQmpO0Y3uZlqwozIBRLjAqKDIhGlA7f5jk7fz/AW9ScpcT/bkPSsHb5LaLFQRIAKN0Viha2mPhbjphO/j1tYxrmEhzMU44EUbph2+KoWcbpeCDCIbxvPGyD+0TgpZfjjbwdD8y2oqKVfQ3IxD4vEvOZhVDE1JDYxWJRGl1p4bEcU1dAlokn+yb6RogKi+HHo1eI137/TEBdQCHbxHCqTYm61PDzProH7+hYfRy4x/nGWAi/2jASgmHmt5b2R+C4tmcC+72z5ocFsbA76uweikW8BQAJ0n4/zMv8zpLU9r2XLT1jcpQtBdL6Ls6JQ7Te8UrJCisffToRTlbRvwkl7XYWc+vO4PF+ZmxMqEpP0LRoge5wM//cEJE6U0qyr4FWwDz2YnRBZZoBre0inh0iSxdQUl0iMVNewdIayU2eyWRQKSoLGVjlMwNnz8zfPdh7Im19/iCQBFS1JciIF/O/qTfvwxVYtDMdu1APnw3mwZolZZp9V5TMa0EakgJtIDMAKKZd w5fgDgye wCGtY4ppNRIopJci5Od4Y6kHACe2QGZhqFcbOOgEt0cID/TaDyxqp7/YjzDRfFQUrohHDprLTPA1gNcQBByL6cWixee053rzKPeiVQfRxqvv50mJlkjcHTQs/rMhAKzv/WhX23iwQXidkBw7g2J0lMj1ulDM7zigmsvq5bJR+nDXG01hctNFKc81/mFjLjLa13l8DiCfPo4J1vt2kpn3Y1m+E8ZpRcfm11jqa1U3nF0HMm5XYBkJbRM26oz3gPqzH6EH1357gpiAtALDmvPOPnWwHVoY42pv7DAiCjYALBljXJ60= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 29, 2024 at 2:55=E2=80=AFPM Sean Christopherson wrote: > > On Wed, May 29, 2024, James Houghton wrote: > > For implementation mmu_notifier_{test,clear}_young, the KVM memslot > > walker used to take the MMU lock for us. Now make the architectures > > take it themselves. > > Hmm, *forcing* architectures to take mmu_lock is a step backwards. Rathe= r than > add all of this churn, what about adding CONFIG_KVM_MMU_NOTIFIER_LOCKLESS= , e.g. > > static __always_inline int kvm_handle_hva_range_no_flush(struct mmu_notif= ier *mn, > unsigned long st= art, > unsigned long en= d, > gfn_handler_t ha= ndler) > { > struct kvm *kvm =3D mmu_notifier_to_kvm(mn); > const struct kvm_mmu_notifier_range range =3D { > .start =3D start, > .end =3D end, > .handler =3D handler, > .on_lock =3D (void *)kvm_null_fn, > .flush_on_ret =3D false, > .may_block =3D false, > .lockless =3D IS_ENABLED(CONFIG_KVM_MMU_NOTIFIER_LO= CKLESS), > }; > > return __kvm_handle_hva_range(kvm, &range).ret; > } Thanks Sean, yes this is a lot better. I will do this for v5.