From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CCF9C46467 for ; Tue, 10 Jan 2023 20:04:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D4188E0002; Tue, 10 Jan 2023 15:04:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 583DF8E0001; Tue, 10 Jan 2023 15:04:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4730C8E0002; Tue, 10 Jan 2023 15:04:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 376AA8E0001 for ; Tue, 10 Jan 2023 15:04:29 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1AEC1C0528 for ; Tue, 10 Jan 2023 20:04:29 +0000 (UTC) X-FDA: 80339966658.28.02D8BF3 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf10.hostedemail.com (Postfix) with ESMTP id 8C81CC001C for ; Tue, 10 Jan 2023 20:04:27 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AtVGs7t9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of jthoughton@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=jthoughton@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673381067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MZNu5ozoSkh9uaJy1rfaWNQva2WecGGGMzIGliOy9aw=; b=BDs6ynTzM+pdMUGEZ8FmUb/iFKAwv4y9U9BllwuuFWUUJAOw8fht4P0uwpfztUTXPHVWRk zNtt2prw7qxSte7Y3VnWihbe2vF5/ERyo/m5WoXST8gq72UUlW/kyrYuVJYL6eLeKsJ3Uo V4MdFE2riw5PkkTGqdDts21QPqHhwaA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AtVGs7t9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of jthoughton@google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=jthoughton@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673381067; a=rsa-sha256; cv=none; b=7YX8rqalJ3QFvSJRS+TSH2JuCbA4/B80Yhw2QFIUVW6muuTYJ4ndP3BcQXhomLwqG0OIZo MigNVS9rEz9MLHqwyjgwJRDW54XjgxI/6Fe52q5XH+h03KD/ZL3VTIyI0/sTq0CsvNqvU7 Fieoz1AOXBhDs/Xf80K4/O3NdvuG614= Received: by mail-wm1-f45.google.com with SMTP id i17-20020a05600c355100b003d99434b1cfso10997721wmq.1 for ; Tue, 10 Jan 2023 12:04:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MZNu5ozoSkh9uaJy1rfaWNQva2WecGGGMzIGliOy9aw=; b=AtVGs7t94tt98lfoWaSqFUJM+BbUEtKQ95BgkTfG6RraLysou76hFgvezW1wb+W66Y 2q94GiON/1+VLFt5Ucy1xIhHpZaNf3aItEgLODdPtPcfLofEogIuIWLoYydriBuxomUJ 4rZR0vr1rrYMDJL+nqIrHfe6tkY+K+lGQCeyNNYGRFHMvw0RHjqOhlXWqp+KAgva7exZ NfZyk4cN6XViIYwv5yCL6IKaU3nxya0qep4pct6K2MYRJjJtXmqRkg9PBetvcjLdHQN0 TiEySTtaP5r5ENkIecNfuudw2j/AIZmwbKvRzcHAshtfHLwFYoKnbZ00G/yelVISKxYI WruQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MZNu5ozoSkh9uaJy1rfaWNQva2WecGGGMzIGliOy9aw=; b=jAUi18cCVFNKN0fM51VoDNflZkDHgXKgzOxKw2MCwTGidsRXkjsC2SYsCbF6xzhaMm Gd/mVz3+RZMFRc4/ckifFRt8qDSnU1qP5lLB81rk97/VntlYGz7tMeu+AU0Sqe4f9lgZ 7hTiaH+gElzWlEacnnQydSanXfp7lySRlLN+jCtI/WeSwd9H5EUR3ti8krcIM/9mDisI xenmsfyJEQ7ZzJNraPl24g34N3eN/PzLMxm3kNwwEGSHAdN15eM7Z/44SR4tUAUDD13U J0qn+qi9WMQwvWlSORZTLhG2XcY+1lk0Mf5ftFS9Qgf2x6QCeI+wUEu/D1IiPCHEALxi lUlQ== X-Gm-Message-State: AFqh2krsLUkZY+iVXp+YV8TCl8lJJvQMCTLp2CXJd6xn215ZgkJhcAcb xHO17MIv1FGr8A1Z7xk1xcbI75x0WukTzEYpyG7p3w== X-Google-Smtp-Source: AMrXdXutExl6Q6Pj0nBYDjwAyRPBg7aoUlg/eFqKQAK0/No8r0/Ksxekc0V+GE5rahAJnxijatuxVZzeVzWGKRbkHLA= X-Received: by 2002:a05:600c:434c:b0:3d0:7d89:227e with SMTP id r12-20020a05600c434c00b003d07d89227emr3619525wme.166.1673381066034; Tue, 10 Jan 2023 12:04:26 -0800 (PST) MIME-Version: 1.0 References: <20230105101844.1893104-1-jthoughton@google.com> <20230105101844.1893104-36-jthoughton@google.com> In-Reply-To: <20230105101844.1893104-36-jthoughton@google.com> From: James Houghton Date: Tue, 10 Jan 2023 15:04:14 -0500 Message-ID: Subject: Re: [PATCH 35/46] hugetlb: add MADV_COLLAPSE for hugetlb To: Mike Kravetz , Muchun Song , Peter Xu Cc: David Hildenbrand , David Rientjes , Axel Rasmussen , Mina Almasry , "Zach O'Keefe" , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 8C81CC001C X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: uzbkxzbs77srxs9cakk5hckjpruxtbdo X-HE-Tag: 1673381067-469513 X-HE-Meta: U2FsdGVkX1/hJsuEscBZmso8j523mkfoDZWR0jmOS4NMxTiW3oPZF3wPTOpTdcXo/zY4xe9r88jpMWcOQPilLMHdbIkq94jCWBZEpywbY2UakDR2ZzYDzd2z9hfMASbQVdlShLAs43D9LE90ntgi+FV2lljYZBKZCXS/7rop5E16q/P73miYsjYauEY42AmJZ6IgX0PhDutj8DM5kbJE2Yd4eRPce96Oa+MDne957+NaitwEHKimlIjsVKsa5jHetVannA+nrg+d0DpxLSMYXkHFQr4WQZwNXn336pq+12vcxeY3w5YPfdthzpKdyVeUTeck+gxWSRaqAe91tfrUxdDzPkoXALmcFIayTiDi/ejsWVbmOUGeDgsyQi5HP87DHSaG1y6H06ydTQbL2KgJE7fhUc28Rc+SMsl+e1/QWK9vETp5t7BP3MO6iZxqosPPPp5OIHK1XZHPgc2aRKwGK64pMgiz3RLkCole5nxSmCvQd5ot2LfuHCQaE16VC5aGpNvDPi8w89sDpHy2rLD0/eXoQ66nun3uFhbAAYu5ajXK7nIWhZMxdUKC34t2CbFiGoW9tQI60mPE+IRvs5XdRvv9wL0N5IvZ1r9hgXvesgGhYDP9e5AVaqLMS1bLnMWkuS8s1+qxeBt/riyUGdIwwmf7kh1v7PcWgBWP9uTsHhriONn3KOplFugPhDStx4CbSwXGUeaYGNkEWSKvjRzOKrD5OZLuCKM5SK1otj36xoOwYDAI/XJoa5SAgR/+grozYxf1mvFYlbsBSZpKxQooZLKDIgUfwmCvhDySkNk9xD92RbPEEzjCJhWpGItia2M7YUgzKzhz+x/fAZjPJ/yMrJv+F8M2OIjinijx1jpOlJ+/RmqCr0kY9JE8pOp3Ak/iH4PdF1FcTHwqNEcZeKgj3S8VAoiH+gI48uaJhRj8g+N/MjNA0yFczqyjBGXKVTWGTN+Z0d1YjI9Sxbv/knh cEdX2lp7 BfHhja7vl6S9h6knVYpTwvPZVX0/CpjEsNc0aU5KGdiEEznd5k+q6HSzWKg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > + > + if (curr < end) { > + /* Don't hold the VMA lock for too long. */ > + hugetlb_vma_unlock_write(vma); > + cond_resched(); > + hugetlb_vma_lock_write(vma); I need to drop/reacquire the mapping lock here too (missed this when I added the bits to grab the mapping lock in this function).