From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C85EFC61DA4 for ; Wed, 22 Feb 2023 22:52:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 44AF76B0073; Wed, 22 Feb 2023 17:52:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FAEF6B0075; Wed, 22 Feb 2023 17:52:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C2946B0078; Wed, 22 Feb 2023 17:52:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1CEE76B0073 for ; Wed, 22 Feb 2023 17:52:57 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D12FC40B46 for ; Wed, 22 Feb 2023 22:52:56 +0000 (UTC) X-FDA: 80496429552.22.9ECA722 Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) by imf21.hostedemail.com (Postfix) with ESMTP id 286581C001E for ; Wed, 22 Feb 2023 22:52:54 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rEKc7nSX; spf=pass (imf21.hostedemail.com: domain of jthoughton@google.com designates 209.85.217.48 as permitted sender) smtp.mailfrom=jthoughton@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677106375; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t1YrXJq3WaEAkWelELqkrlZlV6sQWbkUh+zymDC/FcM=; b=RHxlmuv1ybiQt0/GQB/yZ8SvrypaNX4RdoiRMMj0axPaFvVXGYPHwaoAimQe+pmNEYbzC/ wHtckpV6im39GCCeNkykOwaV1O73xNePgM9jNijmUqj5aM0pqiWV1RvsO8tG+gjs/iRBK+ Xai1b3Gam2/2QCLXC8yX0fm35IzoM4A= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=rEKc7nSX; spf=pass (imf21.hostedemail.com: domain of jthoughton@google.com designates 209.85.217.48 as permitted sender) smtp.mailfrom=jthoughton@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677106375; a=rsa-sha256; cv=none; b=jbukJm4FgBQNsuxwvliJULbnCCu4wvyzDcTRX7NE486PnDpvFEn3+nSDUxf9wdrme6rYRH OhKiJ8fjyl8sQri23lkNPOMnLz3gYWdLoTrcJtdFdOFnKb4QZ3BPq1dhGgdSGnnVa8Y83y /d1grfd9YwD8mwUccN49v/Fc5TH6gQI= Received: by mail-vs1-f48.google.com with SMTP id g12so13701303vsf.12 for ; Wed, 22 Feb 2023 14:52:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677106374; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=t1YrXJq3WaEAkWelELqkrlZlV6sQWbkUh+zymDC/FcM=; b=rEKc7nSXJ3OCotja2EJ8iZ0vwqpwYZFE1hganHW1XfmrR17hL8FI5+sThMcWr9rtky YThFCVTiz0NM0ILLp4nenJvTzFcJ170nbuB1mm8ht2JGg84dRARUCCamwoVxn1J6pOJ9 g9v7VracNz4uONU+W6BMJgXZKZJ/ZJnlUEkBQLYOEJpTK6tue32FD+KtpJkWuH65VxDh +lcSuIF6qmWEXqw7uQwc7lHJekp27CXvzIn9BFmLMnObC4M2TNk0IeoOn+kZ4Jfk4SQu dftK5GV+jQdzTV7LWe6jHjwyqrr3M3a0+PZij+d9eT8BtOgNzjsdIHPH1w2Ha9uWgrPZ W+ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677106374; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t1YrXJq3WaEAkWelELqkrlZlV6sQWbkUh+zymDC/FcM=; b=7GGI4/JyE8dKIKzuy2XySRZtZCOXwyG6q/iBu0CB2TpyORnSkbjPQdVOq+8B60YCjs pKMFFJFk3sh5w7ND8nv6C4n6AZu1sImhdFdX0nYNLSm7IrlYCtVK+G7B045SkPiW4s5P GmpVX/KgTntCfnFyYSj/wbe5gABVJaW6M2GzS8mbCQuRriF7ivz32tg39SpkY5u3J65x xGa8wGr7B8Z6itnbPu4UQ/8lwTGhxkoHE1+CxdPQg2oQkpBRQDjHjxmy6i/3i5Eol1Ph uKQJPAkX2ctzQPUyKfJxUMWw5bCT3v3PrumQ2Rpame/GIT55g/kzqJdtv7WSGGRtTpoa mOXA== X-Gm-Message-State: AO0yUKWRw+UV4fxuFgcZ0t34mJPjO2Dd4bi+VyW9Oq2+dKyX5LVPrMka AWy44v1NAhJgn8m+jX110B7V+bs6HSLGUPhl6B/7ig== X-Google-Smtp-Source: AK7set+Hvog1Dx2Cs4T4pz7KjICWNdmS6cbnN633KiEmXHg1e025OzJfDxDqB4MO/d6LR8IOFvFj7jmzOUlY3F+U+Lc= X-Received: by 2002:a67:e081:0:b0:41e:910f:10ed with SMTP id f1-20020a67e081000000b0041e910f10edmr1840052vsl.11.1677106374191; Wed, 22 Feb 2023 14:52:54 -0800 (PST) MIME-Version: 1.0 References: <20230218002819.1486479-1-jthoughton@google.com> <20230218002819.1486479-17-jthoughton@google.com> In-Reply-To: From: James Houghton Date: Wed, 22 Feb 2023 14:52:18 -0800 Message-ID: Subject: Re: [PATCH v2 16/46] hugetlb: make default arch_make_huge_pte understand small mappings To: Mina Almasry Cc: Mike Kravetz , Muchun Song , Peter Xu , Andrew Morton , David Hildenbrand , David Rientjes , Axel Rasmussen , "Zach O'Keefe" , Manish Mishra , Naoya Horiguchi , "Dr . David Alan Gilbert" , "Matthew Wilcox (Oracle)" , Vlastimil Babka , Baolin Wang , Miaohe Lin , Yang Shi , Frank van der Linden , Jiaqi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 286581C001E X-Rspam-User: X-Stat-Signature: y44a1djq4jixn9eok8534u8uyd5y7wsd X-HE-Tag: 1677106374-602207 X-HE-Meta: U2FsdGVkX18SrV7cHN5uuPL02l4yhgNn6werv95lZIR+3pBz5G/ZRQ48XA+u3vtvKBF+qRLs1AXCkQ3FXKYtM0St495VVK5gz5irmLJ3zsXFmp0iB7DqB3a1qeN7BWW06gMVLcsOuhZCuRTbKBQww1CnM9ALjV8oJcjB+/aoa5Ks/sonI5VP6XyZBCjJ70y1H/EXyvR4mxH9F+oUPKmZZsj2XchwgXwi1PkGZEB/mKDQB2FajPnI2uAbgV40+dlvEwH0KPclW69T4vVCyNkoB1Wybabbndy6cpgSzyUHk9Tv2bDB0du2DASGwd0qQnX0GhQj/smQt/WLUdL4LyQXbZakmXgqv/vWiMMuZdHifqf4m/qcrCBLZwHbC+H8NvzpWE41LVm/hICTkp3K4ovzsKggGVBHy2pvo///EhLsNVzgz73fsSM5B2q+56diY90gufOpHUfDyPRufyyIQm0L/G/MzgMcEg3PYy30bylG9Jp8O9YGARSWt9vqiD4/sOgyYA4BAXVLGCIwVyd/w8ygO+ufJ+LKHLe7UwDGUuXMctC2UqGxhTGMaNXg3gdFyqv6NsLfuKBnMpTU78d4qOxruEsSaTi/xC44yqjsWHzNEmpYsRB8vstTWO9V+ToQAadQQgXjF0k9I4KFh6WyDBW88gKD4R2RjUdEcY+SEOk/W9h+1hoDxAVTDmdEwYHjeXrUeCQM8MBEx4T+JLf9wWAxE9EYnIp5KR2Kx/jWQzx/X19LXxBa9sC0BBC2YZc4Ugp933eo6OIgBoj3L1itDTqafzOb4k6/0E6qD3cyiv9ICCSVX0nyEV1ClMmF9dMqiUl8d67UbX1pCJTcQpIy1vuSdeT5q9vpyn9LRoBWFoZ6cZL5ZAv+Opha540bdzBzMaF+Yfw0tac8mEupLX9pz4DTHLT/arlBpRRAgwRUBtf27q5fbrl/2T5grxuaVvEdTZNRPevK1Jfz0ygRxIEhhQd rBJIPwFo rU0FGlxkUHna6yukLGcLaplzaF2/Tyk7BtOVQ2MQ/1YDQn2qBJFoMROJxfo/RwwNBZb1yq6ycRM0lXWd6Jh9tA7TwKfQc2Agoafq2247he+MZ57jK3qZw/m5E/3xEkVnEzJ3HM66yNzi8EuVkl3VNv9H29wdnwWi27wGUA44AkwJtUgUA5mgcOiYScN7XmlJ5ZTGfHNhpufJrEW7zonFQAnuqwMTcSnGCtMD0fuiNXF17SdXV+4baEHrW8oGTONHbci3UMTUskYOBPlA9HBLloEx99dQVImA2BxEskRasQnCFmq2IjrL311QC8w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 22, 2023 at 1:18 PM Mina Almasry wrote: > > On Fri, Feb 17, 2023 at 4:28 PM James Houghton wrote: > > > > This is a simple change: don't create a "huge" PTE if we are making a > > regular, PAGE_SIZE PTE. All architectures that want to implement HGM > > likely need to be changed in a similar way if they implement their own > > version of arch_make_huge_pte. > > > > Signed-off-by: James Houghton > > > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > > index 726d581158b1..b767b6889dea 100644 > > --- a/include/linux/hugetlb.h > > +++ b/include/linux/hugetlb.h > > @@ -899,7 +899,7 @@ static inline void arch_clear_hugepage_flags(struct page *page) { } > > static inline pte_t arch_make_huge_pte(pte_t entry, unsigned int shift, > > vm_flags_t flags) > > { > > - return pte_mkhuge(entry); > > + return shift > PAGE_SHIFT ? pte_mkhuge(entry) : entry; > > } > > #endif > > > > How are contig_pte's handled here? Will shift show that it's actually > a contig_pte and not just PAGE_SHIFT? Or is that arm64 specific so it > exists only in the arm64 version of this function? Do we need to worry > about it here? arm64 implements its own version of arch_make_huge_pte, and 'shift' does indeed indicate (to arm64) if the PTE is contiguous or not (like it will be CONT_PTE_SHIFT, for example).