From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD68C433ED for ; Thu, 15 Apr 2021 08:19:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B945A61166 for ; Thu, 15 Apr 2021 08:19:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B945A61166 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 33FAB6B0036; Thu, 15 Apr 2021 04:19:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EF9C6B006C; Thu, 15 Apr 2021 04:19:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16AFE6B0070; Thu, 15 Apr 2021 04:19:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id EC0566B0036 for ; Thu, 15 Apr 2021 04:19:15 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 966F718013669 for ; Thu, 15 Apr 2021 08:19:15 +0000 (UTC) X-FDA: 78033901470.12.00868B2 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf26.hostedemail.com (Postfix) with ESMTP id B220240002D0 for ; Thu, 15 Apr 2021 08:19:10 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id c123so19518738qke.1 for ; Thu, 15 Apr 2021 01:19:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NvhKR56KuIoUAcYqyc0u5PLnwbCbEPMsZVGP9QtFlmc=; b=Y7PMLI0DRY7+SN+xCRlop+KsyakhTUReeiBEjRSiFy+vglErV05vdZ9WRpiPVu4gMD XYCVAxbZ7Qxk40G+qHQ9ZybCBxJh+x6lpcaBtxVTJlp2avrVSX1ih+CSbo5FGFuba6oZ X1NvbeyM72Ots7MVJybjI+TM8e/pbB/j/EUdceOvOHFuQmDCiFZYgjhzECujr9qj513E ZiS+c7ktEchdZ2tkJ1HXpgyLO70X8Ea+nZKW9u7TD78Ac2R9MoZAo/tWeW1DfCfqvdLi ef1VOv0vmFNXfHNLZwsm/HUaaXb0e3U5Ri+O7Otcgs5plKqsFX0sS4IdMEvimNz/VMAA QKSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NvhKR56KuIoUAcYqyc0u5PLnwbCbEPMsZVGP9QtFlmc=; b=h3gHeJGM96iDxkuQcfyXyXDZMuER9OBJMr5WUXZDakJPVVWumwcMxCS0tF4xXwNmvy 0vTrDoMIhvkehqciq6xNjVt51mP9UD/EsNx7w9r7z9qaEHv+DrYkKi3SrFykFuvzFIVQ eJfn4pB6LKBOMU1chRfMFdCf5KR6OevJx1M05UxamSuzwAkfTRVbCW/od9xyjBNjPtdX 2ctFUDMqIKCmMgVTWX9sO/IHhf62APtXPgMnmpysoZIN9NsXsxaevW/7qzHDdslE1kQA cjWKdrRBIe29SeFhDr5iDIUrKZn/X6KiD0RlUlzYyDBQ9Y1NJqsc3UNDXQWJk0/zjMFH s+FA== X-Gm-Message-State: AOAM532yDQa22hHgNdjv4HAC+VqYU+I0S1mQ/JP/DXNMhXRMSMnn9/Es Mwr6uqMyVONX3ngiVKlAxO04/SSvdJ6/pGkaxGl1pA== X-Google-Smtp-Source: ABdhPJwJPc03Dt7HaOX1DNwbsxiXUR8hTbedVI37Jf6TjbFgbPeNGADUr08sKhIHro6PFb44mC/exCylixRaX6aM1pA= X-Received: by 2002:a37:58c5:: with SMTP id m188mr2199686qkb.327.1618474754452; Thu, 15 Apr 2021 01:19:14 -0700 (PDT) MIME-Version: 1.0 References: <202104141253.bL6hQTMm-lkp@intel.com> <87mtu0n77n.wl-maz@kernel.org> <87lf9kn6wb.wl-maz@kernel.org> In-Reply-To: <87lf9kn6wb.wl-maz@kernel.org> From: Andrew Scull Date: Thu, 15 Apr 2021 09:19:03 +0100 Message-ID: Subject: Re: [linux-next:master 7952/12404] arch/arm64/kvm/handle_exit.c:318:4: error: implicit declaration of function 'bug_get_file_line' To: Marc Zyngier Cc: kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B220240002D0 X-Stat-Signature: rp1te3duut8tbrqhcjj17xk68jztturm Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mail-qk1-f173.google.com; client-ip=209.85.222.173 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618474750-429384 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > Andrew, > > > > This is what I plan to stick on top of your series. Let me know if > > you're OK with it. > > Duh. And now for the real patch and not the dummy thing that was in my > sandbox... > > M. > > From 882ff4062169d5914ad7ed88c9138a90e485c05e Mon Sep 17 00:00:00 2001 > From: Marc Zyngier > Date: Wed, 14 Apr 2021 17:41:14 +0100 > Subject: [PATCH] bug: Provide dummy version of bug_get_file_line() when > !GENERIC_BUG > > Provide the missing dummy bug_get_file_line() implementation when > GENENERIC_BUG isn't selected. Oh, conditional in the Makefile... > > Reported-by: kernel test robot > Fixes: 26dbc7e299c7 ("bug: Factor out a getter for a bug's file line") > Cc: Andrew Scull > Signed-off-by: Marc Zyngier > --- > include/linux/bug.h | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/include/linux/bug.h b/include/linux/bug.h > index e3841bee4c8d..d889ee043118 100644 > --- a/include/linux/bug.h > +++ b/include/linux/bug.h > @@ -61,6 +61,12 @@ static inline enum bug_trap_type report_bug(unsigned long bug_addr, > return BUG_TRAP_TYPE_BUG; > } > > +struct bug_entry; > +static inline void bug_get_file_line(struct bug_entry *bug, const char **file, > + unsigned int *line) > +{ > + *file = NULL; `line` is also an output argument so it might be worth zeroing even though it shouldn't really be used if `file` is NULL. Otherwise, thanks for catching! > +} > > static inline void generic_bug_clear_once(void) {} > > -- > 2.30.2