From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 571EAC433EF for ; Tue, 15 Mar 2022 23:54:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96BB08D0002; Tue, 15 Mar 2022 19:54:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91ADB8D0001; Tue, 15 Mar 2022 19:54:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E3498D0002; Tue, 15 Mar 2022 19:54:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 6FF878D0001 for ; Tue, 15 Mar 2022 19:54:41 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3158DC62 for ; Tue, 15 Mar 2022 23:54:41 +0000 (UTC) X-FDA: 79248277962.15.B958E06 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf24.hostedemail.com (Postfix) with ESMTP id B9580180003 for ; Tue, 15 Mar 2022 23:54:40 +0000 (UTC) Received: by mail-yb1-f180.google.com with SMTP id u103so1500366ybi.9 for ; Tue, 15 Mar 2022 16:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0xlurKCUM4YSmUkIVypyj8embDeL9DxbXlFAmffyKHk=; b=YWSK8NXNXoQdi7hNWVycl/TbZbyaLklUKLlRfiKBEuWLOF0/L8MCT0qMoSamK0odp1 j/F0IyEUGNK+I3IIPuzjui1frCebhVZ9JzC3hxOaH49yz/TV//yBMXsn3GwArjSJBjX/ /szB69aoQsdlXaDuD9NLam6OVNouDpHdu8VHZOQfqsJz0CW1ouuoBlG2bMqGTzWer6Dq 8zsJ9oBClj/hG+jKc0nVWkuyA//yiT9P1VXVfp/65DB3it2wGfiHtlJiItXbHWEY+8cy VXPi46LE0urxlF6Oqm2TONwHpQmLC01YM7qYzT34XlkZ+UHBpRfXX2py4hD9hjU2nwY6 kuvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0xlurKCUM4YSmUkIVypyj8embDeL9DxbXlFAmffyKHk=; b=P+j3fVVwoFgLGUTAH2M2qjZZ2ARJFW/O78ebylX9xxzQmJjRHv1uQxCEu4ppTeln+w wEkg/9Z5SyUEJIRuWo5DehggSwcsVJ3i/cMP7vDIOthWfderDAA2nWW79S89qlfsvBvp HqUZaZ5gac41Bax+q8nUn6tdygGLz55Qc4tJXzRKsPlC1Ds5+wJy97n5bb7gXTnmLT/W R2VOF7YppEHytVugima+3B3R3RdalKnoQoSLt1iYhK9qArU50IDHfL8qMzLr3Nr1reZN ahEt8SI9g1d1wOeYiwqMGw/Kn8U88sI6xiTBJbVJseldEo1yQqZl4aTs5bj2c/Xfq+8t Kaow== X-Gm-Message-State: AOAM5312RQpqyhsOVhqOz/XtquQoVHXQaqNveRCwse0DmVk8wpi1FRWO 8H0UkxXn1snmJikUDqRRplAhm6lrxppPpVorsG8= X-Google-Smtp-Source: ABdhPJyXnv1OMttTW2JO06Rn+iGeJjL2Lv4q5O+H1QnrFGuqxc3fK1fudN8WFHLZ7KkjEvxcg+EaKAV57rcM715cdlg= X-Received: by 2002:a25:73d3:0:b0:629:173d:7c5f with SMTP id o202-20020a2573d3000000b00629173d7c5fmr25509514ybc.328.1647388480032; Tue, 15 Mar 2022 16:54:40 -0700 (PDT) MIME-Version: 1.0 References: <20220312071623.19050-1-richard.weiyang@gmail.com> <20220312071623.19050-2-richard.weiyang@gmail.com> <20220314225150.fhwny4yhxgjevwxx@master> In-Reply-To: From: Wei Yang Date: Wed, 16 Mar 2022 07:54:29 +0800 Message-ID: Subject: Re: [Patch v2 2/3] mm/memcg: __mem_cgroup_remove_exceeded could handle a !on-tree mz properly To: Michal Hocko Cc: Johannes Weiner , Vladimir Davydov , Andrew Morton , cgroups@vger.kernel.org, Linux-MM Content-Type: text/plain; charset="UTF-8" X-Rspam-User: Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YWSK8NXN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: B9580180003 X-Stat-Signature: zfhu1zncam31fz3bdqeermbe7ff4fcog X-HE-Tag: 1647388480-961674 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 15, 2022 at 4:52 PM Michal Hocko wrote: > > On Mon 14-03-22 22:51:50, Wei Yang wrote: > > On Mon, Mar 14, 2022 at 10:54:03AM +0100, Michal Hocko wrote: > > >On Sat 12-03-22 07:16:22, Wei Yang wrote: > > >> There is no tree operation if mz is not on-tree. > > > > > >This doesn't explain problem you are trying to solve nor does it make > > >much sense to me TBH. > > > > > > > This just tries to make the code looks consistent. > > I guess this is rather subjective. One could argue that the check is > more descriptive because it obviously removes the node from the tree > when it is on the tree. Hmm... maybe yes. If someone else prefer the original one, I am ok with it. > -- > Michal Hocko > SUSE Labs