From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC736C433F5 for ; Sat, 7 May 2022 21:56:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EBF76B0071; Sat, 7 May 2022 17:56:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09B5A6B0073; Sat, 7 May 2022 17:56:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA5366B0074; Sat, 7 May 2022 17:56:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DC5DC6B0071 for ; Sat, 7 May 2022 17:56:27 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AAAD92EA72 for ; Sat, 7 May 2022 21:56:27 +0000 (UTC) X-FDA: 79440306414.18.8F9F6D3 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf03.hostedemail.com (Postfix) with ESMTP id 67FD020032 for ; Sat, 7 May 2022 21:56:20 +0000 (UTC) Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-2ef5380669cso112121497b3.9 for ; Sat, 07 May 2022 14:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nMEwdrSe08xN3wHSlN/Z1pBwbNRH/lN9tSFU2Y+DZ74=; b=WwdxwCwoz7NScZnv5y+cg385fOW3yA+7XErGsS/9R67Ak8Y1bFnEV7KvXP/HjOnzvw 3ROLCIJkCAUiGbj542RNWt7Zn7b/CMPW9vnaqyp+J3cwoxm9KnOb5NhRUMW3GiCtQVAw 8+jRPiBnOw94O+akdg9I8ZYvvGCF/aPdWDp9fbwt5v2iKMPxsErAeGNobSl3Gcn5YxRT YnUumDUvCO+ymzQSojbg5P1S3lq58HUJP8XDemDH2n7NmVeA68/eB8+3NzZBFTJGduJS 1bEwrwF84wMmh2mMYp14voFLKFLnkVdPBfsnNQCSK+CiJKBesDuwTiKkjVSTO/j0OFPw 54sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nMEwdrSe08xN3wHSlN/Z1pBwbNRH/lN9tSFU2Y+DZ74=; b=r57TEN1uxVlCS3MtkRUqIkvh17QF8u2J96WNxCTh6IHlSm9ZEjXJJt688Xw3EABQ83 JFf7RQnzNkwBTRbzLujjorUp7ApXLG/idR/BoZn2XfuwXRuqZQjuG6Sce+gMhakT62JA cMHu2Sg614T0IvzZ5fn1JxKEi1R3zsha2t2RCHJ3DwB0Qk4YB5OAmyQbABiGgqRqFhRE jaGIhujIRebuXyU56t83NBwgT6v2gi4W99XLAtpaYGcZspk0XMFz7i1aCJscaEgKwsuo I8U9NHIjg/ihPnoD8h/oZ+epNkvBJWAjXdkdT8wvH1a/uwkXuqBY0VeOCYPcappxkcas ZxUg== X-Gm-Message-State: AOAM533t1OjBvhmP6XHKa6lKX/3dS1mGnM2TrLBfCkTlcTzffgTJMuwy GPRZQdVP5Vf7vS+jqSZ4b382QxK1X7368huObh7QYRWNXjM= X-Google-Smtp-Source: ABdhPJx3RXHRkzvBITHEGj3yzH45LEW0sOxM5kUZl16O1k9C0EDOSM7m/5tRtZX2SPr7FFRy6hlogKuMBB2w/Me/dSA= X-Received: by 2002:a05:690c:94:b0:2f1:98b3:fe7c with SMTP id be20-20020a05690c009400b002f198b3fe7cmr8462556ywb.284.1651960586500; Sat, 07 May 2022 14:56:26 -0700 (PDT) MIME-Version: 1.0 References: <20220504003958.18402-1-richard.weiyang@gmail.com> <20220507140346.e6e44657af1c98fea411239c@linux-foundation.org> In-Reply-To: <20220507140346.e6e44657af1c98fea411239c@linux-foundation.org> From: Wei Yang Date: Sun, 8 May 2022 05:56:15 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm/mlock: not handle NULL vma specially To: Andrew Morton Cc: Linux-MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 67FD020032 X-Stat-Signature: uzndf6kqebtwqrwkjjnajw4d39hrpsq5 X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WwdxwCwo; spf=pass (imf03.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam09 X-HE-Tag: 1651960580-453096 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, May 8, 2022 at 5:03 AM Andrew Morton wrote: > > On Wed, 4 May 2022 00:39:57 +0000 Wei Yang wrote: > > > If we can't find a proper vma, the loop would terminate as expected. > > > > It's not necessary to handle it specially. > > > > ... > > > > --- a/mm/mlock.c > > +++ b/mm/mlock.c > > @@ -504,11 +504,7 @@ static unsigned long count_mm_mlocked_page_nr(struct mm_struct *mm, > > if (mm == NULL) > > mm = current->mm; > > > > - vma = find_vma(mm, start); > > - if (vma == NULL) > > - return 0; > > - > > - for (; vma ; vma = vma->vm_next) { > > + for (vma = find_vma(mm, start); vma ; vma = vma->vm_next) { > > if (start >= vma->vm_end) > > continue; > > if (start + len <= vma->vm_start) > > The mapletree patches mangle this code a lot. > > Please take a look at linux-next or the mm-unstabe branch at > git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm early to mid next > week, see if you see anything which should be addressed. > I took a look at mm-unstabe branch with last commit 2b58b3f33ba2 mm/shmem: convert shmem_swapin_page() to shmem_swapin_folio() Function count_mm_mlocked_page_nr() looks not changed. Do I need to rebase on top of it?