From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEA9CC61DA3 for ; Tue, 21 Feb 2023 20:10:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C4A36B0071; Tue, 21 Feb 2023 15:10:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 775106B0074; Tue, 21 Feb 2023 15:10:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63BAC6B007B; Tue, 21 Feb 2023 15:10:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5260C6B0071 for ; Tue, 21 Feb 2023 15:10:31 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 179FB80271 for ; Tue, 21 Feb 2023 20:10:31 +0000 (UTC) X-FDA: 80492391462.04.A535743 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf14.hostedemail.com (Postfix) with ESMTP id 14F9F100011 for ; Tue, 21 Feb 2023 20:10:27 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=p7bEe3Yt; spf=pass (imf14.hostedemail.com: domain of anders.roxell@linaro.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=anders.roxell@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677010228; a=rsa-sha256; cv=none; b=ZaI21lf2I45WmnmW92DRGWhdDpgMKTX4LkasYG3KcVOYjlg9ddYsZ4e2ACCAKMz9DM03IE yzp4rJY9I+9M1B3MO6QNpGZJvs8aloZPeZx1NQz18x8L6F6lTqemN0crpRYpRGwbky4oS1 5tFoEVQl427aYVcZYBEdbYgF34jS0+M= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=p7bEe3Yt; spf=pass (imf14.hostedemail.com: domain of anders.roxell@linaro.org designates 209.85.216.44 as permitted sender) smtp.mailfrom=anders.roxell@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677010228; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LRlUY6P+Ws5JPolkKmM4if+5xV6FQbDYkfpB+lRI9nA=; b=f1RYcyr6AJ6GyBfgfrf+ruqPyfUgfXM5jwcFzfv3G3iYvv0DBWBPvdxTYljtQ3jdT6bJxl vezrQUko0meL/SPIcrCfvAtpL3yYUa3zZFzzVAVkONN/3rYA0++vf42PGV0RwUdy44B38X GbyTfNdmSIcIFmw98PRCIuiCPZ884AM= Received: by mail-pj1-f44.google.com with SMTP id nw10-20020a17090b254a00b00233d7314c1cso6323106pjb.5 for ; Tue, 21 Feb 2023 12:10:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677010227; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LRlUY6P+Ws5JPolkKmM4if+5xV6FQbDYkfpB+lRI9nA=; b=p7bEe3YtIo4ajQL8acKLCVuOyUPkB9m1s1o0xoenMbSiaB337hC/CdK/jbzvDugc0f Hf4fM4xnGQAICvqcdnsCmWG1jh1fCnAzvC+G7PNSr9l4eEyhUf6HRrEVj0qye4Z9xojM 3HByT4JE1omYdOn463zyimPZ7tXfslxrCjpy4aS4iO1exB1AF66AgiwSzKq/yd1BQ7jz cgyX1mzTZe65lBFWhIkW5bB0yaZ01Wz7NEC10t3zZyXHX0uRN7BeC/LOcD2C9HgNWyc7 rreJcF/ZpBmEDH/OC8J0GurpsNB6TBWV69eZWIhvxd8szuQUilaJvRL9jPxKLNWOipXz 1wiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677010227; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LRlUY6P+Ws5JPolkKmM4if+5xV6FQbDYkfpB+lRI9nA=; b=05m/zN+x9KzzRZNx+qbbAAd60FJ2u8Y2DpbPq+egenLnoeuR6LEq2Pi7pHikssRXGr YKTx/N9LOztY7ReZLTMk5iNQ0OdyI01jLV9b+9CY5xM9klIK7XCiTy41MWwFIT2Lrl0T JfnWbcCbIxizcV9s4WjawXPsge8GmVMt1C8N07WYk4FKLBqTm5yNrM5WeODUAwmQPsK5 sjmi6MHgSwoYRpSzuTLcg9nLRbHtjw4h5d1rJa0fG+Whf3txf3cX4LbQoGZnnRvU8BkI TJAaEpuhpIdMxhfyiGVnhPa8BT8+q6bX6tkQOiqhHF5eA5CrdGReIBnMGIOl0wGrB9Af 7sGg== X-Gm-Message-State: AO0yUKXKkwwgCzY5GDi7QR7wHncUtA4QMfOTWitcwG4+02KXCDsEojNB erU5mnxRfHaxRzqR59DmWRwlb6NE0KhM9tWY+mo0iQ== X-Google-Smtp-Source: AK7set/bvzuBBHiSVRwjdCBYFgmcLi2VbO8gyb1hmLmDfOqhiJPx1AXSbHElEgZn5ThzkdRg0ezGAHgn6PJB0Lpc+wQ= X-Received: by 2002:a17:90b:48c3:b0:234:bd18:61e4 with SMTP id li3-20020a17090b48c300b00234bd1861e4mr2124639pjb.83.1677010226892; Tue, 21 Feb 2023 12:10:26 -0800 (PST) MIME-Version: 1.0 References: <20230221070837.1502935-1-anders.roxell@linaro.org> <20230221171951.131472-1-sj@kernel.org> In-Reply-To: <20230221171951.131472-1-sj@kernel.org> From: Anders Roxell Date: Tue, 21 Feb 2023 21:10:15 +0100 Message-ID: Subject: Re: [PATCH 1/2] selftests: damon: add config file To: SeongJae Park Cc: shuah@kernel.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Naresh Kamboju Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 14F9F100011 X-Rspamd-Server: rspam01 X-Stat-Signature: p7xeonhdu9h7x5ezxu3m6hch5o5b1bek X-HE-Tag: 1677010227-967644 X-HE-Meta: U2FsdGVkX1+NaCvvE3pqZtwWmYnAEoKBt8v9ERNsEm7RUEidq01Hry92vumUVA42BX9A7F2wOW0Aigh8t5Ueco8HTCs1BtJKJewyXiwsVQ/f5Yoq3H957E7KeRYcMEDBZKuMTiK/IxVpkt1oRo+ejJylmpWr9wkQbzrNhAGlqI6UmacWo/h2QY4S+HMZsyQNVpD0esNnfFm2zdUNZRRtWtAA1ZJY+G2WdTPFfZQc4JuLCJNUWxGpd7Li+5l+95CGUZGNiOmFqrzgzfjYvJlVEhXK4uPHZR0pAeDgMSF0KnFJ7xDQuAoFOsnXIsBeEYfRt7pmVKM9GHLMjb3MAo7j06ouREy9CJGs+BwK3tjjL8p+pxUeP75Hv4svKzHseeJ4wDw3ULn8O6Nd8nj1P2baCnKbJ/ri1ekw3lzcMHFGRfyOUOTXtaLThcpENnp+vXb9t/dN2pETAxxmJwipj52x3uc4wxo6pmJhsQq1nykIrUIYqJ9Bbsvs2WgGKHh15mKWDGKq0K5jpoC0Lv4uombaEcSr2Qi09vnyjdoi1ejmAyd0l1G3+uqy2y8zsECAOG692eq3H4/oI9H0fYeuw6RqjKV/VTkIB6zkJb/lGV+Wmx2AsG/Sk5vjSESWMTQcOrdo1tWTyU4oC7cv/x/j6akx41VkuG0YEOAHe3JPsKFaCOIBnrFov8e+K9ZYsh2fkkyuUMzgblm/fqK6IOCN8pCvk6P2Fje736A2cYCeB/7YezvLNo39qanc1BrmlglA2k796cUBtdQjtXAq2HC7J/TUYiiADOplkRjpxp0c/e7p4MME/88+CyreLcrUYy1fmp9alv67IIQ1TPRFjHDDaGDlxYcZ0RXBc0o7BOM31nfrurZEPsTHKd8Krz47RPf6vvi9X3JD+yQquv3shFw+wWcv+oF8tOuHDABHI5JvpriKhPl+lEDHx0SoplMgs/yT5l8Cxm41SNc3SqDtiLO2Q7P L2BJvhLS Cr12YlFpjOW5Q6I/MkYPj5jY0WMgyJFVhomMx3+QvEPmepT9Yii3sJwjAXgV5Lt5ZLJupsv5fnwd1IfmxoBpkji+bDvYeq8T3skp7wfKjp4/VMOjGxUUupUX+OfA8JEFCx9J1rVhyipgPzcjibyQ5Ml3p3SHZmEg9EX2l++Ykuo15N5+GA3W+78YYj3oU784WrFpG8F3GeGcr9YWUL8wpKIjVReVnQ1Gqzq3Rsixu9IriA4/BTuUsZJ2iEJ/kXko9rjoVxQAqZhru9bMxTkdh8wbEmE+GGtmf2K8YgxsOrfCmxO1kmNRNvGp4VIy3Zl04jZpWG9p9cIj0tW1PK+q97bNBagSzrVhu0VH8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 21 Feb 2023 at 18:19, SeongJae Park wrote: > > Hi Anders, > > > Thank you for this patch! > > On Tue, 21 Feb 2023 08:08:36 +0100 Anders Roxell wrote: > > > Building and running the subsuite 'damon' of kselftest, shows the > > following issues: > > selftests: damon: debugfs_attrs.sh > > /sys/kernel/debug/damon not found > > > > By creating a config file enabling DAMON fragments in the > > selftests/damon/ directory the tests pass. > > > > I think we could put Fixes tag as below? > > Fixes: b348eb7abd09 ("mm/damon: add user space selftests") Make sense, I'll add it. > > Though this may not need to be merged in stable. > > > Reported-by: Naresh Kamboju > > Signed-off-by: Anders Roxell > > --- > > tools/testing/selftests/damon/config | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > create mode 100644 tools/testing/selftests/damon/config > > > > diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config > > new file mode 100644 > > index 000000000000..a6b636e438b9 > > --- /dev/null > > +++ b/tools/testing/selftests/damon/config > > @@ -0,0 +1,8 @@ > > +CONFIG_DEBUG_SYSFS=y > > 's/SYS//'? Or, I guess this is not needed at all? This can be dropped. Thank you. I'll respin the patch shortly. Cheers, Anders > > > +CONFIG_DAMON=y > > +CONFIG_DAMON_SYSFS=y > > +CONFIG_DAMON_DBGFS=y > > +CONFIG_DAMON_PADDR=y > > +CONFIG_DAMON_VADDR=y > > +CONFIG_DAMON_RECLAIM=y > > +CONFIG_DAMON_LRU_SORT=y > > > Thanks, > SJ > > > -- > > 2.39.1