From: Anders Roxell <anders.roxell@linaro.org>
To: SeongJae Park <sj@kernel.org>
Cc: shuah@kernel.org, linux-kernel@vger.kernel.org,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org,
Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH 1/2] selftests: damon: add config file
Date: Tue, 21 Feb 2023 21:10:15 +0100 [thread overview]
Message-ID: <CADYN=9KdXbCbVCs1C5n54g_EtmTn5iuHwh3BC4drHtAvcOQ0XQ@mail.gmail.com> (raw)
In-Reply-To: <20230221171951.131472-1-sj@kernel.org>
On Tue, 21 Feb 2023 at 18:19, SeongJae Park <sj@kernel.org> wrote:
>
> Hi Anders,
>
>
> Thank you for this patch!
>
> On Tue, 21 Feb 2023 08:08:36 +0100 Anders Roxell <anders.roxell@linaro.org> wrote:
>
> > Building and running the subsuite 'damon' of kselftest, shows the
> > following issues:
> > selftests: damon: debugfs_attrs.sh
> > /sys/kernel/debug/damon not found
> >
> > By creating a config file enabling DAMON fragments in the
> > selftests/damon/ directory the tests pass.
> >
>
> I think we could put Fixes tag as below?
>
> Fixes: b348eb7abd09 ("mm/damon: add user space selftests")
Make sense, I'll add it.
>
> Though this may not need to be merged in stable.
>
> > Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> > tools/testing/selftests/damon/config | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> > create mode 100644 tools/testing/selftests/damon/config
> >
> > diff --git a/tools/testing/selftests/damon/config b/tools/testing/selftests/damon/config
> > new file mode 100644
> > index 000000000000..a6b636e438b9
> > --- /dev/null
> > +++ b/tools/testing/selftests/damon/config
> > @@ -0,0 +1,8 @@
> > +CONFIG_DEBUG_SYSFS=y
>
> 's/SYS//'? Or, I guess this is not needed at all?
This can be dropped.
Thank you.
I'll respin the patch shortly.
Cheers,
Anders
>
> > +CONFIG_DAMON=y
> > +CONFIG_DAMON_SYSFS=y
> > +CONFIG_DAMON_DBGFS=y
> > +CONFIG_DAMON_PADDR=y
> > +CONFIG_DAMON_VADDR=y
> > +CONFIG_DAMON_RECLAIM=y
> > +CONFIG_DAMON_LRU_SORT=y
>
>
> Thanks,
> SJ
>
> > --
> > 2.39.1
prev parent reply other threads:[~2023-02-21 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 7:08 Anders Roxell
2023-02-21 7:08 ` [PATCH 2/2] selftests: damon: change scripts to be executable Anders Roxell
2023-02-21 17:56 ` SeongJae Park
2023-02-21 17:19 ` [PATCH 1/2] selftests: damon: add config file SeongJae Park
2023-02-21 20:10 ` Anders Roxell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADYN=9KdXbCbVCs1C5n54g_EtmTn5iuHwh3BC4drHtAvcOQ0XQ@mail.gmail.com' \
--to=anders.roxell@linaro.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naresh.kamboju@linaro.org \
--cc=shuah@kernel.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox