From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDB4AC433EF for ; Thu, 18 Nov 2021 10:03:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 831636187F for ; Thu, 18 Nov 2021 10:03:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 831636187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 1F7966B0072; Thu, 18 Nov 2021 05:03:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A7476B0073; Thu, 18 Nov 2021 05:03:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BDB06B0074; Thu, 18 Nov 2021 05:03:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id ECA8D6B0072 for ; Thu, 18 Nov 2021 05:03:47 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9807A8226A for ; Thu, 18 Nov 2021 10:03:37 +0000 (UTC) X-FDA: 78821614074.02.F8F9561 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf21.hostedemail.com (Postfix) with ESMTP id 36C31D0369DE for ; Thu, 18 Nov 2021 10:03:36 +0000 (UTC) Received: by mail-ed1-f52.google.com with SMTP id w1so24504285edc.6 for ; Thu, 18 Nov 2021 02:03:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0iFq7ifdSzsK4y7sUkWjPAAy7rrcYr2QzN82yUpKmac=; b=Kh8xlmB2lzGJCuzM6iaOdkgnGbweIXiaqn7Gy2JGCiQ66Fppxin9bBoKYzXKUtT+KJ ySyhbnVBgZQqjfmog8sbF34dWA+mxFyujTMbIYvYgf6SG4UcIe8ttoVLzYBHp20PFr1f k5BKnr6bG9iCqvPBSNu6ACpnEKzlqy8DjgD4s21hVTjwCOOPSu+43PrUYna7jKXutDZm toXdtSa0NkLiNlh/Dv9QvUH1TI+92d9W9JR22GqLCUwTD5gycdUcIDw1CXB4Sw/LTsl4 3OTFSxQqs4LdZJActtapyG5Zn+8Pld0EgI/FkM/CsOki269qUxVQC+gbr78CVxvIa0yw jXFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0iFq7ifdSzsK4y7sUkWjPAAy7rrcYr2QzN82yUpKmac=; b=CCDb7bOgg5+H9TO4veNYntJM169mZ1fpBS1Pno4mJG/DlOuetSRUEgpa0wBo2YdjrL efnku8/6c2xZk4PyuuuQ564kV3R+2QWXuqdWnjWVtx9gEYS20nZ4gHsIaE4HOtlQ/0NX XiVDlpYofcOvjWMlDv9knUKyg38szf1V+LiDALbvBTGb0l0unFg7tt+cfRsbSoCvN/sK U+vMSieEyGi59Z/AW6YcqyUg1McW2gYcB3SdIdQqZl4PKFCE/MHKIT94RJAcIKDn3yy4 2w53q3exMFEL06RUceCmHSVTqGtZr3075Bom45RsbitMmmmO0zlGTn8BYG5JLFpx/Z7H 3gRA== X-Gm-Message-State: AOAM531Sdn+XPfbll+kYIoWJ30Sfck0wwMdONUqwqKQUW4Henab3u0eS uJXmBK6PwSJUCjQLuw66MhpguBUGfbvoN2QVY+TgVw== X-Google-Smtp-Source: ABdhPJwBI7mxelZKKBcU8W/pn7DbUQvvIOqh8OSGE6MA8RbLSnT4MtQfFzNxAXDU/YOmq2pBBt3ZENTt0wLNfKKXsR0= X-Received: by 2002:a17:906:2f09:: with SMTP id v9mr32434542eji.163.1637229815786; Thu, 18 Nov 2021 02:03:35 -0800 (PST) MIME-Version: 1.0 References: <20211118095852.616256-1-anders.roxell@linaro.org> <20211118095852.616256-2-anders.roxell@linaro.org> In-Reply-To: <20211118095852.616256-2-anders.roxell@linaro.org> From: Anders Roxell Date: Thu, 18 Nov 2021 11:03:25 +0100 Message-ID: Subject: Re: [PATCH v3 2/2] selftests: clone3: simplify return logic in clone3_set_tid() To: shuah@kernel.org Cc: fenghua.yu@intel.com, reinette.chatre@intel.com, john.stultz@linaro.org, tglx@linutronix.de, akpm@linux-foundation.org, nathan@kernel.org, ndesaulniers@google.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, llvm@lists.linux.dev, christian@brauner.io Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 36C31D0369DE X-Stat-Signature: qmh99qxfa46eg64pgtytu8b63akbo4qc Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=Kh8xlmB2; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf21.hostedemail.com: domain of anders.roxell@linaro.org designates 209.85.208.52 as permitted sender) smtp.mailfrom=anders.roxell@linaro.org X-HE-Tag: 1637229816-85276 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 18 Nov 2021 at 10:58, Anders Roxell wrote: > > Use ksft_exit_* and exit instead of using goto. > I'm sorry, I should have added Nick to this patch, since he suggested it. Suggested-by: Nick Desaulniers Cheers, Anders > Signed-off-by: Anders Roxell > --- > tools/testing/selftests/clone3/clone3_set_tid.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/tools/testing/selftests/clone3/clone3_set_tid.c b/tools/testing/selftests/clone3/clone3_set_tid.c > index a755fcd3af89..1b950c3c3b7c 100644 > --- a/tools/testing/selftests/clone3/clone3_set_tid.c > +++ b/tools/testing/selftests/clone3/clone3_set_tid.c > @@ -250,7 +250,8 @@ int main(int argc, char *argv[]) > * that all those tests are skipped as non-root. > */ > ksft_cnt.ksft_xskip += ksft_plan - ksft_test_num(); > - goto out; > + ksft_exit_skip( > + "Please run the remaining tests as root - Exiting.\n"); > } > > /* Find the current active PID */ > @@ -371,9 +372,7 @@ int main(int argc, char *argv[]) > close(pipe_2[1]); > > if (waitpid(ns_pid, &status, 0) < 0) { > - ksft_print_msg("Child returned %s\n", strerror(errno)); > - ret = -errno; > - goto out; > + ksft_exit_fail_msg("Child returned %s\n", strerror(errno)); > } > > if (!WIFEXITED(status)) > @@ -390,10 +389,6 @@ int main(int argc, char *argv[]) > ksft_test_result_fail( > "PIDs in all namespaces not as expected (%d,%d,%d)\n", > ns3, ns2, ns1); > -out: > - ret = 0; > > - if (ret) > - ksft_exit_fail(); > ksft_exit_pass(); > } > -- > 2.33.0 >