From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx123.postini.com [74.125.245.123]) by kanga.kvack.org (Postfix) with SMTP id C58606B005D for ; Thu, 10 Jan 2013 21:40:03 -0500 (EST) Received: by mail-ee0-f42.google.com with SMTP id b47so238934eek.29 for ; Thu, 10 Jan 2013 18:40:02 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1357870727.27446.2988.camel@edumazet-glaptop> References: <20130111004915.GA15415@dcvr.yhbt.net> <1357869675.27446.2962.camel@edumazet-glaptop> <1357870727.27446.2988.camel@edumazet-glaptop> Date: Thu, 10 Jan 2013 21:40:01 -0500 Message-ID: Subject: Re: 3.8-rc2/rc3 write() blocked on CLOSE_WAIT TCP socket From: Neal Cardwell Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Eric Dumazet Cc: Eric Wong , David Miller , Netdev , Mel Gorman , linux-mm@kvack.org, LKML , Rik van Riel , Minchan Kim , Andrew Morton , Linus Torvalds On Thu, Jan 10, 2013 at 9:18 PM, Eric Dumazet wrote: > From: Eric Dumazet > > On Thu, 2013-01-10 at 18:01 -0800, Eric Dumazet wrote: > >> Hmm, it might be commit c3ae62af8e755ea68380fb5ce682e60079a4c388 >> tcp: should drop incoming frames without ACK flag set >> >> It seems RST should be allowed to not have ACK set. >> >> I'll send a fix, thanks ! > > Yes, thats definitely the problem, sorry for that. > > > [PATCH] tcp: accept RST without ACK flag > > commit c3ae62af8e755 (tcp: should drop incoming frames without ACK flag > set) added a regression on the handling of RST messages. > > RST should be allowed to come even without ACK bit set. We validate > the RST by checking the exact sequence, as requested by RFC 793 and > 5961 3.2, in tcp_validate_incoming() > > Reported-by: Eric Wong > Signed-off-by: Eric Dumazet Acked-by: Neal Cardwell neal -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org