From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D267C5AD49 for ; Wed, 28 May 2025 15:16:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9BF236B007B; Wed, 28 May 2025 11:16:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 96FF86B0082; Wed, 28 May 2025 11:16:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 885786B0089; Wed, 28 May 2025 11:16:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6A1666B007B for ; Wed, 28 May 2025 11:16:39 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E1982E9132 for ; Wed, 28 May 2025 15:16:38 +0000 (UTC) X-FDA: 83492668476.17.6653B0E Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf06.hostedemail.com (Postfix) with ESMTP id 0DD6F180013 for ; Wed, 28 May 2025 15:16:36 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=CvR9K0NM; dmarc=pass (policy=reject) header.from=purestorage.com; spf=pass (imf06.hostedemail.com: domain of csander@purestorage.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=csander@purestorage.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748445397; a=rsa-sha256; cv=none; b=HNfHhC+/4SktlNgV1+UyPR5EtwtB4kTa46+OEOWwoXn7xSOvPsgmh7lH2asWjrh+e0mWtD EqF2whOMgvyl7RPeiQB4Ec2DfoGYtgvhOQkUz2mtfTv1nOWhEDd+4eaGh38/1ZekXbnI1H Yb/IRfOQzrmyu+eZ3wldFHWwbG2Nk7k= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=CvR9K0NM; dmarc=pass (policy=reject) header.from=purestorage.com; spf=pass (imf06.hostedemail.com: domain of csander@purestorage.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=csander@purestorage.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748445397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9RzDNT2OTFzwrTpW2QhZAxDyX5hWvQosjJ6d0+XM2Bo=; b=sDu3bOJloFu69LuDi77dCFD+38QhkO2POsU/9IcEe+pD6J/WuggU3F38D1hHw6LTdacxqL u8PlX8th8oiezBuLJ60fxo19YXumTkD9wMLxu8eZcpu52Zx8VDM72W2/MnbAhVrVYrzO47 LEn/5uqVVszzCOZYNeSTO6tDLVqbVj8= Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-311676255c3so315305a91.3 for ; Wed, 28 May 2025 08:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1748445396; x=1749050196; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9RzDNT2OTFzwrTpW2QhZAxDyX5hWvQosjJ6d0+XM2Bo=; b=CvR9K0NM/1EgVK+mj3+x8YomVn/79rrAE/7HeLpmTRSplGc8lww48ARMos37zAZ2gs wo7vrMWTH//8cuzsT84N9JTj/f6nGJyzvnjjVMg3Eaa9BXpipiCdKuMDNcssk3AAxC4R wwPGnHG6bVoO3paYgtMG2GFrmac8Gr2Vr3v809tqHm1JXD+tzlPKWlUDusVWa0q32hZv +yjUNVKonsfQ8VSkPFxVFj163R6uhtfMijy6HUNPQbbRalJ/LuanzQaZ6ztDK3fekhjA kdhrgKPZDlkLN4ZclF4/UYSVMhXpunh7wW2nbSHEmUK5hqAL+oILfypXeHW9T9dBSc+M pQOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748445396; x=1749050196; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9RzDNT2OTFzwrTpW2QhZAxDyX5hWvQosjJ6d0+XM2Bo=; b=o4HjqNOBVB8ez/eGiRnQJc49b8K+a01HkQp1ShgfbA6ptWeHrgvaZbC0NuIH0omudQ xtZwqgbBybrOJwjRYimyk+nLlRkQz8caFnrGuZRiw5YZCbYcRA8deUAUmSmMV8tugltU TTFqcQtmfHnkOc9vhJazYe846g+OhNV3Lf9spuVbvQEIPdbQyBkQGchKei2kaGUk2pgK qLJotm20grF4A+/KDumGVb7KZpWakMe3RttBYJyKOR8WgOCa7siyE6fmrOB1/PhN8UFw CTXRLX+nEAzfAKo5eToJ6NpaKSnLU4tCIl9utynK6s9BuGt0q7QorgCf0LPGrrZM6OrX OZ+Q== X-Forwarded-Encrypted: i=1; AJvYcCVlE+16R5cmskrfFZgiWxfip6jwMt603TEZvtdP0uVjeCK/5663lVADcuLp84HKfoE9P0qy/o27JQ==@kvack.org X-Gm-Message-State: AOJu0YwEMtkZR0E3+Gnzt/sRa5ZJXE05jNnkus3vi81CDWgRagPC+tGb f6qgHTqdlalCbucXTTZCZNViDrllrHpwg0Cly1iQyiRg2VllzPQHkMfJcH10YMLYbF/2dIJds9E RSV7xStSfrb19SOqeVxeA7Kmyeu8BRigNQnMCh7250A== X-Gm-Gg: ASbGnct3+lUnKM9v6Bkb9Z39FxOiiqnaJBMwrfFUuyzbtzhmbcuUiOuRaly5c5DgInM FZr1uu923QFdzOrocyYRHeRQBlK5IRzHlSmVGRbDw8HbonQkG5oSjME76hHYygGk8CpvXQaJzLp /Ur3XBBut6Fc9SKDRY0QIvrUQJTKSNGHQI X-Google-Smtp-Source: AGHT+IHk/hFwszn+lGW4RY3KI45JUHzvCbI/GU7IlZ6KImluQy2hWku6LQLjd67CNr1rcUJjul/qPMYZDMndG3LG9Mc= X-Received: by 2002:a17:90a:e7cd:b0:311:c5d9:2c8b with SMTP id 98e67ed59e1d1-311c5d93147mr3267754a91.5.1748445395685; Wed, 28 May 2025 08:16:35 -0700 (PDT) MIME-Version: 1.0 References: <20250411161746.1043239-1-csander@purestorage.com> <3ucksa6coiwco3wpmcjtfwezqjigzm2zwvdvkt2ryvefzojtqy@4lda47c236uz> In-Reply-To: <3ucksa6coiwco3wpmcjtfwezqjigzm2zwvdvkt2ryvefzojtqy@4lda47c236uz> From: Caleb Sander Mateos Date: Wed, 28 May 2025 08:16:24 -0700 X-Gm-Features: AX0GCFuDb9gBXu2ZIGF6ICRVSiBRQ0nrfOWmiTmw7s1LAbIKsh9w7lElDPYOc0M Message-ID: Subject: Re: [PATCH] mm: remove unused mmap tracepoints To: Andrew Morton , "Liam R . Howlett" , Lorenzo Stoakes Cc: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Eric Mueller , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Jann Horn , Pedro Falcato Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 0DD6F180013 X-Stat-Signature: pgtkggmkoe3mxqsg3f9egayuxbbtysok X-Rspam-User: X-HE-Tag: 1748445396-796859 X-HE-Meta: U2FsdGVkX1/8Ee6ZdJFqqJBstzL1lkgOaBLLluXc+QqYUbAMPnCflmsGXt94Q/o6sLcBV7ke5faXAb8IjTa2jYgOrIjdOzKYFuVpz7XWqfw1NDvGyaAdqIvCMOlk7LBQWcXllLBhiwre0haaRrYOR8IhE96IbqWnVTqSyYKW/EzUaV3ZCM5BJI6O0uDL1XZs/Zxjkusej+Zum1H2AudOEzme2e0YdwdSyb0rjTbRZC8VR2Mk270USzKnd6ZpbD/4IapJLrYY/hxbA4uf+cbs3mvcvnNIkP77RLlHXmkKNJcVWpjA4zOj1Bqxoa6DyeRMAjwOYFLCyeN4D7HxLsgBFY03P/b81iS12Gb3BZKLBVewKRARy5IB/823Ww6BbnFNjixAFy0ro6EEUGrO752G1GIDPujrGoaIp1ozmS9+98AotyvqvL53tpmEAHMAieBZhTFBWwG52fEq50QpsWYH1HLhdmL93Hw6nWU7V8pv963xv4euz04xdD4dDsh6696zf6ve+N7H7sf5D7GravstxVFM7sf63H15Kzp+UBi1nF0LklZSBEvSpdSpwUkjYnW/aLKeve13t0YnUGQCYOyVU/6td4wSu1DE6JGd4MLFmC6i2e5Xu8Q6VsmxNGY8Sd0eSS5EB4Y5GjkOVc+xykNXA2JMuYOm8xKapDgnc+meJpdCvRt8/TCHpNJmxQH6CIkgMoTUfhfg+9qmMcAFxfgX1ImWXxCT47ghkQWdWRlR5X9i3z3nZEfUYFo7ofyRV9pIeRNLtfrxVT3aEAPPyARbx2PzjdImmmgrJGGadMWALgueDXkkR087tSZl1oLA0vvS7X9pH8qe4oWrBjMOlXebTKDWNHIEB0lpi/TMGqBP7FT0gqfzN3/j4ZObzoeBm3XFPL5jxHHP3a5bo01cTxB3XyPDoLTsfU3aA/58uDAJEV3L+cJVx7GzeQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi MM folks, Would you mind picking up this patch to remove some old tracepoints? Liam has already given it a review. Thanks, Caleb On Fri, Apr 11, 2025 at 10:23=E2=80=AFAM Liam R. Howlett wrote: > > * Caleb Sander Mateos [250411 12:18]: > > The vma_mas_szero and vma_store tracepoints are unused since commit > > fbcc3104b843 ("mmap: convert __vma_adjust() to use vma iterator"). > > Remove them so they are no longer listed as available tracepoints. > > > > Thanks for doing this. > > Reviewed-by: Liam R. Howlett > > > Reported-by: Eric Mueller > > Signed-off-by: Caleb Sander Mateos > > --- > > include/trace/events/mmap.h | 52 ------------------------------------- > > 1 file changed, 52 deletions(-) > > > > diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h > > index f8d61485de16..ee2843a5daef 100644 > > --- a/include/trace/events/mmap.h > > +++ b/include/trace/events/mmap.h > > @@ -41,62 +41,10 @@ TRACE_EVENT(vm_unmapped_area, > > __entry->total_vm, __entry->flags, __entry->length, > > __entry->low_limit, __entry->high_limit, __entry->align_m= ask, > > __entry->align_offset) > > ); > > > > -TRACE_EVENT(vma_mas_szero, > > - TP_PROTO(struct maple_tree *mt, unsigned long start, > > - unsigned long end), > > - > > - TP_ARGS(mt, start, end), > > - > > - TP_STRUCT__entry( > > - __field(struct maple_tree *, mt) > > - __field(unsigned long, start) > > - __field(unsigned long, end) > > - ), > > - > > - TP_fast_assign( > > - __entry->mt =3D mt; > > - __entry->start =3D start; > > - __entry->end =3D end; > > - ), > > - > > - TP_printk("mt_mod %p, (NULL), SNULL, %lu, %lu,", > > - __entry->mt, > > - (unsigned long) __entry->start, > > - (unsigned long) __entry->end > > - ) > > -); > > - > > -TRACE_EVENT(vma_store, > > - TP_PROTO(struct maple_tree *mt, struct vm_area_struct *vma), > > - > > - TP_ARGS(mt, vma), > > - > > - TP_STRUCT__entry( > > - __field(struct maple_tree *, mt) > > - __field(struct vm_area_struct *, vma) > > - __field(unsigned long, vm_start) > > - __field(unsigned long, vm_end) > > - ), > > - > > - TP_fast_assign( > > - __entry->mt =3D mt; > > - __entry->vma =3D vma; > > - __entry->vm_start =3D vma->vm_start; > > - __entry->vm_end =3D vma->vm_end - 1; > > - ), > > - > > - TP_printk("mt_mod %p, (%p), STORE, %lu, %lu,", > > - __entry->mt, __entry->vma, > > - (unsigned long) __entry->vm_start, > > - (unsigned long) __entry->vm_end > > - ) > > -); > > - > > - > > TRACE_EVENT(exit_mmap, > > TP_PROTO(struct mm_struct *mm), > > > > TP_ARGS(mm), > > > > -- > > 2.45.2 > >