From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 477A3C3ABC0 for ; Wed, 7 May 2025 15:03:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D8B56B0099; Wed, 7 May 2025 11:03:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 189136B009A; Wed, 7 May 2025 11:03:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 077EF6B009B; Wed, 7 May 2025 11:03:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DC27E6B0099 for ; Wed, 7 May 2025 11:03:34 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3F0D6C0633 for ; Wed, 7 May 2025 15:03:36 +0000 (UTC) X-FDA: 83416430832.18.70BD949 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf07.hostedemail.com (Postfix) with ESMTP id F358040018 for ; Wed, 7 May 2025 15:03:33 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=ENj9MDIq; dmarc=pass (policy=reject) header.from=purestorage.com; spf=pass (imf07.hostedemail.com: domain of csander@purestorage.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=csander@purestorage.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746630214; a=rsa-sha256; cv=none; b=In+zyB4cxwgBaJY0Gy4jaNI8oCEpaBO/XPfJssFX8sMJr8RNRcxTFUx/MNhKQmULXRoJZz GVZrbtCb7kxlYP4BpHKdmteT8zb6c2rmfOVsokl/Gc9Cvj5OHVj1T/jeih2xymzQiyEgoF h8Te+MIOMD19FveiZQEsyp0irtvsPuE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=ENj9MDIq; dmarc=pass (policy=reject) header.from=purestorage.com; spf=pass (imf07.hostedemail.com: domain of csander@purestorage.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=csander@purestorage.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746630214; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1s8LxSgdpw/QFNWhayU6GhU6VvikEqRstbNbkkV5cHs=; b=1iF7q0TFgdpc23AyMK3fCU8oAx5dScEcqxe1hcP/jYTOxfB2n1t1d2YsFy38OSwla8AYeO jc8mvptdPSpBUwxrCqSC7RYlxAfMHOyvm6I/E8RnEDwetzZyU9LjlouhE8FSr52eQKELif 3zd7HWDqSxJHUmdeL/tU5LDytuVKYzM= Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-22e696bbc85so967855ad.2 for ; Wed, 07 May 2025 08:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1746630213; x=1747235013; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1s8LxSgdpw/QFNWhayU6GhU6VvikEqRstbNbkkV5cHs=; b=ENj9MDIqVcH0AkJOXc9u0O27NgDs0yMEvNTVeeldOc4bfV5/JUZnrkr2oTfRlOKlmE FLIozwyhlOy7N4ekWKaQac9HENiEtyZuwR/9jJU/9uqF82jkc5Qg4S7h6cKpMmGesW+g 9XpxU9SW+O8rmRb703z6LxD7zC9V+99zlyfJiDntXd3jeS/sYM8MLJESyHKaYM4MwdKZ 52GqiN4xg5+HDJkO35NkIRdDGUimrdY0o8x24Bhg8CBJxYVPMESEzDpajS4K64elheCh oGbkOOUBlXLAxpQymTrymjznrbqVutnAbA4QGGFCu2e+aRJ/rm5uf4Z+zVlj3wwt/kjz 0wdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746630213; x=1747235013; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1s8LxSgdpw/QFNWhayU6GhU6VvikEqRstbNbkkV5cHs=; b=qqdjMcnRHLGsVSXQd5a3TDVVwPXrCxkei7UOVQzJ4tmFO1UIcLL+Le3jhHKC3iLMKo F6VK//ozQvCjNdNJvDWVUMtqZcj6rTBf/Zliy/f187UOYBXsmC/tjttLPAZau6jQqcNg hlgicBi4RLPgK0mkCMwJlvEmzfMnATLefgH4GYT9Xe4Auld0WKIZgoSg1sn3dmqWxq+6 7eV0OtzAbp9Vob/+Nd3KvM+Y/5gp7pNJuY+bfi3KQWCdnwM26PgcuNHiEmXyelhWRNUW OBVoeMX92HS+d8VekuGRzIdkiZyBuFUlkAwcL2u7d5gblz2VDe3xzya/an/e+AYINxrR ufEA== X-Forwarded-Encrypted: i=1; AJvYcCWheWi5jKnUNvzvfIdk6wHACPwiVNTAyV/2RfXd9J/GA70qdlz4FXh3WTF04RD14qfpPN2LPEOI8A==@kvack.org X-Gm-Message-State: AOJu0YyBkPdMvTZaqkq783Ot5Hxxs3fDkbZGwBh6Cdob+KJSXXybnreT PfnQTQ7es0DsO9ylgL4r2klHbv80ObxutRPb6hvWJvLWPoPMTt0l43tvXFyUNg6G0Y3Aq6XngCE Py1Y1J6fqLHb79BzC7nUQHNxYZWqDg/G1bfDFKw== X-Gm-Gg: ASbGncupscuPmFBC7P1UPNbwY/GJ9ub3C5vdSf73EnrsE1cDpKDq84Xp8VXfl9bEDYK i+WSamcWOdC6LG0wodM/2lLkn8nklcZqqeX9qGf91ygNUFn6Pp3eB21UVprYkPU4Pz3ELQ4zrqb KwV0YU1w5mVPbijmxRNHgr X-Google-Smtp-Source: AGHT+IGVRdVpmD42Zl1K9/CFzNk9/9fbzp0SeC722EZPTJKMkP3YbezVcTCIZOjRu3Yyi3o0XRR2Kv7U8ekDo75qkiA= X-Received: by 2002:a17:903:990:b0:223:28a8:610b with SMTP id d9443c01a7336-22e5ee1cb10mr16787145ad.14.1746630212740; Wed, 07 May 2025 08:03:32 -0700 (PDT) MIME-Version: 1.0 References: <20250426020636.34355-1-csander@purestorage.com> <20250426020636.34355-3-csander@purestorage.com> <20250507071610.GB1413@lst.de> In-Reply-To: <20250507071610.GB1413@lst.de> From: Caleb Sander Mateos Date: Wed, 7 May 2025 08:03:20 -0700 X-Gm-Features: ATxdqUG1uu45_rIP1595jmow33H5jf2cu-Lb4HqU3C1enyWziA9-fbza28d3E8s Message-ID: Subject: Re: [PATCH v6 2/3] nvme/pci: factor out nvme_init_hctx() helper To: Christoph Hellwig Cc: Keith Busch , Jens Axboe , Sagi Grimberg , Andrew Morton , Kanchan Joshi , linux-nvme@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F358040018 X-Stat-Signature: b8pcx6w4ty6ehxkyj4y4etyrmexkxyya X-Rspam-User: X-HE-Tag: 1746630213-133444 X-HE-Meta: U2FsdGVkX19mHisC8lnk3msgWLclZqbTO3M3Hc5ExyxhLG7Sqf5YjeCCPH4lX8xT1zWUO2/Nae0TltU2iExIhXGQ18H9vtZ6iUWRaXSov25kMVMVgSQw3XFqFfVIi/HPn2pMuKTIH5i4g55WMKj/S4HEgP7BccqtJDOWvM5qelDyLbHjHc2QyMg9QdT0y7m5mQHv95KiQA1f5RVcqG8JPmtdFbk5BBYtj+3++1NRMRYaeK4WBDctv3r+QFtFstDLyMdOJhV7dG9v7cL3AdrpNBYP8Ivwn014wbbj8lagWR/LECnVNG7T3yFRZfMrHC8IsGpMeADtpjzp2qBaTus90EkG/2llQp8rHwkRKXBhH+2DIvF6RHwpIQddfstfioNsT/cAnqv5T4vxjvtp5lE4l9XdQz1/oJQ23+RVakRqWKjrO2Y/T2R7Htk+xd6OqzJbbjwh/Abqi97fM9vimOLBQnBhfvacgfEv+ZWSuE+lR0IHCVDApXOVFstFBT4iMkQd0sHReVhzK/QQQJQqLupPm+r4R6B8Vr5ODFcqBcvEIDuIUoMv8MeMnCHZ17LpvoiV5EM0/xTgLh4lEkHdIvNwKZTPSXB5yH51l3mEKAAO9VNR2Sa0TZ/b/W6KtZcYsCSJK34zaHg10+Fqjm7qQlr9MuwnUdf5LIR3EainsId6EIezeOkLi5ZN/pvqRDO7ulmR31e7PuViDTOAu9Kui/CEPNBAwDfySVEvy4iho1cd4VSV+NJ86DKUKS+wSWAXc2w/G5O5f3bNzbSDuHhTPayhz8VTfJwFI9+xqAqHS0nrM4N5RUt9WVJxqWSPa0UVl+F/S4qUhmdpyxS0xctDH14JxZK+ovHnXmEbankt+zKcQ2gO2rB8ocXasKE4eLhFBAX92tT/mA2aVVGs9EkJcfRMwJxNdOtc6KQUYLhjNWZxmG7+v9zLwAtYP3XEga6+7204SviyeeqtP7iH7KKVvK3 widdNElu FJCFszATKYK/ileT0hkVzJx8I88KQFP/qn4756fQUTiiAIVs1jhWoGBwUytpMpB50TsmlTp8eDDGjdkIe8Wn8r4V3y3rtyOWQCyq4Cb1hEd403ib+I6O974Dkyi7U2lwq1pRM26EHb5zoFRHJhLQ+rCbSeHhm67ejdpkuRzUMlqJUMajMZKPu/SJHt1QFtYhl2Hq4rN1KZXGBZ7iOfjLcbwcCGYslwFJ7awTMANDwxby99i5AioY1wTpuecKbZ/8z1rft74NHgKqYkgbKaUNeTnQK0/Xeu309Ks90 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 7, 2025 at 12:16=E2=80=AFAM Christoph Hellwig wrot= e: > > > - .init_hctx =3D nvme_init_hctx, > > + .init_hctx =3D nvme_io_init_hctx, > > Without an overall rename of the methods I'd rather avoid the _io > here and pick a _common name for the common helper. Sure, that's fine too. Best, Caleb > > I can fix that up when applying, no need to resend. >