From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id E76DC6B002C for ; Mon, 10 Oct 2011 02:58:37 -0400 (EDT) Received: by wyh15 with SMTP id 15so3043994wyh.14 for ; Sun, 09 Oct 2011 23:58:34 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <201110071827.06366.arnd@arndb.de> References: <1317909290-29832-1-git-send-email-m.szyprowski@samsung.com> <201110071827.06366.arnd@arndb.de> From: Ohad Ben-Cohen Date: Mon, 10 Oct 2011 08:58:14 +0200 Message-ID: Subject: Re: [Linaro-mm-sig] [PATCHv16 0/9] Contiguous Memory Allocator Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Arnd Bergmann Cc: Marek Szyprowski , Ankita Garg , Daniel Walker , Russell King , Jesse Barker , Mel Gorman , Chunsang Jeong , Jonathan Corbet , linux-kernel@vger.kernel.org, Michal Nazarewicz , Dave Hansen , linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, Kyungmin Park , KAMEZAWA Hiroyuki , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org On Fri, Oct 7, 2011 at 6:27 PM, Arnd Bergmann wrote: > IMHO it would be good to merge the entire series into 3.2, since > the ARM portion fixes an important bug (double mapping of memory > ranges with conflicting attributes) that we've lived with for far > too long, but it really depends on how everyone sees the risk > for regressions here. If something breaks in unfixable ways before > the 3.2 release, we can always revert the patches and have another > try later. I didn't thoroughly review the patches, but I did try them out (to be precise, I tried v15) on an OMAP4 PandaBoard, and really liked the result. The interfaces seem clean and convenient and things seem to work (I used a private CMA pool with rpmsg and remoteproc, but also noticed that several other drivers were utilizing the global pool). And with this in hand we can finally ditch the old reserve+ioremap approach. So from a user perspective, I sure do hope this patch set gets into 3.2; hopefully we can just fix anything that would show up during the 3.2 cycle. Marek, Michal (and everyone involved!), thanks so much for pushing this! Judging from the history of this patch set and the areas that it touches (and from the number of LWN articles ;) it looks like a considerable feat. FWIW, feel free to add my Tested-by: Ohad Ben-Cohen (small and optional comment: I think it'd be nice if dma_declare_contiguous would fail if called too late, otherwise users of that misconfigured device will end up using the global pool without easily knowing that something went wrong) Thanks, Ohad. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org