From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5C7C12002 for ; Fri, 16 Jul 2021 05:58:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EF193611AB for ; Fri, 16 Jul 2021 05:58:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF193611AB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6092D8D00F5; Fri, 16 Jul 2021 01:58:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B9328D00EC; Fri, 16 Jul 2021 01:58:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45A7E8D00F5; Fri, 16 Jul 2021 01:58:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 25C758D00EC for ; Fri, 16 Jul 2021 01:58:10 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D0942276F2 for ; Fri, 16 Jul 2021 05:58:08 +0000 (UTC) X-FDA: 78367395456.02.A93B21B Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf02.hostedemail.com (Postfix) with ESMTP id 8A0647001A08 for ; Fri, 16 Jul 2021 05:58:08 +0000 (UTC) Received: by mail-ej1-f46.google.com with SMTP id hr1so13439296ejc.1 for ; Thu, 15 Jul 2021 22:58:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZNIcsNcApjis1NTktSvCbyBOryqsRvjiOQV2BWDb6+s=; b=TQK6m8gh6eyv4XcwUSnojbI5yha7V2HVDNN/U9sVHqD+EC3Dq+C+1TUL+URviz+Cl1 YmvUoGJMfZy4IyYdzAM0CyEPWMmNn4XPzKZiO7TwpHMU3jwrPaD7HiWSOx2g4a587/jD QiA0+yy51X1Flg/tVhRxwlrQpFX5lh1S0Rx2YxCgz2EIeSXy37yZ3W3GEhaQRVXl8evQ WJxNkP5I+19UdslLT1+jyuD1e1vMZ/8Ywp3Xn1l0YJqV8josqefmVRSPA8+3bft1rVCc mAB4j1cvys/AsWcrL2PcJfvCTO+XNg+zh4uOtVcVdJ81unLz2qRgmRHaPrO939kOPgWv pTjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZNIcsNcApjis1NTktSvCbyBOryqsRvjiOQV2BWDb6+s=; b=U45oSp3UFgRC1WHirYBZwdtwdel49IbOGaAJCzbqTM+ZW5i4CqFNsZHF/ezwxoEqpY RbEkoT9g1vCSBi2b3ZXPeo6SCL2r10+KXfVvUq5MyOrrF5zt2FpFRK3+tMZQltGXonot jXVGUox2C5Zs3LOHAxS29kg0CTRV3WRf1SjASvJxTKgtL7iJ1Q9CEQ5PO5fo6yGCrc7K rLImqnaSys/4iLAYQBzoxZKdLVXWiSITILU7G0oeQURppsPFbBiFj+u4pC6eWlog4J0m mPC3yOeEsufIblExkZhkhcPdmtyfZChBwyERoIlN4Vksu/PYBRNqWO0XDW2IYlb8AarL ATDg== X-Gm-Message-State: AOAM533kOi4QaaVxfhes5z4Ea8G8EORxYQO4osj8Ks3oiAb51EnG+ms8 E42uGjfu0OYGUtdLOBab0OkwDZuIytVyFN4VkNI= X-Google-Smtp-Source: ABdhPJx9RyRmynPnAevrG0jIgHpc02Z/2HATtBbLS1hEWhAQ6BQWzQyP0U2JuhgYypWz0KTIcuiTSLPvbOoRFUP6HYY= X-Received: by 2002:a17:906:4a0a:: with SMTP id w10mr10004083eju.371.1626415087288; Thu, 15 Jul 2021 22:58:07 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Murphy Zhou Date: Fri, 16 Jul 2021 13:57:55 +0800 Message-ID: Subject: Re: [fsdax xfs] Regression panic at inode_switch_wbs_work_fn To: Roman Gushchin Cc: Linux-Fsdevel , Linux MM Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=TQK6m8gh; spf=pass (imf02.hostedemail.com: domain of jenccekernel@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=jenccekernel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: 6111wj6ubqk7b7ji198bkkmzft4hdjog X-Rspamd-Queue-Id: 8A0647001A08 X-Rspamd-Server: rspam01 X-HE-Tag: 1626415088-182214 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On Fri, Jul 16, 2021 at 12:07 AM Roman Gushchin wrote: > > On Thu, Jul 15, 2021 at 06:10:22PM +0800, Murphy Zhou wrote: > > Hi, > > > > #Looping generic/270 of xfstests[1] on pmem ramdisk with > > mount option: -o dax=always > > mkfs.xfs option: -f -b size=4096 -m reflink=0 > > can hit this panic now. > > > > #It's not reproducible on ext4. > > #It's not reproducible without dax=always. > > Hi Murphy! > > Thank you for the report! > > Can you, please, check if the following patch fixes the problem? No. Still the same panic. > > Thank you! > > -- > > diff --git a/mm/backing-dev.c b/mm/backing-dev.c > index 271f2ca862c8..f5561ea7d90a 100644 > --- a/mm/backing-dev.c > +++ b/mm/backing-dev.c > @@ -398,12 +398,12 @@ static void cgwb_release_workfn(struct work_struct *work) > blkcg_unpin_online(blkcg); > > fprop_local_destroy_percpu(&wb->memcg_completions); > - percpu_ref_exit(&wb->refcnt); > > spin_lock_irq(&cgwb_lock); > list_del(&wb->offline_node); > spin_unlock_irq(&cgwb_lock); > > + percpu_ref_exit(&wb->refcnt); > wb_exit(wb); > WARN_ON_ONCE(!list_empty(&wb->b_attached)); > kfree_rcu(wb, rcu);