From: Ganesh Mahendran <opensource.ganesh@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
rostedt@goodmis.org, mingo@redhat.com
Subject: Re: [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface
Date: Wed, 6 Jul 2016 14:20:05 +0800 [thread overview]
Message-ID: <CADAEsF8hTsbcfQ8vBOhL=NZM2WdjY6Vfq9qs6BQTBf2P7pqxoQ@mail.gmail.com> (raw)
In-Reply-To: <20160706023232.GB13566@bbox>
2016-07-06 10:32 GMT+08:00 Minchan Kim <minchan@kernel.org>:
> Hi Ganesh,
>
> On Mon, Jul 04, 2016 at 02:49:52PM +0800, Ganesh Mahendran wrote:
>> This patch changes trace_zsmalloc_compact_start[end] to
>> trace_zs_compact_start[end] to keep function naming consistent
>> with others in zsmalloc
>>
>> Also this patch remove pages_total_compacted information which
>> may not really needed.
>>
>> Signed-off-by: Ganesh Mahendran <opensource.ganesh@gmail.com>
>
> Once we decide to add event trace, I prefer getting more detailed
> information which is hard to get it via /sys/block/zram/.
> So, we can add trace __zs_compact as well as zs_compact with
> some changes.
>
> IOW,
>
> zs_compact
> trace_zs_compact_start(pool->name)
> __zs_compact
> trace_zs_compact(class, scanned_obj, freed_pages)
> trace_zs_compact_end(pool->name)
Thanks, I will do it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-07-06 6:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 6:49 Ganesh Mahendran
2016-07-04 6:49 ` [PATCH v2 2/8] mm/zsmalloc: use obj_index to keep consistent with others Ganesh Mahendran
2016-07-05 1:25 ` Sergey Senozhatsky
2016-07-06 2:37 ` Minchan Kim
2016-07-04 6:49 ` [PATCH v2 3/8] mm/zsmalloc: take obj index back from find_alloced_obj Ganesh Mahendran
2016-07-05 1:32 ` Sergey Senozhatsky
2016-07-06 2:40 ` Minchan Kim
2016-07-04 6:49 ` [PATCH v2 4/8] mm/zsmalloc: use class->objs_per_zspage to get num of max objects Ganesh Mahendran
2016-07-05 1:30 ` Sergey Senozhatsky
2016-07-04 6:49 ` [PATCH v2 5/8] mm/zsmalloc: avoid calculate max objects of zspage twice Ganesh Mahendran
2016-07-05 1:18 ` Sergey Senozhatsky
2016-07-06 2:41 ` Minchan Kim
2016-07-04 6:49 ` [PATCH v2 6/8] mm/zsmalloc: keep comments consistent with code Ganesh Mahendran
2016-07-05 1:11 ` Sergey Senozhatsky
2016-07-06 2:41 ` Minchan Kim
2016-07-04 6:49 ` [PATCH v2 7/8] mm/zsmalloc: add __init,__exit attribute Ganesh Mahendran
2016-07-04 8:43 ` Sergey Senozhatsky
2016-07-04 9:21 ` Ganesh Mahendran
2016-07-05 1:00 ` Sergey Senozhatsky
2016-07-06 2:48 ` Minchan Kim
2016-07-06 6:21 ` Ganesh Mahendran
2016-07-04 6:49 ` [PATCH v2 8/8] mm/zsmalloc: use helper to clear page->flags bit Ganesh Mahendran
2016-07-04 8:45 ` Sergey Senozhatsky
2016-07-05 16:50 ` [PATCH v2 1/8] mm/zsmalloc: modify zs compact trace interface Steven Rostedt
2016-07-06 2:32 ` Minchan Kim
2016-07-06 6:20 ` Ganesh Mahendran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADAEsF8hTsbcfQ8vBOhL=NZM2WdjY6Vfq9qs6BQTBf2P7pqxoQ@mail.gmail.com' \
--to=opensource.ganesh@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=ngupta@vflare.org \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox