From: Ganesh Mahendran <opensource.ganesh@gmail.com>
To: Weijie Yang <weijie.yang@samsung.com>
Cc: Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/zram: correct ZRAM_ZERO flag bit position
Date: Thu, 13 Nov 2014 21:54:49 +0800 [thread overview]
Message-ID: <CADAEsF87zYnN=6=HxvEhrfm8ridND-kvHAvh6sM_6vB9qHMDww@mail.gmail.com> (raw)
In-Reply-To: <000001cffee1$28362ed0$78a28c70$%yang@samsung.com>
2014-11-13 9:27 GMT+08:00 Weijie Yang <weijie.yang@samsung.com>:
> On Thu, Nov 13, 2014 at 8:02 AM, Minchan Kim <minchan@kernel.org> wrote:
>> On Wed, Nov 12, 2014 at 10:37:18PM +0800, Mahendran Ganesh wrote:
>>> In struct zram_table_entry, the element *value* contains obj size and
>>> obj zram flags. Bit 0 to bit (ZRAM_FLAG_SHIFT - 1) represent obj size,
>>> and bit ZRAM_FLAG_SHIFT to the highest bit of unsigned long represent obj
>>> zram_flags. So the first zram flag(ZRAM_ZERO) should be from ZRAM_FLAG_SHIFT
>>> instead of (ZRAM_FLAG_SHIFT + 1).
>>>
>>> This patch fixes this issue.
>>>
>>> Also this patch fixes a typo, "page in now accessed" -> "page is now accessed"
>>>
>>> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
>> Acked-by: Minchan Kim <minchan@kernel.org>
>
> Acked-by: Weijie Yang <weijie.yang@samsung.com>
Thanks
>
>> To be clear about "fixes this issue", it's not a bug but just clean up
>> so it doesn't change any behavior.
>>
>> Thanks!
>>
>> --
>> Kind regards,
>> Minchan Kim
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-11-13 13:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 14:37 Mahendran Ganesh
2014-11-13 0:02 ` Minchan Kim
2014-11-13 1:27 ` Weijie Yang
2014-11-13 13:54 ` Ganesh Mahendran [this message]
2014-11-13 13:54 ` Ganesh Mahendran
2014-11-13 14:55 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADAEsF87zYnN=6=HxvEhrfm8ridND-kvHAvh6sM_6vB9qHMDww@mail.gmail.com' \
--to=opensource.ganesh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=weijie.yang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox